Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Simplify supportsMediaTypeConversion arguments.

Browse Source
This commit is contained in:
Ruben Verborgh
2021-01-05 00:43:25 +01:00
parent 8cd3f7d2e5
commit 0bd73115cc
4 changed files with 29 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
test/unit/storage/conversion/ConversionUtil.test.ts
View File

@@ -1,63 +1,34 @@
import type { Representation } from '../../../../src/ldp/representation/Representation';
import { RepresentationMetadata } from '../../../../src/ldp/representation/RepresentationMetadata';
import type {
ValuePreferences,
RepresentationPreferences,
} from '../../../../src/ldp/representation/RepresentationPreferences';
import type { ResourceIdentifier } from '../../../../src/ldp/representation/ResourceIdentifier';
import type { ValuePreferences } from '../../../../src/ldp/representation/RepresentationPreferences';
import {
matchesMediaType,
matchingMediaTypes,
supportsConversion,
supportsMediaTypeConversion,
} from '../../../../src/storage/conversion/ConversionUtil';
import { InternalServerError } from '../../../../src/util/errors/InternalServerError';
describe('ConversionUtil', (): void => {
const identifier: ResourceIdentifier = { path: 'path' };
let representation: Representation;
let metadata: RepresentationMetadata;
describe('supportsMediaTypeConversion', (): void => {
it('requires preferences.', async(): Promise<void> => {
expect((): any => supportsMediaTypeConversion()).toThrow();
});
beforeEach(async(): Promise<void> => {
metadata = new RepresentationMetadata();
representation = { metadata } as Representation;
});
describe('#supportsConversion', (): void => {
it('requires an input type.', async(): Promise<void> => {
const preferences: RepresentationPreferences = {};
expect((): any => supportsConversion({ identifier, representation, preferences },
{ 'a/x': 1 },
{ 'a/x': 1 }))
.toThrow('No content type indicated on request.');
expect((): any => supportsMediaTypeConversion(undefined, { 'b/x': 1 }, { 'a/x': 1 }, { 'a/x': 1 }))
.toThrow('Cannot convert from unknown to b/x, only from a/x to a/x.');
});
it('requires a matching input type.', async(): Promise<void> => {
metadata.contentType = 'a/x';
const preferences: RepresentationPreferences =
{ type: { 'b/x': 1 }};
expect((): any => supportsConversion({ identifier, representation, preferences },
{ 'c/x': 1 },
{ 'a/x': 1 }))
.toThrow('Can only convert from c/x to a/x.');
expect((): any => supportsMediaTypeConversion('a/x', { 'b/x': 1 }, { 'c/x': 1 }, { 'a/x': 1 }))
.toThrow('Cannot convert from a/x to b/x, only from c/x to a/x.');
});
it('requires a matching output type.', async(): Promise<void> => {
metadata.contentType = 'a/x';
const preferences: RepresentationPreferences =
{ type: { 'b/x': 1 }};
expect((): any => supportsConversion({ identifier, representation, preferences },
{ 'a/x': 1 },
{ 'c/x': 1 }))
.toThrow('Can only convert from a/x to c/x.');
expect((): any => supportsMediaTypeConversion('a/x', { 'b/x': 1 }, { 'a/x': 1 }, { 'c/x': 1 }))
.toThrow('Cannot convert from a/x to b/x, only from a/x to c/x.');
});
it('succeeds with a valid input and output type.', async(): Promise<void> => {
metadata.contentType = 'a/x';
const preferences: RepresentationPreferences =
{ type: { 'b/x': 1 }};
expect(supportsConversion({ identifier, representation, preferences },
{ 'a/x': 1 },
{ 'b/x': 1 }))
expect(supportsMediaTypeConversion('a/x', { 'b/x': 1 }, { 'a/x': 1 }, { 'b/x': 1 }))
.toBeUndefined();
});
});