Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Make aggregated errors prettier

Browse Source
This commit is contained in:
Joachim Van Herwegen
2023-04-27 14:28:55 +02:00
parent 4b7621f9e0
commit 0d5d072f79
5 changed files with 35 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/unit/util/errors/HttpErrorUtil.test.ts
View File

@@ -3,7 +3,7 @@ import { createAggregateError, getStatusCode } from '../../../../src/util/errors
import { NotFoundHttpError } from '../../../../src/util/errors/NotFoundHttpError';
describe('ErrorUtil', (): void => {
describe('createAggregateError', (): void => {
describe('#createAggregateError', (): void => {
const error401 = new HttpError(401, 'UnauthorizedHttpError');
const error415 = new HttpError(415, 'UnsupportedMediaTypeHttpError');
const error501 = new HttpError(501, 'NotImplementedHttpError');
@@ -36,6 +36,19 @@ describe('ErrorUtil', (): void => {
name: 'InternalServerError',
});
});
it('has no error message if none of the errors had one.', async(): Promise<void> => {
expect(createAggregateError([ error401, error501 ]).message).toBe('');
});
it('copies the error message if there is one error with a message.', async(): Promise<void> => {
expect(createAggregateError([ error, error501 ]).message).toBe('noStatusCode');
});
it('joins the error messages if there are multiple.', async(): Promise<void> => {
expect(createAggregateError([ error, error, error501 ]).message)
.toBe('Multiple handler errors: noStatusCode, noStatusCode');
});
});
describe('#getStatusCode', (): void => {

4
test/unit/util/handlers/BooleanHandler.test.ts
View File

@@ -26,7 +26,7 @@ describe('A BooleanHandler', (): void => {
it('errors if none of its handlers supports the input.', async(): Promise<void> => {
const handler = new BooleanHandler([ handlerCanNotHandle, handlerCanNotHandle ]);
await expect(handler.canHandle(null)).rejects.toThrow('[Not supported, Not supported]');
await expect(handler.canHandle(null)).rejects.toThrow('Not supported, Not supported');
});
it('returns true if any of its handlers returns true.', async(): Promise<void> => {
@@ -51,6 +51,6 @@ describe('A BooleanHandler', (): void => {
it('throws the canHandle error when calling handleSafe with unsupported input.', async(): Promise<void> => {
const handler = new BooleanHandler([ handlerCanNotHandle, handlerCanNotHandle ]);
await expect(handler.handleSafe(null)).rejects.toThrow('[Not supported, Not supported]');
await expect(handler.handleSafe(null)).rejects.toThrow('Not supported, Not supported');
});
});

6
test/unit/util/handlers/HandlerUtil.test.ts
View File

@@ -17,12 +17,12 @@ describe('HandlerUtil', (): void => {
});
it('errors if there is no matching handler.', async(): Promise<void> => {
await expect(findHandler([ handlerFalse, handlerFalse ], null)).rejects.toThrow('[Not supported, Not supported]');
await expect(findHandler([ handlerFalse, handlerFalse ], null)).rejects.toThrow('Not supported, Not supported');
});
it('supports non-native Errors.', async(): Promise<void> => {
handlerFalse.canHandle = jest.fn().mockRejectedValue('apple');
await expect(findHandler([ handlerFalse ], null)).rejects.toThrow('[Unknown error: apple]');
await expect(findHandler([ handlerFalse ], null)).rejects.toThrow('Unknown error: apple');
});
});
@@ -42,7 +42,7 @@ describe('HandlerUtil', (): void => {
it('errors if there is no matching handler.', async(): Promise<void> => {
await expect(filterHandlers([ handlerFalse, handlerFalse ], null))
.rejects.toThrow('[Not supported, Not supported]');
.rejects.toThrow('Not supported, Not supported');
});
});
});

6
test/unit/util/handlers/WaterfallHandler.test.ts
View File

@@ -42,7 +42,7 @@ describe('A WaterfallHandler', (): void => {
it('can not handle data if no handler supports it.', async(): Promise<void> => {
const handler = new WaterfallHandler([ handlerFalse, handlerFalse ]);
await expect(handler.canHandle(null)).rejects.toThrow('[Not supported, Not supported]');
await expect(handler.canHandle(null)).rejects.toThrow('Not supported, Not supported');
});
it('throws unknown errors if no Error objects are thrown.', async(): Promise<void> => {
@@ -51,7 +51,7 @@ describe('A WaterfallHandler', (): void => {
};
const handler = new WaterfallHandler([ handlerFalse, handlerFalse ]);
await expect(handler.canHandle(null)).rejects.toThrow('[Unknown error: apple, Unknown error: apple]');
await expect(handler.canHandle(null)).rejects.toThrow('Unknown error: apple, Unknown error: apple');
});
it('handles data if a handler supports it.', async(): Promise<void> => {
@@ -79,7 +79,7 @@ describe('A WaterfallHandler', (): void => {
it('throws the canHandle error when calling handleSafe if the data is not supported.', async(): Promise<void> => {
const handler = new WaterfallHandler([ handlerFalse, handlerFalse ]);
await expect(handler.handleSafe(null)).rejects.toThrow('[Not supported, Not supported]');
await expect(handler.handleSafe(null)).rejects.toThrow('Not supported, Not supported');
});
});
});