From 0ed1ae539d5701aab450ed7bb7e7647f731669b3 Mon Sep 17 00:00:00 2001
From: Ruben Taelman <ruben.taelman@ugent.be>
Date: Mon, 7 Sep 2020 08:34:15 +0200
Subject: [PATCH] lint: enable no-extraneous-dependencies rule

This also uses the new `import type` syntax for importing rdf-js types,
as it is required for making this new linter rule pass.

Closes #132
---
 .eslintrc.js                                             | 1 +
 src/ldp/representation/RepresentationMetadata.ts         | 2 +-
 src/storage/FileResourceStore.ts                         | 2 +-
 src/storage/patch/SparqlUpdatePatchHandler.ts            | 2 +-
 src/util/MetadataController.ts                           | 2 +-
 test/unit/ldp/http/BasicResponseWriter.test.ts           | 2 +-
 test/unit/storage/patch/SparqlUpdatePatchHandler.test.ts | 2 +-
 7 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 88cfe03c2..425193af0 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -46,5 +46,6 @@ module.exports = {
       }
     }],
     'unused-imports/no-unused-imports-ts': 'error',
+    'import/no-extraneous-dependencies': 'error'
   },
 };
diff --git a/src/ldp/representation/RepresentationMetadata.ts b/src/ldp/representation/RepresentationMetadata.ts
index c675e83d3..db3894092 100644
--- a/src/ldp/representation/RepresentationMetadata.ts
+++ b/src/ldp/representation/RepresentationMetadata.ts
@@ -1,7 +1,7 @@
 /**
  * Contains metadata relevant to a representation.
  */
-import { Quad } from 'rdf-js';
+import type { Quad } from 'rdf-js';
 
 /**
  * Metadata corresponding to a {@link Representation}.
diff --git a/src/storage/FileResourceStore.ts b/src/storage/FileResourceStore.ts
index 20cb05b6f..ca65c395f 100644
--- a/src/storage/FileResourceStore.ts
+++ b/src/storage/FileResourceStore.ts
@@ -2,7 +2,7 @@ import { createReadStream, createWriteStream, promises as fsPromises, Stats } fr
 import { posix } from 'path';
 import { Readable } from 'stream';
 import { contentType as getContentTypeFromExtension } from 'mime-types';
-import { Quad } from 'rdf-js';
+import type { Quad } from 'rdf-js';
 import streamifyArray from 'streamify-array';
 import { RuntimeConfig } from '../init/RuntimeConfig';
 import { Representation } from '../ldp/representation/Representation';
diff --git a/src/storage/patch/SparqlUpdatePatchHandler.ts b/src/storage/patch/SparqlUpdatePatchHandler.ts
index 98e4a8b98..b860b309a 100644
--- a/src/storage/patch/SparqlUpdatePatchHandler.ts
+++ b/src/storage/patch/SparqlUpdatePatchHandler.ts
@@ -1,7 +1,7 @@
 import { Readable } from 'stream';
 import { defaultGraph } from '@rdfjs/data-model';
 import { Store } from 'n3';
-import { BaseQuad } from 'rdf-js';
+import type { BaseQuad } from 'rdf-js';
 import { someTerms } from 'rdf-terms';
 import { Algebra } from 'sparqlalgebrajs';
 import { SparqlUpdatePatch } from '../../ldp/http/SparqlUpdatePatch';
diff --git a/src/util/MetadataController.ts b/src/util/MetadataController.ts
index 900c4d7be..c5d2d0d05 100644
--- a/src/util/MetadataController.ts
+++ b/src/util/MetadataController.ts
@@ -2,7 +2,7 @@ import { Stats } from 'fs';
 import { Readable } from 'stream';
 import arrayifyStream from 'arrayify-stream';
 import { DataFactory, StreamParser, StreamWriter } from 'n3';
-import { NamedNode, Quad } from 'rdf-js';
+import type { NamedNode, Quad } from 'rdf-js';
 import streamifyArray from 'streamify-array';
 import { TEXT_TURTLE } from '../util/ContentTypes';
 import { LDP, RDF, STAT, TERMS, XML } from './Prefixes';
diff --git a/test/unit/ldp/http/BasicResponseWriter.test.ts b/test/unit/ldp/http/BasicResponseWriter.test.ts
index eb92b66d5..1c316c254 100644
--- a/test/unit/ldp/http/BasicResponseWriter.test.ts
+++ b/test/unit/ldp/http/BasicResponseWriter.test.ts
@@ -1,6 +1,6 @@
 import { EventEmitter } from 'events';
 import { createResponse, MockResponse } from 'node-mocks-http';
-import { Quad } from 'rdf-js';
+import type { Quad } from 'rdf-js';
 import streamifyArray from 'streamify-array';
 import { BasicResponseWriter } from '../../../../src/ldp/http/BasicResponseWriter';
 import { ResponseDescription } from '../../../../src/ldp/operations/ResponseDescription';
diff --git a/test/unit/storage/patch/SparqlUpdatePatchHandler.test.ts b/test/unit/storage/patch/SparqlUpdatePatchHandler.test.ts
index c1d8de56f..394e02a13 100644
--- a/test/unit/storage/patch/SparqlUpdatePatchHandler.test.ts
+++ b/test/unit/storage/patch/SparqlUpdatePatchHandler.test.ts
@@ -1,6 +1,6 @@
 import { namedNode, quad } from '@rdfjs/data-model';
 import arrayifyStream from 'arrayify-stream';
-import { Quad } from 'rdf-js';
+import type { Quad } from 'rdf-js';
 import { translate } from 'sparqlalgebrajs';
 import streamifyArray from 'streamify-array';
 import { SparqlUpdatePatch } from '../../../../src/ldp/http/SparqlUpdatePatch';