fix: Remove MS-Author-Via header

RELEASE_NOTES.md

@@ -65,6 +65,8 @@ The following changes are relevant for v4 custom configs that replaced certain f
   - `/storage/backend/*`
 - Generation of auxiliary link headers was updated. 
   - `/ldp/metadata-writer/writers/link-rel.json`
+- The `ConstantMetadataWriter` that adds the `MS-Author-Via` header was removed
+  - `/ldp/metadata-writer/default.json`
 - PATCHing related components were completely refactored.
   - `/storage/middleware/stores/patching.json`
 - The metadata auxiliary strategy was added to the default list of auxiliary strategies.

config/http/middleware/handlers/cors.json

@@ -25,7 +25,6 @@
         "Last-Modified",
         "Link",
         "Location",
-        "MS-Author-Via",
         "Updates-Via",
         "WAC-Allow"
       ]

config/ldp/metadata-writer/default.json

@@ -2,7 +2,6 @@
   "@context": "https://linkedsoftwaredependencies.org/bundles/npm/@solid/community-server/^5.0.0/components/context.jsonld",
   "import": [
     "css:config/ldp/metadata-writer/writers/allow-accept.json",
-    "css:config/ldp/metadata-writer/writers/constant.json",
     "css:config/ldp/metadata-writer/writers/content-type.json",
     "css:config/ldp/metadata-writer/writers/link-rel.json",
     "css:config/ldp/metadata-writer/writers/link-rel-metadata.json",
@@ -18,7 +17,6 @@
       "@type": "ParallelHandler",
       "handlers": [
         { "@id": "urn:solid-server:default:MetadataWriter_AllowAccept" },
-        { "@id": "urn:solid-server:default:MetadataWriter_Constant" },
         { "@id": "urn:solid-server:default:MetadataWriter_ContentType" },
         { "@id": "urn:solid-server:default:MetadataWriter_LinkRel" },
         { "@id": "urn:solid-server:default:MetadataWriter_LinkRelMetadata" },

config/ldp/metadata-writer/writers/constant.json

@@ -1,16 +0,0 @@
-{
-  "@context": "https://linkedsoftwaredependencies.org/bundles/npm/@solid/community-server/^5.0.0/components/context.jsonld",
-  "@graph": [
-    {
-      "comment": "Adds fixed headers to the response.",
-      "@id": "urn:solid-server:default:MetadataWriter_Constant",
-      "@type": "ConstantMetadataWriter",
-      "headers": [
-        {
-          "ConstantMetadataWriter:_headers_key": "MS-Author-Via",
-          "ConstantMetadataWriter:_headers_value": "SPARQL"
-        }
-      ]
-    }
-  ]
-}

test/integration/Middleware.test.ts

@@ -121,12 +121,6 @@ describe('An http server with middleware', (): void => {
     expect(splitCommaSeparated(exposed)).toContain('Location');
   });
 
-  it('exposes the MS-Author-Via header via CORS.', async(): Promise<void> => {
-    const res = await request(server).get('/').expect(200);
-    const exposed = res.header['access-control-expose-headers'];
-    expect(splitCommaSeparated(exposed)).toContain('MS-Author-Via');
-  });
-
   it('exposes the WAC-Allow header via CORS.', async(): Promise<void> => {
     const res = await request(server).get('/').expect(200);
     const exposed = res.header['access-control-expose-headers'];

test/util/FetchUtil.ts

@@ -18,7 +18,6 @@ export async function getResource(url: string,
   expect(response.headers.get('link')).toContain(`<${LDP.Resource}>; rel="type"`);
   expect(response.headers.get('link')).toContain(`<${url}.acl>; rel="acl"`);
   expect(response.headers.get('accept-patch')).toBe('text/n3, application/sparql-update');
-  expect(response.headers.get('ms-author-via')).toBe('SPARQL');
 
   if (isContainer) {
     expect(response.headers.get('link')).toContain(`<${LDP.Container}>; rel="type"`);