mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00
feat: Remove meta parameter from logging.
This commit is contained in:
committed by
Joachim Van Herwegen
parent
ce5a98b16f
commit
2c6167e0cb
@@ -28,8 +28,9 @@ export class SparqlUpdateBodyParser extends BodyParser {
|
||||
try {
|
||||
algebra = translate(sparql, { quads: true, baseIRI: metadata.identifier.value }) as Algebra.Update;
|
||||
} catch (error: unknown) {
|
||||
this.logger.warn('Could not translate SPARQL query to SPARQL algebra', { error });
|
||||
throw new BadRequestHttpError(createErrorMessage(error), { cause: error });
|
||||
const message = createErrorMessage(error);
|
||||
this.logger.warn(`Could not translate SPARQL query to SPARQL algebra: ${message}`);
|
||||
throw new BadRequestHttpError(message, { cause: error });
|
||||
}
|
||||
|
||||
// Prevent body from being requested again
|
||||
|
||||
@@ -20,10 +20,10 @@ export class LazyLogger extends Logger {
|
||||
this.label = label;
|
||||
}
|
||||
|
||||
public log(level: LogLevel, message: string, meta: any): Logger {
|
||||
public log(level: LogLevel, message: string): Logger {
|
||||
if (!this.logger) {
|
||||
this.logger = this.lazyLoggerFactory.loggerFactory.createLogger(this.label);
|
||||
}
|
||||
return this.logger.log(level, message, meta);
|
||||
return this.logger.log(level, message);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -13,15 +13,15 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public abstract log(level: LogLevel, message: string, meta?: any): Logger;
|
||||
public abstract log(level: LogLevel, message: string): Logger;
|
||||
|
||||
/**
|
||||
* Log a message at the 'error' level.
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public error(message: string, meta?: any): Logger {
|
||||
return this.log('error', message, meta);
|
||||
public error(message: string): Logger {
|
||||
return this.log('error', message);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -29,8 +29,8 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public warn(message: string, meta?: any): Logger {
|
||||
return this.log('warn', message, meta);
|
||||
public warn(message: string): Logger {
|
||||
return this.log('warn', message);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -38,8 +38,8 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public info(message: string, meta?: any): Logger {
|
||||
return this.log('info', message, meta);
|
||||
public info(message: string): Logger {
|
||||
return this.log('info', message);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -47,8 +47,8 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public verbose(message: string, meta?: any): Logger {
|
||||
return this.log('verbose', message, meta);
|
||||
public verbose(message: string): Logger {
|
||||
return this.log('verbose', message);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -56,8 +56,8 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public debug(message: string, meta?: any): Logger {
|
||||
return this.log('debug', message, meta);
|
||||
public debug(message: string): Logger {
|
||||
return this.log('debug', message);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -65,7 +65,7 @@ export abstract class Logger {
|
||||
* @param message - The message to log.
|
||||
* @param meta - Optional metadata to include in the log message.
|
||||
*/
|
||||
public silly(message: string, meta?: any): Logger {
|
||||
return this.log('silly', message, meta);
|
||||
public silly(message: string): Logger {
|
||||
return this.log('silly', message);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -118,7 +118,7 @@ export class StaticAssetHandler extends HttpHandler {
|
||||
reject(new NotFoundHttpError(`Cannot find ${request.url}`));
|
||||
// In other cases, we might already have started writing, so just hang up
|
||||
} else {
|
||||
this.logger.warn(`Error reading asset ${filePath}: ${error.message}`, { error });
|
||||
this.logger.warn(`Error reading asset ${filePath}: ${error.message}`);
|
||||
response.end();
|
||||
asset.destroy();
|
||||
resolve();
|
||||
|
||||
@@ -41,8 +41,7 @@ function guardingErrorListener(this: Guarded, error: Error): void {
|
||||
this[guardedErrors].push(error);
|
||||
if (!this[guardedTimeout]) {
|
||||
this[guardedTimeout] = setTimeout((): void => {
|
||||
const message = `No error listener was attached but error was thrown: ${error.message}`;
|
||||
logger.error(message, { error });
|
||||
logger.error(`No error listener was attached but error was thrown: ${error.message}`);
|
||||
}, 1000);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user