refactor: Bring lint config back to original strictness

This commit is contained in:
Joachim Van Herwegen
2023-10-30 14:32:21 +01:00
parent 7a007dc466
commit 3bb3004abb
52 changed files with 239 additions and 132 deletions

View File

@@ -8,7 +8,7 @@ interface CreateExtractorArgs {
}
// Helper function for instantiating an OriginalUrlExtractor
function createExtractor(args: CreateExtractorArgs = { }): OriginalUrlExtractor {
function createExtractor(args: CreateExtractorArgs = {}): OriginalUrlExtractor {
const identifierStrategy = new SingleRootIdentifierStrategy(args.baseUrl ?? 'http://test.com');
const extractor = new OriginalUrlExtractor({ identifierStrategy, includeQueryString: args.includeQueryString });
return extractor;

View File

@@ -60,7 +60,7 @@ describe('A BasicResponseWriter', (): void => {
it('serializes metadata if there is metadata.', async(): Promise<void> => {
result = { statusCode: 201, metadata: new RepresentationMetadata() };
metadataWriter.handle = jest.fn();
jest.spyOn(metadataWriter, 'handle').mockImplementation();
await writer.handle({ response, result });
expect(metadataWriter.handle).toHaveBeenCalledTimes(1);
expect(metadataWriter.handle).toHaveBeenLastCalledWith({ response, metadata: result.metadata });
@@ -77,6 +77,7 @@ describe('A BasicResponseWriter', (): void => {
result = { statusCode: 201, data };
response = new PassThrough();
// eslint-disable-next-line jest/prefer-spy-on
response.writeHead = jest.fn();
const end = new Promise<void>((resolve): void => {

View File

@@ -30,13 +30,13 @@ describe('A LinkRelMetadataWriter', (): void => {
const metadata = new RepresentationMetadata(identifier);
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('does not add link headers for blank node identifiers.', async(): Promise<void> => {
const response = createResponse() as HttpResponse;
const metadata = new RepresentationMetadata();
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
});

View File

@@ -15,7 +15,7 @@ describe('A ContentTypeMetadataWriter', (): void => {
it('adds no header if there is no relevant metadata.', async(): Promise<void> => {
const metadata = new RepresentationMetadata();
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('adds a Content-Type header with parameters if present.', async(): Promise<void> => {

View File

@@ -37,7 +37,7 @@ describe('RangeMetadataWriter', (): void => {
it('does nothing if there is no range metadata.', async(): Promise<void> => {
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('adds a content-length header if the size is known.', async(): Promise<void> => {

View File

@@ -15,7 +15,7 @@ describe('A WacAllowMetadataWriter', (): void => {
it('adds no header if there is no relevant metadata.', async(): Promise<void> => {
const metadata = new RepresentationMetadata();
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('adds a WAC-Allow header if there is relevant metadata.', async(): Promise<void> => {

View File

@@ -16,13 +16,13 @@ describe('A WwwAuthMetadataWriter', (): void => {
it('adds no header if there is no relevant metadata.', async(): Promise<void> => {
const metadata = new RepresentationMetadata();
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('adds no header if the status code is not 401.', async(): Promise<void> => {
const metadata = new RepresentationMetadata({ [HTTP.statusCodeNumber]: '403' });
await expect(writer.handle({ response, metadata })).resolves.toBeUndefined();
expect(response.getHeaders()).toEqual({ });
expect(response.getHeaders()).toEqual({});
});
it('adds a WWW-Authenticate header if the status code is 401.', async(): Promise<void> => {