feat: Add support for client_id WebIDs

This commit is contained in:
Joachim Van Herwegen
2021-07-22 17:11:54 +02:00
parent 60ebf5454a
commit 3bb7a32c0c
9 changed files with 319 additions and 268 deletions

View File

@@ -0,0 +1,146 @@
import type { Response } from 'cross-fetch';
import { fetch } from 'cross-fetch';
import { Store } from 'n3';
import type { Adapter, AdapterPayload } from 'oidc-provider';
import { BasicRepresentation } from '../../ldp/representation/BasicRepresentation';
import { getLoggerFor } from '../../logging/LogUtil';
import type { RepresentationConverter } from '../../storage/conversion/RepresentationConverter';
import { INTERNAL_QUADS } from '../../util/ContentTypes';
import { createErrorMessage } from '../../util/errors/ErrorUtil';
import type { AdapterFactory } from './AdapterFactory';
/* eslint-disable @typescript-eslint/naming-convention */
/**
* This {@link Adapter} redirects the `find` call to its source adapter.
* In case no client data was found in the source for the given WebId,
* this class will do an HTTP GET request to that WebId.
* If a valid `solid:oidcRegistration` triple is found there,
* that data will be returned instead.
*/
export class WebIdAdapter implements Adapter {
protected readonly logger = getLoggerFor(this);
private readonly name: string;
private readonly source: Adapter;
private readonly converter: RepresentationConverter;
public constructor(name: string, source: Adapter, converter: RepresentationConverter) {
this.name = name;
this.source = source;
this.converter = converter;
}
public async upsert(id: string, payload: AdapterPayload, expiresIn: number): Promise<void> {
return this.source.upsert(id, payload, expiresIn);
}
public async find(id: string): Promise<AdapterPayload | void> {
let payload = await this.source.find(id);
// No payload is stored for the given Client ID.
// Try to see if valid client metadata is found at the given Client ID.
// The oidc-provider library will check if the redirect_uri matches an entry in the list of redirect_uris,
// so no extra checks are needed from our side.
if (!payload && this.name === 'Client' && /^https?:\/\/.+/u.test(id)) {
this.logger.debug(`Looking for payload data at ${id}`);
// All checks based on https://solid.github.io/authentication-panel/solid-oidc/#clientids-webid
if (!/^https:|^http:\/\/localhost(?::\d+)?(?:\/|$)/u.test(id)) {
throw new Error(`SSL is required for client_id authentication unless working locally.`);
}
const response = await fetch(id);
if (response.status !== 200) {
throw new Error(`Unable to access data at ${id}: ${await response.text()}`);
}
const data = await response.text();
let json: any | undefined;
try {
json = JSON.parse(data);
// We can only parse as simple JSON if the @context is correct
if (json['@context'] !== 'https://www.w3.org/ns/solid/oidc-context.jsonld') {
throw new Error('Invalid context');
}
} catch (error: unknown) {
json = undefined;
this.logger.debug(`Found unexpected client WebID for ${id}: ${createErrorMessage(error)}`);
}
if (json) {
// Need to make sure the document is about the id
if (json.client_id !== id) {
throw new Error('The client registration `client_id` field must match the client WebID');
}
payload = json;
} else {
// Since the WebID does not match the default JSON-LD we try to interpret it as RDF
payload = await this.parseRdfWebId(data, id, response);
}
// `token_endpoint_auth_method: 'none'` prevents oidc-provider from requiring a client_secret
payload = { ...payload, token_endpoint_auth_method: 'none' };
}
// Will also be returned if no valid client data was found above
return payload;
}
private async parseRdfWebId(data: string, id: string, response: Response): Promise<AdapterPayload> {
const contentType = response.headers.get('content-type');
if (!contentType) {
throw new Error(`No content-type received for client WebID ${id}`);
}
// Try to convert to quads
const representation = new BasicRepresentation(data, contentType);
const preferences = { type: { [INTERNAL_QUADS]: 1 }};
const converted = await this.converter.handleSafe({ representation, identifier: { path: id }, preferences });
const quads = new Store();
const importer = quads.import(converted.data);
await new Promise((resolve, reject): void => {
importer.on('end', resolve);
importer.on('error', reject);
});
// Find the valid redirect uris
const match = quads.getObjects(id, 'http://www.w3.org/ns/solid/oidc#redirect_uris', null);
return {
client_id: id,
redirect_uris: match.map((node): string => node.value),
};
}
public async findByUserCode(userCode: string): Promise<AdapterPayload | void> {
return this.source.findByUserCode(userCode);
}
public async findByUid(uid: string): Promise<AdapterPayload | void> {
return this.source.findByUid(uid);
}
public async destroy(id: string): Promise<void> {
return this.source.destroy(id);
}
public async revokeByGrantId(grantId: string): Promise<void> {
return this.source.revokeByGrantId(grantId);
}
public async consume(id: string): Promise<void> {
return this.source.consume(id);
}
}
export class WebIdAdapterFactory implements AdapterFactory {
private readonly source: AdapterFactory;
private readonly converter: RepresentationConverter;
public constructor(source: AdapterFactory, converter: RepresentationConverter) {
this.source = source;
this.converter = converter;
}
public createStorageAdapter(name: string): Adapter {
return new WebIdAdapter(name, this.source.createStorageAdapter(name), this.converter);
}
}

View File

@@ -1,121 +0,0 @@
import { DataFactory } from 'n3';
import type { Adapter, AdapterPayload } from 'oidc-provider';
import type { Dataset, Quad } from 'rdf-js';
import { getLoggerFor } from '../../logging/LogUtil';
import { fetchDataset } from '../../util/FetchUtil';
import { SOLID } from '../../util/Vocabularies';
import type { AdapterFactory } from './AdapterFactory';
import namedNode = DataFactory.namedNode;
/**
* This {@link Adapter} redirects the `find` call to its source adapter.
* In case no client data was found in the source for the given WebId,
* this class will do an HTTP GET request to that WebId.
* If a valid `solid:oidcRegistration` triple is found there,
* that data will be returned instead.
*/
export class WrappedFetchAdapter implements Adapter {
protected readonly logger = getLoggerFor(this);
private readonly source: Adapter;
private readonly name: string;
public constructor(name: string, source: Adapter) {
this.source = source;
this.name = name;
}
public async upsert(id: string, payload: AdapterPayload, expiresIn: number): Promise<void> {
return this.source.upsert(id, payload, expiresIn);
}
public async find(id: string): Promise<AdapterPayload | void> {
const payload = await this.source.find(id);
// No payload is stored for the given WebId.
// Try to see if a solid:oidcRegistration triple is stored at the WebId that can be used instead.
if (!payload && this.name === 'Client') {
this.logger.debug(`Looking for payload data at ${id}`);
let dataset: Dataset;
try {
dataset = await fetchDataset(id);
} catch {
this.logger.debug(`Looking for payload data failed at ${id}`);
return payload;
}
// Get the OIDC Registration JSON
const rawRegistrationJsonQuads = dataset.match(namedNode(id), SOLID.terms.oidcRegistration);
// Check all the registrations to see if any are valid.
for (const rawRegistrationJsonQuad of rawRegistrationJsonQuads) {
try {
return this.validateRegistrationQuad(rawRegistrationJsonQuad, id);
} catch {
// Keep looking for a valid quad
}
}
this.logger.debug(`No payload data was found at ${id}`);
}
// Will also be returned if no valid registration data was found above
return payload;
}
public async findByUserCode(userCode: string): Promise<AdapterPayload | void> {
return this.source.findByUserCode(userCode);
}
public async findByUid(uid: string): Promise<AdapterPayload | void> {
return this.source.findByUid(uid);
}
public async destroy(id: string): Promise<void> {
return this.source.destroy(id);
}
public async revokeByGrantId(grantId: string): Promise<void> {
return this.source.revokeByGrantId(grantId);
}
public async consume(id: string): Promise<void> {
return this.source.consume(id);
}
/**
* Validates if the quad object contains valid JSON with the required client_id.
* In case of success, the AdapterPayload will be returned, otherwise an error will be thrown.
*/
private validateRegistrationQuad(quad: Quad, id: string): AdapterPayload {
const rawRegistrationJson = quad.object.value;
let registrationJson;
try {
registrationJson = JSON.parse(rawRegistrationJson);
} catch {
throw new Error('Could not parse registration JSON');
}
// Ensure the registration JSON matches the client WebId
if (id !== registrationJson.client_id) {
throw new Error('The client registration `client_id` field must match the Client WebId');
}
return {
...registrationJson,
// Snake case is required for tokens
// eslint-disable-next-line @typescript-eslint/naming-convention
token_endpoint_auth_method: 'none',
};
}
}
export class WrappedFetchAdapterFactory implements AdapterFactory {
private readonly source: AdapterFactory;
public constructor(source: AdapterFactory) {
this.source = source;
}
public createStorageAdapter(name: string): Adapter {
return new WrappedFetchAdapter(name, this.source.createStorageAdapter(name));
}
}

View File

@@ -54,7 +54,7 @@ export * from './identity/ownership/TokenOwnershipValidator';
// Identity/Storage
export * from './identity/storage/AdapterFactory';
export * from './identity/storage/ExpiringAdapterFactory';
export * from './identity/storage/WrappedFetchAdapterFactory';
export * from './identity/storage/WebIdAdapterFactory';
// Identity
export * from './identity/IdentityProviderHttpHandler';