Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Extend OIDC error descriptions

Browse Source
This commit is contained in:
Joachim Van Herwegen
2022-05-11 16:07:13 +02:00
parent df0825936a
commit 3f817b14b0
4 changed files with 60 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/identity/configuration/IdentityProviderFactory.test.ts
View File

@@ -1,5 +1,5 @@
import { Readable } from 'stream';
import type { Configuration, KoaContextWithOIDC } from 'oidc-provider';
import type { errors, Configuration, KoaContextWithOIDC } from 'oidc-provider';
import type { ErrorHandler } from '../../../../src/http/output/error/ErrorHandler';
import type { ResponseWriter } from '../../../../src/http/output/ResponseWriter';
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
@@ -92,6 +92,7 @@ describe('An IdentityProviderFactory', (): void => {
interactionHandler,
storage,
credentialStorage,
showStackTrace: true,
errorHandler,
responseWriter,
});
@@ -175,6 +176,7 @@ describe('An IdentityProviderFactory', (): void => {
interactionHandler,
storage,
credentialStorage,
showStackTrace: true,
errorHandler,
responseWriter,
});
@@ -198,6 +200,7 @@ describe('An IdentityProviderFactory', (): void => {
interactionHandler,
storage,
credentialStorage,
showStackTrace: true,
errorHandler,
responseWriter,
});
@@ -214,16 +217,17 @@ describe('An IdentityProviderFactory', (): void => {
const provider = await factory.getProvider() as any;
const { config } = provider as { config: Configuration };
const error = new Error('bad data');
const out = { error_description: 'more info' };
const error = new Error('bad data') as errors.OIDCProviderError;
error.error_description = 'more info';
error.error_detail = 'more details';
await expect((config.renderError as any)(ctx, out, error)).resolves.toBeUndefined();
await expect((config.renderError as any)(ctx, {}, error)).resolves.toBeUndefined();
expect(errorHandler.handleSafe).toHaveBeenCalledTimes(1);
expect(errorHandler.handleSafe)
.toHaveBeenLastCalledWith({ error, request: ctx.req });
expect(responseWriter.handleSafe).toHaveBeenCalledTimes(1);
expect(responseWriter.handleSafe).toHaveBeenLastCalledWith({ response: ctx.res, result: { statusCode: 500 }});
expect(error.message).toBe('bad data - more info');
expect(error.stack).toContain('Error: bad data - more info');
expect(error.message).toBe('bad data - more info - more details');
expect(error.stack).toContain('Error: bad data - more info - more details');
});
});