Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow clients to be remembered in the SessionHttpHandler

Browse Source
This commit is contained in:
Joachim Van Herwegen
2021-08-17 15:55:03 +02:00
parent 1173f98b5d
commit 47b3a2d77f
7 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/integration/Identity.test.ts
View File

@@ -168,11 +168,10 @@ describe('A Solid server with IDP', (): void => {
it('can log in again.', async(): Promise<void> => {
const url = await state.startSession();
// For the following part it is debatable if this is correct but this might be a consequence of the authn client
const form = await state.extractFormUrl(url);
expect(form.url.endsWith('/confirm')).toBe(true);
const res = await state.fetchIdp(form.url, 'POST');
const res = await state.fetchIdp(form.url, 'POST', '', APPLICATION_X_WWW_FORM_URLENCODED);
const nextUrl = res.headers.get('location');
expect(typeof nextUrl).toBe('string');

10
test/unit/identity/interaction/SessionHttpHandler.test.ts
View File

@@ -1,10 +1,9 @@
import type { Interaction } from '../../../../src/identity/interaction/email-password/handler/InteractionHandler';
import { SessionHttpHandler } from '../../../../src/identity/interaction/SessionHttpHandler';
import type { HttpRequest } from '../../../../src/server/HttpRequest';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
import { createPostFormRequest } from './email-password/handler/Util';
describe('A SessionHttpHandler', (): void => {
const request: HttpRequest = {} as any;
const webId = 'http://test.com/id#me';
let oidcInteraction: Interaction;
let handler: SessionHttpHandler;
@@ -17,14 +16,15 @@ describe('A SessionHttpHandler', (): void => {
it('requires a defined oidcInteraction with a session.', async(): Promise<void> => {
oidcInteraction!.session = undefined;
await expect(handler.handle({ request, oidcInteraction })).rejects.toThrow(NotImplementedHttpError);
await expect(handler.handle({ request: {} as any, oidcInteraction })).rejects.toThrow(NotImplementedHttpError);
await expect(handler.handle({ request })).rejects.toThrow(NotImplementedHttpError);
await expect(handler.handle({ request: {} as any })).rejects.toThrow(NotImplementedHttpError);
});
it('returns an InteractionCompleteResult when done.', async(): Promise<void> => {
const request = createPostFormRequest({ remember: true });
await expect(handler.handle({ request, oidcInteraction })).resolves.toEqual({
details: { webId },
details: { webId, shouldRemember: true },
type: 'complete',
});
});