From 4ac9e92d06708d06dff47dc6b371d50e57363cce Mon Sep 17 00:00:00 2001
From: Joachim Van Herwegen <joachimvh@gmail.com>
Date: Wed, 22 Jul 2020 14:31:57 +0200
Subject: [PATCH] fix: Remove all instances of `return undefined`

Resolves #26
---
 src/authentication/SimpleCredentialsExtractor.ts  | 3 +--
 src/authorization/SimpleAuthorizer.ts             | 2 +-
 src/ldp/http/AcceptPreferenceParser.ts            | 2 +-
 src/ldp/http/SimpleBodyParser.ts                  | 2 +-
 src/ldp/permissions/SimplePermissionsExtractor.ts | 2 +-
 test/unit/server/ExpressHttpServer.test.ts        | 2 +-
 6 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/authentication/SimpleCredentialsExtractor.ts b/src/authentication/SimpleCredentialsExtractor.ts
index 0047a8ff8..95379ee47 100644
--- a/src/authentication/SimpleCredentialsExtractor.ts
+++ b/src/authentication/SimpleCredentialsExtractor.ts
@@ -7,13 +7,12 @@ import { HttpRequest } from '../server/HttpRequest';
  */
 export class SimpleCredentialsExtractor extends CredentialsExtractor {
   public async canHandle(): Promise<void> {
-    return undefined;
+    // Supports all requests
   }
 
   public async handle(input: HttpRequest): Promise<Credentials> {
     if (input.headers.authorization) {
       return { webID: input.headers.authorization };
     }
-    return undefined;
   }
 }
diff --git a/src/authorization/SimpleAuthorizer.ts b/src/authorization/SimpleAuthorizer.ts
index b872d1644..6ca25b1ab 100644
--- a/src/authorization/SimpleAuthorizer.ts
+++ b/src/authorization/SimpleAuthorizer.ts
@@ -12,6 +12,6 @@ export class SimpleAuthorizer extends Authorizer {
   }
 
   public async handle(): Promise<void> {
-    return undefined;
+    // Allows all actions
   }
 }
diff --git a/src/ldp/http/AcceptPreferenceParser.ts b/src/ldp/http/AcceptPreferenceParser.ts
index 9d1f9ef0c..2f61a20c3 100644
--- a/src/ldp/http/AcceptPreferenceParser.ts
+++ b/src/ldp/http/AcceptPreferenceParser.ts
@@ -20,7 +20,7 @@ export class AcceptPreferenceParser extends PreferenceParser {
   }
 
   public async canHandle(): Promise<void> {
-    return undefined;
+    // Supports all HttpRequests
   }
 
   public async handle(input: HttpRequest): Promise<RepresentationPreferences> {
diff --git a/src/ldp/http/SimpleBodyParser.ts b/src/ldp/http/SimpleBodyParser.ts
index f0eddce2e..dd4dd661f 100644
--- a/src/ldp/http/SimpleBodyParser.ts
+++ b/src/ldp/http/SimpleBodyParser.ts
@@ -32,7 +32,7 @@ export class SimpleBodyParser extends BodyParser {
     const contentType = input.headers['content-type'];
 
     if (!contentType) {
-      return undefined;
+      return;
     }
 
     const mediaType = contentType.split(';')[0];
diff --git a/src/ldp/permissions/SimplePermissionsExtractor.ts b/src/ldp/permissions/SimplePermissionsExtractor.ts
index facaaab37..b6c24c210 100644
--- a/src/ldp/permissions/SimplePermissionsExtractor.ts
+++ b/src/ldp/permissions/SimplePermissionsExtractor.ts
@@ -7,7 +7,7 @@ import { PermissionsExtractor } from './PermissionsExtractor';
  */
 export class SimplePermissionsExtractor extends PermissionsExtractor {
   public async canHandle(): Promise<void> {
-    return undefined;
+    // Supports all operations
   }
 
   public async handle(input: Operation): Promise<PermissionSet> {
diff --git a/test/unit/server/ExpressHttpServer.test.ts b/test/unit/server/ExpressHttpServer.test.ts
index 183c0d113..1c8cdcdef 100644
--- a/test/unit/server/ExpressHttpServer.test.ts
+++ b/test/unit/server/ExpressHttpServer.test.ts
@@ -12,7 +12,7 @@ const handle = async(input: { request: HttpRequest; response: HttpResponse }): P
 
 class SimpleHttpHandler extends HttpHandler {
   public async canHandle(): Promise<void> {
-    return undefined;
+    // Supports all HttpRequests
   }
 
   public async handle(input: { request: HttpRequest; response: HttpResponse }): Promise<void> {