fix: Various minor fixes

This commit is contained in:
Joachim Van Herwegen 2021-05-28 16:40:41 +02:00
parent 130a91fdfb
commit 68f2446e27
11 changed files with 8 additions and 21 deletions

View File

@ -12,7 +12,7 @@
}, },
{ {
"StaticAssetHandler:_assets_key": "/idp/style.css", "StaticAssetHandler:_assets_key": "/idp/style.css",
"StaticAssetHandler:_assets_value": "$PACKAGE_ROOT/templates/views/email-password-interaction/main.css" "StaticAssetHandler:_assets_value": "$PACKAGE_ROOT/templates/idp/email-password-interaction/main.css"
} }
] ]
} }

View File

@ -9,9 +9,9 @@ import { IdpInteractionError } from '../util/IdpInteractionError';
* @param error - Error to create an IdPInteractionError from. * @param error - Error to create an IdPInteractionError from.
* @param prefilled - Prefilled data for IdpInteractionError. * @param prefilled - Prefilled data for IdpInteractionError.
*/ */
export function throwIdpInteractionError(error: unknown, prefilled?: any): never { export function throwIdpInteractionError(error: unknown, prefilled: Record<string, string> = {}): never {
if (IdpInteractionError.isInstance(error)) { if (IdpInteractionError.isInstance(error)) {
if (prefilled) { if (Object.keys(prefilled).length > 0) {
throw new IdpInteractionError(error.statusCode, error.message, { ...error.prefilled, ...prefilled }); throw new IdpInteractionError(error.statusCode, error.message, { ...error.prefilled, ...prefilled });
} else { } else {
throw error; throw error;

View File

@ -45,15 +45,18 @@ export * from './identity/interaction/util/IdpRenderHandler';
export * from './identity/interaction/util/IdpRouteController'; export * from './identity/interaction/util/IdpRouteController';
export * from './identity/interaction/util/InitialInteractionHandler'; export * from './identity/interaction/util/InitialInteractionHandler';
export * from './identity/interaction/util/InteractionCompleter'; export * from './identity/interaction/util/InteractionCompleter';
export * from './identity/interaction/util/OwnershipValidator';
export * from './identity/interaction/util/TemplateRenderer'; export * from './identity/interaction/util/TemplateRenderer';
export * from './identity/interaction/util/TokenOwnershipValidator';
// Identity/Interaction // Identity/Interaction
export * from './identity/interaction/InteractionHttpHandler'; export * from './identity/interaction/InteractionHttpHandler';
export * from './identity/interaction/InteractionPolicy'; export * from './identity/interaction/InteractionPolicy';
export * from './identity/interaction/SessionHttpHandler'; export * from './identity/interaction/SessionHttpHandler';
// Identity/Ownership
export * from './identity/ownership/NoCheckOwnershipValidator';
export * from './identity/ownership/OwnershipValidator';
export * from './identity/ownership/TokenOwnershipValidator';
// Identity/Storage // Identity/Storage
export * from './identity/storage/AdapterFactory'; export * from './identity/storage/AdapterFactory';
export * from './identity/storage/ExpiringAdapterFactory'; export * from './identity/storage/ExpiringAdapterFactory';
@ -178,14 +181,11 @@ export * from './pods/generate/TemplatedResourcesGenerator';
// Pods/Settings // Pods/Settings
export * from './pods/settings/PodSettings'; export * from './pods/settings/PodSettings';
export * from './pods/settings/PodSettingsJsonParser';
export * from './pods/settings/PodSettingsParser';
// Pods // Pods
export * from './pods/ConfigPodManager'; export * from './pods/ConfigPodManager';
export * from './pods/GeneratedPodManager'; export * from './pods/GeneratedPodManager';
export * from './pods/PodManager'; export * from './pods/PodManager';
export * from './pods/PodManagerHttpHandler';
// Server // Server
export * from './server/BaseHttpServerFactory'; export * from './server/BaseHttpServerFactory';

View File

@ -39,7 +39,6 @@ describe.each(stores)('An LDP handler with auth using %s', (name, { storeConfig,
beforeAll(async(): Promise<void> => { beforeAll(async(): Promise<void> => {
const variables: Record<string, any> = { const variables: Record<string, any> = {
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': baseUrl, 'urn:solid-server:default:variable:baseUrl': baseUrl,
'urn:solid-server:default:variable:rootFilePath': rootFilePath, 'urn:solid-server:default:variable:rootFilePath': rootFilePath,
}; };

View File

@ -33,7 +33,6 @@ describe.each(stores)('An LDP handler allowing all requests %s', (name, { storeC
beforeAll(async(): Promise<void> => { beforeAll(async(): Promise<void> => {
const variables: Record<string, any> = { const variables: Record<string, any> = {
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': baseUrl, 'urn:solid-server:default:variable:baseUrl': baseUrl,
'urn:solid-server:default:variable:rootFilePath': rootFilePath, 'urn:solid-server:default:variable:rootFilePath': rootFilePath,
}; };

View File

@ -24,7 +24,6 @@ describe('An http server with middleware', (): void => {
getTestConfigPath('server-middleware.json'), getTestConfigPath('server-middleware.json'),
{ {
'urn:solid-server:default:LdpHandler': new SimpleHttpHandler(), 'urn:solid-server:default:LdpHandler': new SimpleHttpHandler(),
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': 'https://example.pod/', 'urn:solid-server:default:variable:baseUrl': 'https://example.pod/',
}, },
) as BaseHttpServerFactory; ) as BaseHttpServerFactory;

View File

@ -1,7 +1,6 @@
import type { Server } from 'http'; import type { Server } from 'http';
import fetch from 'cross-fetch'; import fetch from 'cross-fetch';
import type { RedisResourceLocker } from '../../src'; import type { RedisResourceLocker } from '../../src';
import { joinFilePath } from '../../src';
import type { HttpServerFactory } from '../../src/server/HttpServerFactory'; import type { HttpServerFactory } from '../../src/server/HttpServerFactory';
import { describeIf, getPort } from '../util/Util'; import { describeIf, getPort } from '../util/Util';
import { getTestConfigPath, instantiateFromConfig } from './Config'; import { getTestConfigPath, instantiateFromConfig } from './Config';
@ -22,7 +21,6 @@ describeIf('docker', 'A server with a RedisResourceLocker as ResourceLocker', ()
getTestConfigPath('run-with-redlock.json'), getTestConfigPath('run-with-redlock.json'),
{ {
'urn:solid-server:default:variable:baseUrl': baseUrl, 'urn:solid-server:default:variable:baseUrl': baseUrl,
'urn:solid-server:default:variable:podTemplateFolder': joinFilePath(__dirname, '../assets/templates'),
}, },
) as Record<string, any>; ) as Record<string, any>;
({ factory, locker } = instances); ({ factory, locker } = instances);

View File

@ -21,7 +21,6 @@ describe('A Solid server', (): void => {
'urn:solid-server:test:Instances', 'urn:solid-server:test:Instances',
getTestConfigPath('server-memory.json'), getTestConfigPath('server-memory.json'),
{ {
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': baseUrl, 'urn:solid-server:default:variable:baseUrl': baseUrl,
'urn:solid-server:default:variable:idpTemplateFolder': '', 'urn:solid-server:default:variable:idpTemplateFolder': '',
}, },

View File

@ -17,7 +17,6 @@ describeIf('docker', 'A server with a SPARQL endpoint as storage', (): void => {
beforeAll(async(): Promise<void> => { beforeAll(async(): Promise<void> => {
const variables: Record<string, any> = { const variables: Record<string, any> = {
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': baseUrl, 'urn:solid-server:default:variable:baseUrl': baseUrl,
'urn:solid-server:default:variable:sparqlEndpoint': 'http://localhost:4000/sparql', 'urn:solid-server:default:variable:sparqlEndpoint': 'http://localhost:4000/sparql',
}; };

View File

@ -17,7 +17,6 @@ describe('A server with the Solid WebSockets API behind a proxy', (): void => {
'urn:solid-server:default:ServerFactory', 'urn:solid-server:default:ServerFactory',
getTestConfigPath('server-without-auth.json'), getTestConfigPath('server-without-auth.json'),
{ {
'urn:solid-server:default:variable:port': port,
'urn:solid-server:default:variable:baseUrl': 'https://example.pod/', 'urn:solid-server:default:variable:baseUrl': 'https://example.pod/',
}, },
) as HttpServerFactory; ) as HttpServerFactory;

View File

@ -43,11 +43,6 @@
{ {
"@id": "urn:solid-server:default:IdentityProviderHandler", "@id": "urn:solid-server:default:IdentityProviderHandler",
"@type": "UnsupportedAsyncHandler" "@type": "UnsupportedAsyncHandler"
},
{
"@id": "urn:solid-server:default:ResourcesGenerator",
"TemplatedResourcesGenerator:_templateFolder": "$PACKAGE_ROOT/test/assets/templates"
} }
] ]
} }