Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Update ModesExtractors to support new permission interface

Browse Source
This commit is contained in:
Joachim Van Herwegen
2022-06-29 10:56:17 +02:00
parent 23f0b37c28
commit 7085252b3f
8 changed files with 147 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
test/unit/authorization/permissions/MethodModesExtractor.test.ts
View File

@@ -1,13 +1,31 @@
import { MethodModesExtractor } from '../../../../src/authorization/permissions/MethodModesExtractor';
import type { AccessMap } from '../../../../src/authorization/permissions/Permissions';
import { AccessMode } from '../../../../src/authorization/permissions/Permissions';
import type { Operation } from '../../../../src/http/Operation';
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
import type { ResourceSet } from '../../../../src/storage/ResourceSet';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../../../src/util/map/IdentifierMap';
import { compareMaps } from '../../../util/Util';
describe('A MethodModesExtractor', (): void => {
const target: ResourceIdentifier = { path: 'http://example.com/foo' };
const operation: Operation = {
method: 'GET',
target,
preferences: {},
body: new BasicRepresentation(),
};
let resourceSet: jest.Mocked<ResourceSet>;
let extractor: MethodModesExtractor;
function getMap(modes: AccessMode[], identifier?: ResourceIdentifier): AccessMap {
return new IdentifierSetMultiMap(
modes.map((mode): [ResourceIdentifier, AccessMode] => [ identifier ?? target, mode ]),
);
}
beforeEach(async(): Promise<void> => {
resourceSet = {
hasResource: jest.fn().mockResolvedValue(true),
@@ -16,44 +34,43 @@ describe('A MethodModesExtractor', (): void => {
});
it('can handle HEAD/GET/POST/PUT/DELETE.', async(): Promise<void> => {
await expect(extractor.canHandle({ method: 'HEAD' } as Operation)).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'GET' } as Operation)).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'POST' } as Operation)).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'PUT' } as Operation)).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'DELETE' } as Operation)).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'PATCH' } as Operation)).rejects.toThrow(NotImplementedHttpError);
await expect(extractor.canHandle({ ...operation, method: 'HEAD' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ ...operation, method: 'GET' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ ...operation, method: 'POST' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ ...operation, method: 'PUT' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ ...operation, method: 'DELETE' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ ...operation, method: 'PATCH' })).rejects.toThrow(NotImplementedHttpError);
});
it('requires read for HEAD operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'HEAD' } as Operation)).resolves.toEqual(new Set([ AccessMode.read ]));
compareMaps(await extractor.handle({ ...operation, method: 'HEAD' }), getMap([ AccessMode.read ]));
});
it('requires read for GET operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'GET' } as Operation)).resolves.toEqual(new Set([ AccessMode.read ]));
compareMaps(await extractor.handle({ ...operation, method: 'GET' }), getMap([ AccessMode.read ]));
});
it('requires append for POST operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'POST' } as Operation)).resolves.toEqual(new Set([ AccessMode.append ]));
compareMaps(await extractor.handle({ ...operation, method: 'POST' }), getMap([ AccessMode.append ]));
});
it('requires write for PUT operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'PUT' } as Operation))
.resolves.toEqual(new Set([ AccessMode.write ]));
compareMaps(await extractor.handle({ ...operation, method: 'PUT' }), getMap([ AccessMode.write ]));
});
it('requires create for PUT operations if the target does not exist.', async(): Promise<void> => {
resourceSet.hasResource.mockResolvedValueOnce(false);
await expect(extractor.handle({ method: 'PUT' } as Operation))
.resolves.toEqual(new Set([ AccessMode.write, AccessMode.create ]));
compareMaps(await extractor.handle({ ...operation, method: 'PUT' }),
getMap([ AccessMode.write, AccessMode.create ]));
});
it('requires delete for DELETE operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'DELETE', target: { path: 'http://example.com/foo' }} as Operation))
.resolves.toEqual(new Set([ AccessMode.delete ]));
compareMaps(await extractor.handle({ ...operation, method: 'DELETE' }), getMap([ AccessMode.delete ]));
});
it('also requires read for DELETE operations on containers.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'DELETE', target: { path: 'http://example.com/foo/' }} as Operation))
.resolves.toEqual(new Set([ AccessMode.delete, AccessMode.read ]));
const identifier = { path: 'http://example.com/foo/' };
compareMaps(await extractor.handle({ ...operation, method: 'DELETE', target: identifier }),
getMap([ AccessMode.delete, AccessMode.read ], identifier));
});
});