feat: Update ModesExtractors to support new permission interface

This commit is contained in:
Joachim Van Herwegen 2022-06-29 10:56:17 +02:00
parent 23f0b37c28
commit 7085252b3f
8 changed files with 147 additions and 94 deletions

View File

@ -1,8 +1,10 @@
import type { Operation } from '../../http/Operation'; import type { Operation } from '../../http/Operation';
import type { ResourceSet } from '../../storage/ResourceSet'; import type { ResourceSet } from '../../storage/ResourceSet';
import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../util/map/IdentifierMap';
import { isContainerIdentifier } from '../../util/PathUtil'; import { isContainerIdentifier } from '../../util/PathUtil';
import { ModesExtractor } from './ModesExtractor'; import { ModesExtractor } from './ModesExtractor';
import type { AccessMap } from './Permissions';
import { AccessMode } from './Permissions'; import { AccessMode } from './Permissions';
const READ_METHODS = new Set([ 'OPTIONS', 'GET', 'HEAD' ]); const READ_METHODS = new Set([ 'OPTIONS', 'GET', 'HEAD' ]);
@ -31,33 +33,33 @@ export class MethodModesExtractor extends ModesExtractor {
} }
} }
public async handle({ method, target }: Operation): Promise<Set<AccessMode>> { public async handle({ method, target }: Operation): Promise<AccessMap> {
const modes = new Set<AccessMode>(); const requiredModes: AccessMap = new IdentifierSetMultiMap();
// Reading requires Read permissions on the resource // Reading requires Read permissions on the resource
if (READ_METHODS.has(method)) { if (READ_METHODS.has(method)) {
modes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
} }
// Setting a resource's representation requires Write permissions // Setting a resource's representation requires Write permissions
if (method === 'PUT') { if (method === 'PUT') {
modes.add(AccessMode.write); requiredModes.add(target, AccessMode.write);
// …and, if the resource does not exist yet, Create permissions are required as well // …and, if the resource does not exist yet, Create permissions are required as well
if (!await this.resourceSet.hasResource(target)) { if (!await this.resourceSet.hasResource(target)) {
modes.add(AccessMode.create); requiredModes.add(target, AccessMode.create);
} }
} }
// Creating a new resource in a container requires Append access to that container // Creating a new resource in a container requires Append access to that container
if (method === 'POST') { if (method === 'POST') {
modes.add(AccessMode.append); requiredModes.add(target, AccessMode.append);
} }
// Deleting a resource requires Delete access // Deleting a resource requires Delete access
if (method === 'DELETE') { if (method === 'DELETE') {
modes.add(AccessMode.delete); requiredModes.add(target, AccessMode.delete);
// …and, if the target is a container, Read permissions are required as well // …and, if the target is a container, Read permissions are required as well
// as this exposes if a container is empty or not // as this exposes if a container is empty or not
if (isContainerIdentifier(target)) { if (isContainerIdentifier(target)) {
modes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
} }
} }
return modes; return requiredModes;
} }
} }

View File

@ -3,7 +3,9 @@ import type { N3Patch } from '../../http/representation/N3Patch';
import { isN3Patch } from '../../http/representation/N3Patch'; import { isN3Patch } from '../../http/representation/N3Patch';
import type { ResourceSet } from '../../storage/ResourceSet'; import type { ResourceSet } from '../../storage/ResourceSet';
import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../util/map/IdentifierMap';
import { ModesExtractor } from './ModesExtractor'; import { ModesExtractor } from './ModesExtractor';
import type { AccessMap } from './Permissions';
import { AccessMode } from './Permissions'; import { AccessMode } from './Permissions';
/** /**
@ -33,28 +35,28 @@ export class N3PatchModesExtractor extends ModesExtractor {
} }
} }
public async handle({ body, target }: Operation): Promise<Set<AccessMode>> { public async handle({ body, target }: Operation): Promise<AccessMap> {
const { deletes, inserts, conditions } = body as N3Patch; const { deletes, inserts, conditions } = body as N3Patch;
const accessModes = new Set<AccessMode>(); const requiredModes: AccessMap = new IdentifierSetMultiMap();
// When ?conditions is non-empty, servers MUST treat the request as a Read operation. // When ?conditions is non-empty, servers MUST treat the request as a Read operation.
if (conditions.length > 0) { if (conditions.length > 0) {
accessModes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
} }
// When ?insertions is non-empty, servers MUST (also) treat the request as an Append operation. // When ?insertions is non-empty, servers MUST (also) treat the request as an Append operation.
if (inserts.length > 0) { if (inserts.length > 0) {
accessModes.add(AccessMode.append); requiredModes.add(target, AccessMode.append);
if (!await this.resourceSet.hasResource(target)) { if (!await this.resourceSet.hasResource(target)) {
accessModes.add(AccessMode.create); requiredModes.add(target, AccessMode.create);
} }
} }
// When ?deletions is non-empty, servers MUST treat the request as a Read and Write operation. // When ?deletions is non-empty, servers MUST treat the request as a Read and Write operation.
if (deletes.length > 0) { if (deletes.length > 0) {
accessModes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
accessModes.add(AccessMode.write); requiredModes.add(target, AccessMode.write);
} }
return accessModes; return requiredModes;
} }
} }

View File

@ -4,7 +4,9 @@ import type { Representation } from '../../http/representation/Representation';
import type { SparqlUpdatePatch } from '../../http/representation/SparqlUpdatePatch'; import type { SparqlUpdatePatch } from '../../http/representation/SparqlUpdatePatch';
import type { ResourceSet } from '../../storage/ResourceSet'; import type { ResourceSet } from '../../storage/ResourceSet';
import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../util/map/IdentifierMap';
import { ModesExtractor } from './ModesExtractor'; import { ModesExtractor } from './ModesExtractor';
import type { AccessMap } from './Permissions';
import { AccessMode } from './Permissions'; import { AccessMode } from './Permissions';
/** /**
@ -34,31 +36,31 @@ export class SparqlUpdateModesExtractor extends ModesExtractor {
} }
} }
public async handle({ body, target }: Operation): Promise<Set<AccessMode>> { public async handle({ body, target }: Operation): Promise<AccessMap> {
// Verified in `canHandle` call // Verified in `canHandle` call
const update = (body as SparqlUpdatePatch).algebra as Algebra.DeleteInsert; const update = (body as SparqlUpdatePatch).algebra as Algebra.DeleteInsert;
const modes = new Set<AccessMode>(); const requiredModes: AccessMap = new IdentifierSetMultiMap();
if (this.isNop(update)) { if (this.isNop(update)) {
return modes; return requiredModes;
} }
// Access modes inspired by the requirements on N3 Patch requests // Access modes inspired by the requirements on N3 Patch requests
if (this.hasConditions(update)) { if (this.hasConditions(update)) {
modes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
} }
if (this.hasInserts(update)) { if (this.hasInserts(update)) {
modes.add(AccessMode.append); requiredModes.add(target, AccessMode.append);
if (!await this.resourceSet.hasResource(target)) { if (!await this.resourceSet.hasResource(target)) {
modes.add(AccessMode.create); requiredModes.add(target, AccessMode.create);
} }
} }
if (this.hasDeletes(update)) { if (this.hasDeletes(update)) {
modes.add(AccessMode.read); requiredModes.add(target, AccessMode.read);
modes.add(AccessMode.write); requiredModes.add(target, AccessMode.write);
} }
return modes; return requiredModes;
} }
private isSparql(data: Representation): data is SparqlUpdatePatch { private isSparql(data: Representation): data is SparqlUpdatePatch {

View File

@ -15,10 +15,11 @@ export * from './authorization/access/AgentClassAccessChecker';
export * from './authorization/access/AgentGroupAccessChecker'; export * from './authorization/access/AgentGroupAccessChecker';
// Authorization/Permissions // Authorization/Permissions
export * from './authorization/permissions/Permissions'; export * from './authorization/permissions/AclPermission';
export * from './authorization/permissions/ModesExtractor'; export * from './authorization/permissions/ModesExtractor';
export * from './authorization/permissions/MethodModesExtractor'; export * from './authorization/permissions/MethodModesExtractor';
export * from './authorization/permissions/N3PatchModesExtractor'; export * from './authorization/permissions/N3PatchModesExtractor';
export * from './authorization/permissions/Permissions';
export * from './authorization/permissions/SparqlUpdateModesExtractor'; export * from './authorization/permissions/SparqlUpdateModesExtractor';
// Authorization // Authorization

View File

@ -1,13 +1,31 @@
import { MethodModesExtractor } from '../../../../src/authorization/permissions/MethodModesExtractor'; import { MethodModesExtractor } from '../../../../src/authorization/permissions/MethodModesExtractor';
import type { AccessMap } from '../../../../src/authorization/permissions/Permissions';
import { AccessMode } from '../../../../src/authorization/permissions/Permissions'; import { AccessMode } from '../../../../src/authorization/permissions/Permissions';
import type { Operation } from '../../../../src/http/Operation'; import type { Operation } from '../../../../src/http/Operation';
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
import type { ResourceSet } from '../../../../src/storage/ResourceSet'; import type { ResourceSet } from '../../../../src/storage/ResourceSet';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../../../src/util/map/IdentifierMap';
import { compareMaps } from '../../../util/Util';
describe('A MethodModesExtractor', (): void => { describe('A MethodModesExtractor', (): void => {
const target: ResourceIdentifier = { path: 'http://example.com/foo' };
const operation: Operation = {
method: 'GET',
target,
preferences: {},
body: new BasicRepresentation(),
};
let resourceSet: jest.Mocked<ResourceSet>; let resourceSet: jest.Mocked<ResourceSet>;
let extractor: MethodModesExtractor; let extractor: MethodModesExtractor;
function getMap(modes: AccessMode[], identifier?: ResourceIdentifier): AccessMap {
return new IdentifierSetMultiMap(
modes.map((mode): [ResourceIdentifier, AccessMode] => [ identifier ?? target, mode ]),
);
}
beforeEach(async(): Promise<void> => { beforeEach(async(): Promise<void> => {
resourceSet = { resourceSet = {
hasResource: jest.fn().mockResolvedValue(true), hasResource: jest.fn().mockResolvedValue(true),
@ -16,44 +34,43 @@ describe('A MethodModesExtractor', (): void => {
}); });
it('can handle HEAD/GET/POST/PUT/DELETE.', async(): Promise<void> => { it('can handle HEAD/GET/POST/PUT/DELETE.', async(): Promise<void> => {
await expect(extractor.canHandle({ method: 'HEAD' } as Operation)).resolves.toBeUndefined(); await expect(extractor.canHandle({ ...operation, method: 'HEAD' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'GET' } as Operation)).resolves.toBeUndefined(); await expect(extractor.canHandle({ ...operation, method: 'GET' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'POST' } as Operation)).resolves.toBeUndefined(); await expect(extractor.canHandle({ ...operation, method: 'POST' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'PUT' } as Operation)).resolves.toBeUndefined(); await expect(extractor.canHandle({ ...operation, method: 'PUT' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'DELETE' } as Operation)).resolves.toBeUndefined(); await expect(extractor.canHandle({ ...operation, method: 'DELETE' })).resolves.toBeUndefined();
await expect(extractor.canHandle({ method: 'PATCH' } as Operation)).rejects.toThrow(NotImplementedHttpError); await expect(extractor.canHandle({ ...operation, method: 'PATCH' })).rejects.toThrow(NotImplementedHttpError);
}); });
it('requires read for HEAD operations.', async(): Promise<void> => { it('requires read for HEAD operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'HEAD' } as Operation)).resolves.toEqual(new Set([ AccessMode.read ])); compareMaps(await extractor.handle({ ...operation, method: 'HEAD' }), getMap([ AccessMode.read ]));
}); });
it('requires read for GET operations.', async(): Promise<void> => { it('requires read for GET operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'GET' } as Operation)).resolves.toEqual(new Set([ AccessMode.read ])); compareMaps(await extractor.handle({ ...operation, method: 'GET' }), getMap([ AccessMode.read ]));
}); });
it('requires append for POST operations.', async(): Promise<void> => { it('requires append for POST operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'POST' } as Operation)).resolves.toEqual(new Set([ AccessMode.append ])); compareMaps(await extractor.handle({ ...operation, method: 'POST' }), getMap([ AccessMode.append ]));
}); });
it('requires write for PUT operations.', async(): Promise<void> => { it('requires write for PUT operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'PUT' } as Operation)) compareMaps(await extractor.handle({ ...operation, method: 'PUT' }), getMap([ AccessMode.write ]));
.resolves.toEqual(new Set([ AccessMode.write ]));
}); });
it('requires create for PUT operations if the target does not exist.', async(): Promise<void> => { it('requires create for PUT operations if the target does not exist.', async(): Promise<void> => {
resourceSet.hasResource.mockResolvedValueOnce(false); resourceSet.hasResource.mockResolvedValueOnce(false);
await expect(extractor.handle({ method: 'PUT' } as Operation)) compareMaps(await extractor.handle({ ...operation, method: 'PUT' }),
.resolves.toEqual(new Set([ AccessMode.write, AccessMode.create ])); getMap([ AccessMode.write, AccessMode.create ]));
}); });
it('requires delete for DELETE operations.', async(): Promise<void> => { it('requires delete for DELETE operations.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'DELETE', target: { path: 'http://example.com/foo' }} as Operation)) compareMaps(await extractor.handle({ ...operation, method: 'DELETE' }), getMap([ AccessMode.delete ]));
.resolves.toEqual(new Set([ AccessMode.delete ]));
}); });
it('also requires read for DELETE operations on containers.', async(): Promise<void> => { it('also requires read for DELETE operations on containers.', async(): Promise<void> => {
await expect(extractor.handle({ method: 'DELETE', target: { path: 'http://example.com/foo/' }} as Operation)) const identifier = { path: 'http://example.com/foo/' };
.resolves.toEqual(new Set([ AccessMode.delete, AccessMode.read ])); compareMaps(await extractor.handle({ ...operation, method: 'DELETE', target: identifier }),
getMap([ AccessMode.delete, AccessMode.read ], identifier));
}); });
}); });

View File

@ -1,22 +1,33 @@
import { DataFactory } from 'n3'; import { DataFactory } from 'n3';
import type { Quad } from 'rdf-js'; import type { Quad } from 'rdf-js';
import { N3PatchModesExtractor } from '../../../../src/authorization/permissions/N3PatchModesExtractor'; import { N3PatchModesExtractor } from '../../../../src/authorization/permissions/N3PatchModesExtractor';
import type { AccessMap } from '../../../../src/authorization/permissions/Permissions';
import { AccessMode } from '../../../../src/authorization/permissions/Permissions'; import { AccessMode } from '../../../../src/authorization/permissions/Permissions';
import type { Operation } from '../../../../src/http/Operation'; import type { Operation } from '../../../../src/http/Operation';
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation'; import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
import type { N3Patch } from '../../../../src/http/representation/N3Patch'; import type { N3Patch } from '../../../../src/http/representation/N3Patch';
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
import type { ResourceSet } from '../../../../src/storage/ResourceSet'; import type { ResourceSet } from '../../../../src/storage/ResourceSet';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../../../src/util/map/IdentifierMap';
import { compareMaps } from '../../../util/Util';
const { quad, namedNode } = DataFactory; const { quad, namedNode } = DataFactory;
describe('An N3PatchModesExtractor', (): void => { describe('An N3PatchModesExtractor', (): void => {
const target: ResourceIdentifier = { path: 'http://example.com/foo' };
const triple: Quad = quad(namedNode('a'), namedNode('b'), namedNode('c')); const triple: Quad = quad(namedNode('a'), namedNode('b'), namedNode('c'));
let patch: N3Patch; let patch: N3Patch;
let operation: Operation; let operation: Operation;
let resourceSet: jest.Mocked<ResourceSet>; let resourceSet: jest.Mocked<ResourceSet>;
let extractor: N3PatchModesExtractor; let extractor: N3PatchModesExtractor;
function getMap(modes: AccessMode[], identifier?: ResourceIdentifier): AccessMap {
return new IdentifierSetMultiMap(
modes.map((mode): [ResourceIdentifier, AccessMode] => [ identifier ?? target, mode ]),
);
}
beforeEach(async(): Promise<void> => { beforeEach(async(): Promise<void> => {
patch = new BasicRepresentation() as N3Patch; patch = new BasicRepresentation() as N3Patch;
patch.deletes = []; patch.deletes = [];
@ -27,7 +38,7 @@ describe('An N3PatchModesExtractor', (): void => {
method: 'PATCH', method: 'PATCH',
body: patch, body: patch,
preferences: {}, preferences: {},
target: { path: 'http://example.com/foo' }, target,
}; };
resourceSet = { resourceSet = {
@ -47,30 +58,29 @@ describe('An N3PatchModesExtractor', (): void => {
it('requires read access when there are conditions.', async(): Promise<void> => { it('requires read access when there are conditions.', async(): Promise<void> => {
patch.conditions = [ triple ]; patch.conditions = [ triple ];
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.read ])); compareMaps(await extractor.handle(operation), getMap([ AccessMode.read ]));
}); });
it('requires append access when there are inserts.', async(): Promise<void> => { it('requires append access when there are inserts.', async(): Promise<void> => {
patch.inserts = [ triple ]; patch.inserts = [ triple ];
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append ])); compareMaps(await extractor.handle(operation), getMap([ AccessMode.append ]));
}); });
it('requires create access when there are inserts and the resource does not exist.', async(): Promise<void> => { it('requires create access when there are inserts and the resource does not exist.', async(): Promise<void> => {
resourceSet.hasResource.mockResolvedValueOnce(false); resourceSet.hasResource.mockResolvedValueOnce(false);
patch.inserts = [ triple ]; patch.inserts = [ triple ];
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append, AccessMode.create ])); compareMaps(await extractor.handle(operation), getMap([ AccessMode.append, AccessMode.create ]));
}); });
it('requires read and write access when there are inserts.', async(): Promise<void> => { it('requires read and write access when there are inserts.', async(): Promise<void> => {
patch.deletes = [ triple ]; patch.deletes = [ triple ];
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.read, AccessMode.write ])); compareMaps(await extractor.handle(operation), getMap([ AccessMode.read, AccessMode.write ]));
}); });
it('combines required access modes when required.', async(): Promise<void> => { it('combines required access modes when required.', async(): Promise<void> => {
patch.conditions = [ triple ]; patch.conditions = [ triple ];
patch.inserts = [ triple ]; patch.inserts = [ triple ];
patch.deletes = [ triple ]; patch.deletes = [ triple ];
await expect(extractor.handle(operation)).resolves compareMaps(await extractor.handle(operation), getMap([ AccessMode.read, AccessMode.append, AccessMode.write ]));
.toEqual(new Set([ AccessMode.read, AccessMode.append, AccessMode.write ]));
}); });
}); });

View File

@ -1,17 +1,40 @@
import { Factory } from 'sparqlalgebrajs'; import { Factory } from 'sparqlalgebrajs';
import type { AccessMap } from '../../../../src/authorization/permissions/Permissions';
import { AccessMode } from '../../../../src/authorization/permissions/Permissions'; import { AccessMode } from '../../../../src/authorization/permissions/Permissions';
import { SparqlUpdateModesExtractor } from '../../../../src/authorization/permissions/SparqlUpdateModesExtractor'; import { SparqlUpdateModesExtractor } from '../../../../src/authorization/permissions/SparqlUpdateModesExtractor';
import type { Operation } from '../../../../src/http/Operation'; import type { Operation } from '../../../../src/http/Operation';
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
import type { SparqlUpdatePatch } from '../../../../src/http/representation/SparqlUpdatePatch'; import type { SparqlUpdatePatch } from '../../../../src/http/representation/SparqlUpdatePatch';
import type { ResourceSet } from '../../../../src/storage/ResourceSet'; import type { ResourceSet } from '../../../../src/storage/ResourceSet';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError'; import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
import { IdentifierSetMultiMap } from '../../../../src/util/map/IdentifierMap';
import { compareMaps } from '../../../util/Util';
describe('A SparqlUpdateModesExtractor', (): void => { describe('A SparqlUpdateModesExtractor', (): void => {
const target: ResourceIdentifier = { path: 'http://example.com/foo' };
let patch: SparqlUpdatePatch;
let operation: Operation;
let resourceSet: jest.Mocked<ResourceSet>; let resourceSet: jest.Mocked<ResourceSet>;
let extractor: SparqlUpdateModesExtractor; let extractor: SparqlUpdateModesExtractor;
const factory = new Factory(); const factory = new Factory();
function getMap(modes: AccessMode[], identifier?: ResourceIdentifier): AccessMap {
return new IdentifierSetMultiMap(
modes.map((mode): [ResourceIdentifier, AccessMode] => [ identifier ?? target, mode ]),
);
}
beforeEach(async(): Promise<void> => { beforeEach(async(): Promise<void> => {
patch = new BasicRepresentation() as SparqlUpdatePatch;
operation = {
method: 'PATCH',
body: patch,
preferences: {},
target,
};
resourceSet = { resourceSet = {
hasResource: jest.fn().mockResolvedValue(true), hasResource: jest.fn().mockResolvedValue(true),
}; };
@ -19,7 +42,7 @@ describe('A SparqlUpdateModesExtractor', (): void => {
}); });
it('can only handle (composite) SPARQL DELETE/INSERT operations.', async(): Promise<void> => { it('can only handle (composite) SPARQL DELETE/INSERT operations.', async(): Promise<void> => {
const operation = { method: 'PATCH', body: { algebra: factory.createDeleteInsert() }} as unknown as Operation; patch.algebra = factory.createDeleteInsert();
await expect(extractor.canHandle(operation)).resolves.toBeUndefined(); await expect(extractor.canHandle(operation)).resolves.toBeUndefined();
(operation.body as SparqlUpdatePatch).algebra = factory.createCompositeUpdate([ factory.createDeleteInsert() ]); (operation.body as SparqlUpdatePatch).algebra = factory.createCompositeUpdate([ factory.createDeleteInsert() ]);
await expect(extractor.canHandle(operation)).resolves.toBeUndefined(); await expect(extractor.canHandle(operation)).resolves.toBeUndefined();
@ -28,75 +51,59 @@ describe('A SparqlUpdateModesExtractor', (): void => {
await expect(result).rejects.toThrow(NotImplementedHttpError); await expect(result).rejects.toThrow(NotImplementedHttpError);
await expect(result).rejects.toThrow('Cannot determine permissions of non-SPARQL patches.'); await expect(result).rejects.toThrow('Cannot determine permissions of non-SPARQL patches.');
result = extractor.canHandle({ ...operation, patch.algebra = factory.createMove('DEFAULT', 'DEFAULT');
body: { algebra: factory.createMove('DEFAULT', 'DEFAULT') } as unknown as SparqlUpdatePatch }); result = extractor.canHandle(operation);
await expect(result).rejects.toThrow(NotImplementedHttpError); await expect(result).rejects.toThrow(NotImplementedHttpError);
await expect(result).rejects.toThrow('Can only determine permissions of a PATCH with DELETE/INSERT operations.'); await expect(result).rejects.toThrow('Can only determine permissions of a PATCH with DELETE/INSERT operations.');
}); });
it('requires nothing for NOP operations.', async(): Promise<void> => { it('requires nothing for NOP operations.', async(): Promise<void> => {
const operation = { patch.algebra = factory.createNop();
method: 'PATCH', compareMaps(await extractor.handle(operation), getMap([]));
body: { algebra: factory.createNop() },
} as unknown as Operation;
await expect(extractor.handle(operation)).resolves.toEqual(new Set());
}); });
it('requires append for INSERT operations.', async(): Promise<void> => { it('requires append for INSERT operations.', async(): Promise<void> => {
const operation = { patch.algebra = factory.createDeleteInsert(undefined, [
method: 'PATCH', factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
body: { algebra: factory.createDeleteInsert(undefined, [ ]);
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), compareMaps(await extractor.handle(operation), getMap([ AccessMode.append ]));
]) },
} as unknown as Operation;
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append ]));
}); });
it('requires create for INSERT operations if the resource does not exist.', async(): Promise<void> => { it('requires create for INSERT operations if the resource does not exist.', async(): Promise<void> => {
resourceSet.hasResource.mockResolvedValueOnce(false); resourceSet.hasResource.mockResolvedValueOnce(false);
const operation = { patch.algebra = factory.createDeleteInsert(undefined, [
method: 'PATCH', factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
body: { algebra: factory.createDeleteInsert(undefined, [ ]);
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), compareMaps(await extractor.handle(operation), getMap([ AccessMode.append, AccessMode.create ]));
]) },
} as unknown as Operation;
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append, AccessMode.create ]));
}); });
it('requires read and write for DELETE operations.', async(): Promise<void> => { it('requires read and write for DELETE operations.', async(): Promise<void> => {
const operation = { patch.algebra = factory.createDeleteInsert([
method: 'PATCH', factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
body: { algebra: factory.createDeleteInsert([ ]);
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), compareMaps(await extractor.handle(operation), getMap([ AccessMode.read, AccessMode.write ]));
]) },
} as unknown as Operation;
await expect(extractor.handle(operation))
.resolves.toEqual(new Set([ AccessMode.read, AccessMode.write ]));
}); });
it('requires read and append for composite operations with an insert and conditions.', async(): Promise<void> => { it('requires read and append for composite operations with an insert and conditions.', async(): Promise<void> => {
const operation = { patch.algebra = factory.createCompositeUpdate([
method: 'PATCH', factory.createDeleteInsert(undefined, [
body: { algebra: factory.createCompositeUpdate([ factory.createDeleteInsert(undefined, [
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
], factory.createBgp([ ], factory.createBgp([
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
])) ]) }, ])),
} as unknown as Operation; ]);
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append, AccessMode.read ])); compareMaps(await extractor.handle(operation), getMap([ AccessMode.append, AccessMode.read ]));
}); });
it('requires read, write and append for composite operations with a delete and insert.', async(): Promise<void> => { it('requires read, write and append for composite operations with a delete and insert.', async(): Promise<void> => {
const operation = { patch.algebra = factory.createCompositeUpdate([
method: 'PATCH', factory.createDeleteInsert(undefined, [
body: { algebra: factory.createCompositeUpdate([ factory.createDeleteInsert(undefined, [
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
]), ]),
factory.createDeleteInsert([ factory.createDeleteInsert([
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')), factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
]) ]) }, ]),
} as unknown as Operation; ]);
await expect(extractor.handle(operation)) compareMaps(await extractor.handle(operation), getMap([ AccessMode.append, AccessMode.read, AccessMode.write ]));
.resolves.toEqual(new Set([ AccessMode.append, AccessMode.read, AccessMode.write ]));
}); });
}); });

View File

@ -59,6 +59,18 @@ export async function flushPromises(): Promise<void> {
return new Promise(jest.requireActual('timers').setImmediate); return new Promise(jest.requireActual('timers').setImmediate);
} }
/**
* Compares the contents of the given two maps.
*/
export function compareMaps<TKey, TVal>(map1: Map<TKey, TVal>, map2: Map<TKey, TVal>): void {
expect(new Set(map1.keys())).toEqual(new Set(map2.keys()));
// Looping like this also allows us to compare SetMultiMaps
for (const key of map1.keys()) {
// Adding key for better error output
expect({ key, value: map1.get(key) }).toEqual({ key, value: map2.get(key) });
}
}
/** /**
* Mocks (some) functions of the fs system library. * Mocks (some) functions of the fs system library.
* It is important that you call `jest.mock('fs');` in your test file before calling this!!! * It is important that you call `jest.mock('fs');` in your test file before calling this!!!