Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Extract correct access modes from request

Browse Source
This commit is contained in:
Joachim Van Herwegen
2022-02-25 10:30:54 +01:00
parent 0e4d012086
commit 9a29cc2257
9 changed files with 197 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
test/unit/authorization/permissions/SparqlUpdateModesExtractor.test.ts
View File

@@ -3,12 +3,21 @@ import { AccessMode } from '../../../../src/authorization/permissions/Permission
import { SparqlUpdateModesExtractor } from '../../../../src/authorization/permissions/SparqlUpdateModesExtractor';
import type { Operation } from '../../../../src/http/Operation';
import type { SparqlUpdatePatch } from '../../../../src/http/representation/SparqlUpdatePatch';
import type { ResourceSet } from '../../../../src/storage/ResourceSet';
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
describe('A SparqlUpdateModesExtractor', (): void => {
const extractor = new SparqlUpdateModesExtractor();
let resourceSet: jest.Mocked<ResourceSet>;
let extractor: SparqlUpdateModesExtractor;
const factory = new Factory();
beforeEach(async(): Promise<void> => {
resourceSet = {
hasResource: jest.fn().mockResolvedValue(true),
};
extractor = new SparqlUpdateModesExtractor(resourceSet);
});
it('can only handle (composite) SPARQL DELETE/INSERT operations.', async(): Promise<void> => {
const operation = { method: 'PATCH', body: { algebra: factory.createDeleteInsert() }} as unknown as Operation;
await expect(extractor.canHandle(operation)).resolves.toBeUndefined();
@@ -43,7 +52,18 @@ describe('A SparqlUpdateModesExtractor', (): void => {
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append ]));
});
it('requires write for DELETE operations.', async(): Promise<void> => {
it('requires create for INSERT operations if the resource does not exist.', async(): Promise<void> => {
resourceSet.hasResource.mockResolvedValueOnce(false);
const operation = {
method: 'PATCH',
body: { algebra: factory.createDeleteInsert(undefined, [
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
]) },
} as unknown as Operation;
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append, AccessMode.create ]));
});
it('requires read and write for DELETE operations.', async(): Promise<void> => {
const operation = {
method: 'PATCH',
body: { algebra: factory.createDeleteInsert([
@@ -51,20 +71,22 @@ describe('A SparqlUpdateModesExtractor', (): void => {
]) },
} as unknown as Operation;
await expect(extractor.handle(operation))
.resolves.toEqual(new Set([ AccessMode.append, AccessMode.write, AccessMode.create, AccessMode.delete ]));
.resolves.toEqual(new Set([ AccessMode.read, AccessMode.write ]));
});
it('requires append for composite operations with an insert.', async(): Promise<void> => {
it('requires read and append for composite operations with an insert and conditions.', async(): Promise<void> => {
const operation = {
method: 'PATCH',
body: { algebra: factory.createCompositeUpdate([ factory.createDeleteInsert(undefined, [
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
]) ]) },
], factory.createBgp([
factory.createPattern(factory.createTerm('<s>'), factory.createTerm('<p>'), factory.createTerm('<o>')),
])) ]) },
} as unknown as Operation;
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append ]));
await expect(extractor.handle(operation)).resolves.toEqual(new Set([ AccessMode.append, AccessMode.read ]));
});
it('requires write for composite operations with a delete.', async(): Promise<void> => {
it('requires read, write and append for composite operations with a delete and insert.', async(): Promise<void> => {
const operation = {
method: 'PATCH',
body: { algebra: factory.createCompositeUpdate([ factory.createDeleteInsert(undefined, [
@@ -75,6 +97,6 @@ describe('A SparqlUpdateModesExtractor', (): void => {
]) ]) },
} as unknown as Operation;
await expect(extractor.handle(operation))
.resolves.toEqual(new Set([ AccessMode.append, AccessMode.write, AccessMode.create, AccessMode.delete ]));
.resolves.toEqual(new Set([ AccessMode.append, AccessMode.read, AccessMode.write ]));
});
});