From 9ac00ca82ce942282029fd18027cae4d4fcb636b Mon Sep 17 00:00:00 2001 From: Joachim Van Herwegen Date: Mon, 28 Mar 2022 10:56:45 +0200 Subject: [PATCH] chore: Remove validate-components from CI This test has no added value over just starting the server, which we already do in other tests, and has a drastic impact on the CI execution time. --- .github/workflows/ci.yml | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4258c5a47..e78f7e35e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,16 +22,6 @@ jobs: - run: npm ci --ignore-scripts - run: npm run lint - validate-components: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: '16.x' - - run: npm ci - - run: npm run validate - test-unit: runs-on: ${{ matrix.operating-system }} strategy: @@ -145,7 +135,6 @@ jobs: - test-unit - test-integration - test-integration-windows - - validate-components # Only run on tag push events starting with v prefix for now OR main branch push events if: startsWith(github.ref, 'refs/tags/v') || (github.ref == 'refs/heads/main') runs-on: ubuntu-latest @@ -187,14 +176,13 @@ jobs: - test-unit - test-integration - test-integration-windows - - validate-components # Only run on push events on a versions/* branch (ASSUMPTION: THERE SHOULD ONLY BE ONE THERE!) if: startsWith(github.ref, 'refs/heads/versions/') runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@v3 - with: + with: ref: ${{ github.ref }} - name: Docker meta id: meta @@ -221,7 +209,7 @@ jobs: push: true tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} - + docs: runs-on: ubuntu-latest steps: @@ -244,7 +232,6 @@ jobs: - lint - test-unit - test-integration - - validate-components runs-on: ubuntu-latest if: startsWith(github.ref, 'refs/tags/v') steps: