Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Return ETag in 304 responses

Browse Source
This commit is contained in:
Joachim Van Herwegen
2023-07-27 11:19:11 +02:00
parent afcbfdaacf
commit baa64987c6
9 changed files with 87 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/unit/util/errors/HttpError.test.ts
View File

@@ -15,11 +15,10 @@ import { PreconditionFailedHttpError } from '../../../../src/util/errors/Precond
import { UnauthorizedHttpError } from '../../../../src/util/errors/UnauthorizedHttpError';
import { UnprocessableEntityHttpError } from '../../../../src/util/errors/UnprocessableEntityHttpError';
import { UnsupportedMediaTypeHttpError } from '../../../../src/util/errors/UnsupportedMediaTypeHttpError';
import { HTTP, SOLID_ERROR } from '../../../../src/util/Vocabularies';
import { HH, HTTP, SOLID_ERROR } from '../../../../src/util/Vocabularies';
describe('HttpError', (): void => {
const errors: [string, number, HttpErrorClass][] = [
[ 'NotModifiedHttpError', 304, NotModifiedHttpError ],
[ 'BadRequestHttpError', 400, BadRequestHttpError ],
[ 'UnauthorizedHttpError', 401, UnauthorizedHttpError ],
[ 'ForbiddenHttpError', 403, ForbiddenHttpError ],
@@ -106,4 +105,30 @@ describe('HttpError', (): void => {
expect(instance.metadata.get(SOLID_ERROR.terms.disallowedMethod)?.value).toBe('GET');
});
});
describe('NotModifiedHttpError', (): void => {
const eTag = 'ETAG';
const options = {
cause: new Error('cause'),
errorCode: 'E1234',
};
const instance = new NotModifiedHttpError(eTag, 'my message', options);
it('is valid.', async(): Promise<void> => {
expect(new NotModifiedHttpError().metadata.get(HH.terms.etag)).toBeUndefined();
expect(NotModifiedHttpError.isInstance(instance)).toBe(true);
expect(NotModifiedHttpError.uri).toEqualRdfTerm(generateHttpErrorUri(304));
expect(instance.name).toBe('NotModifiedHttpError');
expect(instance.statusCode).toBe(304);
expect(instance.message).toBe('my message');
expect(instance.cause).toBe(options.cause);
expect(instance.errorCode).toBe(options.errorCode);
expect(new NotModifiedHttpError().errorCode).toBe(`H${304}`);
expect(instance.metadata.get(SOLID_ERROR.terms.errorResponse)?.value)
.toBe(`${SOLID_ERROR.namespace}H304`);
expect(instance.metadata.get(HTTP.terms.statusCodeNumber)?.value).toBe('304');
expect(instance.metadata.get(HH.terms.etag)?.value).toBe(eTag);
});
});
});