Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Do not add port 80 to default base URL

Browse Source
This commit is contained in:
Joachim Van Herwegen 2023-02-09 16:39:46 +01:00
parent c332412074
commit bb7427842c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/init/variables/extractors/BaseUrlExtractor.ts
View File

@ -22,6 +22,8 @@ export class BaseUrlExtractor extends ShorthandExtractor {
throw new Error('BaseUrl argument should be provided when using Unix Domain Sockets.'); throw new Error('BaseUrl argument should be provided when using Unix Domain Sockets.');
} }
const port = args.port ?? this.defaultPort; const port = args.port ?? this.defaultPort;
return `http://localhost:${port}/`; const url = new URL('http://localhost/');
url.port = `${port}`;
return url.href;
} }
} }

4
test/unit/init/variables/extractors/BaseUrlExtractor.test.ts
View File

@ -24,4 +24,8 @@ describe('A BaseUrlExtractor', (): void => {
it('defaults to port 3000.', async(): Promise<void> => { it('defaults to port 3000.', async(): Promise<void> => {
await expect(computer.handle({})).resolves.toBe('http://localhost:3000/'); await expect(computer.handle({})).resolves.toBe('http://localhost:3000/');
}); });
it('does not add the port if it is 80.', async(): Promise<void> => {
await expect(computer.handle({ port: 80 })).resolves.toBe('http://localhost/');
});
}); });