refactor: Prevent for-each calls

This commit is contained in:
Joachim Van Herwegen
2023-10-30 16:58:39 +01:00
parent 20d4a0c3af
commit c9e4c7041c
7 changed files with 13 additions and 9 deletions

View File

@@ -89,9 +89,9 @@ export class ExpiringAdapter implements Adapter {
return;
}
const deletePromises: Promise<unknown>[] = [];
grants.forEach((grant): void => {
for (const grant of grants) {
deletePromises.push(this.storage.delete(grant));
});
}
deletePromises.push(this.storage.delete(grantKey));
await Promise.all(deletePromises);
}

View File

@@ -166,7 +166,7 @@ function parseAcceptPart(part: string, replacements: Record<string, string>, str
const extensionParams: Record<string, string> = {};
let map = mediaTypeParams;
const parsedParams = parseParameters(parameters, replacements);
parsedParams.forEach(({ name, value }): void => {
for (const { name, value } of parsedParams) {
if (name === 'q') {
// Extension parameters appear after the q value
map = extensionParams;
@@ -179,11 +179,11 @@ function parseAcceptPart(part: string, replacements: Record<string, string>, str
if (!value && map !== extensionParams) {
handleInvalidValue(`Invalid Accept parameter ${name}: ` +
`Accept parameter values are not optional when preceding the q value`, strict);
return;
continue;
}
map[name] = value || '';
}
});
}
return {
range,