Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Always find the best path with ChainedConverter

Browse Source
This commit is contained in:
Joachim Van Herwegen
2021-07-02 15:23:00 +02:00
parent 0c3210fae7
commit e7ff134b25
2 changed files with 80 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
test/unit/storage/conversion/ChainedConverter.test.ts
View File

@@ -126,7 +126,7 @@ describe('A ChainedConverter', (): void => {
expect(result.metadata.contentType).toBe('x/x');
});
it('will use the best path among the shortest found.', async(): Promise<void> => {
it('will use the shortest path among the best found.', async(): Promise<void> => {
// Valid paths: 0 -> 1 -> 2, 3 -> 2, 4 -> 2, 5 -> 2, *6 -> 2*
const converters = [
new DummyConverter({ 'a/a': 1 }, { 'b/b': 1 }),
@@ -135,7 +135,7 @@ describe('A ChainedConverter', (): void => {
new DummyConverter({ '*/*': 0.5 }, { 'c/c': 1 }),
new DummyConverter({ 'a/a': 0.8 }, { 'c/c': 1 }),
new DummyConverter({ 'a/*': 1 }, { 'c/c': 0.5 }),
new DummyConverter({ 'a/a': 1 }, { 'c/c': 0.9 }),
new DummyConverter({ 'a/a': 1 }, { 'c/c': 1 }),
];
const converter = new ChainedConverter(converters);
@@ -172,6 +172,43 @@ describe('A ChainedConverter', (): void => {
expect(metadata.contentType).toBe('d/d');
});
it('will continue if an even better path can be found by adding a converter.', async(): Promise<void> => {
// Path: a/a -> x/a -> x/x
const converters = [
new DummyConverter({ 'a/a': 1 }, { 'x/a': 0.9 }),
new DummyConverter({ 'x/a': 1 }, { 'x/x': 1 }),
];
const converter = new ChainedConverter(converters);
const result = await converter.handle(args);
expect(result.metadata.contentType).toBe('x/x');
});
it('will continue if an even better path can be found through another path.', async(): Promise<void> => {
// Path: a/a -> b/b -> x/x
const converters = [
new DummyConverter({ 'a/a': 1 }, { 'x/a': 0.5 }),
new DummyConverter({ 'a/a': 1 }, { 'b/b': 1 }),
new DummyConverter({ 'b/b': 1 }, { 'x/x': 0.6 }),
];
const converter = new ChainedConverter(converters);
const result = await converter.handle(args);
expect(result.metadata.contentType).toBe('x/x');
});
it('will stop if all future paths are worse.', async(): Promise<void> => {
// Path: a/a -> x/a
const converters = [
new DummyConverter({ 'a/a': 1 }, { 'x/a': 1 }),
new DummyConverter({ 'x/a': 1 }, { 'x/x': 0.1 }),
];
const converter = new ChainedConverter(converters);
const result = await converter.handle(args);
expect(result.metadata.contentType).toBe('x/a');
});
it('calls handle when calling handleSafe.', async(): Promise<void> => {
const converters = [ new DummyConverter({ 'a/a': 1 }, { 'x/x': 1 }) ];
const converter = new ChainedConverter(converters);