Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Stop creating meta files for each new resource #1217

Browse Source
This commit is contained in:
Wannes Kerckhove
2022-04-26 17:09:19 +02:00
committed by Joachim Van Herwegen
parent f0f900edfb
commit fbbccb0cf1
11 changed files with 259 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
test/unit/storage/accessors/FilterMetadataDataAccessor.test.ts Normal file
View File

@@ -0,0 +1,120 @@
import { APPLICATION_JSON, CONTENT_LENGTH, CONTENT_TYPE, FilterPattern, toNamedTerm } from '../../../../src';
import { RepresentationMetadata } from '../../../../src/http/representation/RepresentationMetadata';
import type { DataAccessor } from '../../../../src/storage/accessors/DataAccessor';
import { FilterMetadataDataAccessor } from '../../../../src/storage/accessors/FilterMetadataDataAccessor';
import { guardedStreamFrom } from '../../../../src/util/StreamUtil';
describe('FilterMetadataDataAccessor', (): void => {
let childAccessor: jest.Mocked<DataAccessor>;
const mockIdentifier = { path: 'http://localhost/test.txt' };
const mockData = guardedStreamFrom('test string');
beforeEach(async(): Promise<void> => {
jest.clearAllMocks();
childAccessor = {
writeDocument: jest.fn(),
writeContainer: jest.fn(),
} as any;
childAccessor.getChildren = jest.fn();
});
it('removes only the matching metadata properties when calling writeDocument.', async(): Promise<void> => {
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor,
[ new FilterPattern(undefined, CONTENT_LENGTH) ]);
const mockMetadata = new RepresentationMetadata();
mockMetadata.contentLength = 40;
mockMetadata.contentType = APPLICATION_JSON;
await filterMetadataAccessor.writeDocument(mockIdentifier, mockData, mockMetadata);
expect(childAccessor.writeDocument).toHaveBeenCalledTimes(1);
expect(childAccessor.writeDocument).toHaveBeenLastCalledWith(mockIdentifier, mockData, mockMetadata);
expect(mockMetadata.contentLength).toBeUndefined();
expect(mockMetadata.contentType).toBe(APPLICATION_JSON);
});
it('supports multiple filter patterns when calling writeDocument.', async(): Promise<void> => {
const filters = [
new FilterPattern(undefined, CONTENT_LENGTH),
new FilterPattern(undefined, CONTENT_TYPE),
];
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor, filters);
const mockMetadata = new RepresentationMetadata();
mockMetadata.contentLength = 40;
mockMetadata.contentType = APPLICATION_JSON;
await filterMetadataAccessor.writeDocument(mockIdentifier, mockData, mockMetadata);
expect(childAccessor.writeDocument).toHaveBeenCalledTimes(1);
expect(childAccessor.writeDocument).toHaveBeenLastCalledWith(mockIdentifier, mockData, mockMetadata);
expect(mockMetadata.contentLength).toBeUndefined();
expect(mockMetadata.contentType).toBeUndefined();
});
it('removes only the matching metadata properties when calling writeContainer.', async(): Promise<void> => {
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor,
[ new FilterPattern(undefined, CONTENT_LENGTH) ]);
const mockMetadata = new RepresentationMetadata();
mockMetadata.contentLength = 40;
mockMetadata.contentType = APPLICATION_JSON;
await filterMetadataAccessor.writeContainer(mockIdentifier, mockMetadata);
expect(childAccessor.writeContainer).toHaveBeenCalledTimes(1);
expect(childAccessor.writeContainer).toHaveBeenLastCalledWith(mockIdentifier, mockMetadata);
expect(mockMetadata.contentLength).toBeUndefined();
expect(mockMetadata.contentType).toBe(APPLICATION_JSON);
});
it('supports multiple filter patterns when calling writeContainer.', async(): Promise<void> => {
const filters = [
new FilterPattern(undefined, CONTENT_LENGTH),
new FilterPattern(undefined, CONTENT_TYPE),
];
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor, filters);
const mockMetadata = new RepresentationMetadata();
mockMetadata.contentLength = 40;
mockMetadata.contentType = APPLICATION_JSON;
await filterMetadataAccessor.writeContainer(mockIdentifier, mockMetadata);
expect(childAccessor.writeContainer).toHaveBeenCalledTimes(1);
expect(childAccessor.writeContainer).toHaveBeenLastCalledWith(mockIdentifier, mockMetadata);
expect(mockMetadata.contentLength).toBeUndefined();
expect(mockMetadata.contentType).toBeUndefined();
});
it('an empty filter matches all metadata entries, and thus everything is removed.', async(): Promise<void> => {
const filters = [ new FilterPattern() ];
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor, filters);
const mockMetadata = new RepresentationMetadata();
mockMetadata.contentLength = 40;
mockMetadata.contentType = APPLICATION_JSON;
await filterMetadataAccessor.writeContainer(mockIdentifier, mockMetadata);
expect(childAccessor.writeContainer).toHaveBeenCalledTimes(1);
expect(childAccessor.writeContainer).toHaveBeenLastCalledWith(mockIdentifier, mockMetadata);
expect(mockMetadata.contentLength).toBeUndefined();
expect(mockMetadata.contentType).toBeUndefined();
expect(mockMetadata.quads()).toHaveLength(0);
});
it('supports filtering based on subject.', async(): Promise<void> => {
const subject = 'http://example.org/resource/test1';
const filters = [ new FilterPattern(subject) ];
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor, filters);
const mockMetadata = new RepresentationMetadata();
mockMetadata.addQuad(subject, toNamedTerm('http://xmlns.com/foaf/0.1/name'), 'Alice');
expect(mockMetadata.quads(subject)).toHaveLength(1);
await filterMetadataAccessor.writeDocument(mockIdentifier, mockData, mockMetadata);
expect(childAccessor.writeDocument).toHaveBeenCalledTimes(1);
expect(childAccessor.writeDocument).toHaveBeenLastCalledWith(mockIdentifier, mockData, mockMetadata);
expect(mockMetadata.quads(subject)).toHaveLength(0);
});
it('supports filtering based on object.', async(): Promise<void> => {
const subject = 'http://example.org/resource/test1';
const object = 'http://example.org/resource/test2';
const filters = [ new FilterPattern(undefined, undefined, object) ];
const filterMetadataAccessor = new FilterMetadataDataAccessor(childAccessor, filters);
const mockMetadata = new RepresentationMetadata();
mockMetadata.addQuad(subject, toNamedTerm('http://xmlns.com/foaf/0.1/knows'), toNamedTerm(object));
expect(mockMetadata.quads(subject)).toHaveLength(1);
await filterMetadataAccessor.writeContainer(mockIdentifier, mockMetadata);
expect(childAccessor.writeContainer).toHaveBeenCalledTimes(1);
expect(childAccessor.writeContainer).toHaveBeenLastCalledWith(mockIdentifier, mockMetadata);
expect(mockMetadata.quads(subject)).toHaveLength(0);
});
});