mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00
ce754c119f
* Solution works but tests don't * refactor(FetchUtil): use arrayifyStream * refactor(FetchUtil): split fetchDataset into 2 separate functions * style(FetchUtil): onelining instead of declaring new local var * test: trying to mock rdfDereferencer * refactor: promise can't have async function as arg * test(FetchUtil): pass Quad array to mockDereference instead * test: all tests should pass now and coverage is back to 100% * style: comment typo * chore: make package.json and package-lock.json compatible with main * chore: fix package.json double entries * chore: updated package.json to be alfabetical again * refactor(AgentGroupAccessChecker): Remove converter from contructor and config * refactor(TokenOwnerShipValidator): Remove converter from constructor and config * refactor(FetchUtil): Return BadRequestHttpError instead of generic Error * test(FetchUtil): return Response object instead of mocking fetch * style: typos and newlines
61 lines
2.9 KiB
TypeScript
61 lines
2.9 KiB
TypeScript
import { DataFactory, Store } from 'n3';
|
|
import type { AccessCheckerArgs } from '../../../../src/authorization/access/AccessChecker';
|
|
import { AgentGroupAccessChecker } from '../../../../src/authorization/access/AgentGroupAccessChecker';
|
|
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
|
|
import type { Representation } from '../../../../src/http/representation/Representation';
|
|
import type { ExpiringStorage } from '../../../../src/storage/keyvalue/ExpiringStorage';
|
|
import { INTERNAL_QUADS } from '../../../../src/util/ContentTypes';
|
|
import * as fetchUtil from '../../../../src/util/FetchUtil';
|
|
import { ACL, VCARD } from '../../../../src/util/Vocabularies';
|
|
const { namedNode, quad } = DataFactory;
|
|
|
|
describe('An AgentGroupAccessChecker', (): void => {
|
|
const webId = 'http://test.com/alice/profile/card#me';
|
|
const groupId = 'http://test.com/group';
|
|
const acl = new Store();
|
|
acl.addQuad(namedNode('groupMatch'), ACL.terms.agentGroup, namedNode(groupId));
|
|
acl.addQuad(namedNode('noMatch'), ACL.terms.agentGroup, namedNode('badGroup'));
|
|
let fetchMock: jest.SpyInstance;
|
|
let representation: Representation;
|
|
let cache: ExpiringStorage<string, Promise<Store>>;
|
|
let checker: AgentGroupAccessChecker;
|
|
|
|
beforeEach(async(): Promise<void> => {
|
|
const groupQuads = [ quad(namedNode(groupId), VCARD.terms.hasMember, namedNode(webId)) ];
|
|
representation = new BasicRepresentation(groupQuads, INTERNAL_QUADS, false);
|
|
fetchMock = jest.spyOn(fetchUtil, 'fetchDataset');
|
|
fetchMock.mockResolvedValue(representation);
|
|
fetchMock.mockClear();
|
|
|
|
cache = new Map() as any;
|
|
|
|
checker = new AgentGroupAccessChecker(cache);
|
|
});
|
|
|
|
it('can handle all requests.', async(): Promise<void> => {
|
|
await expect(checker.canHandle(null as any)).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('returns true if the WebID is a valid group member.', async(): Promise<void> => {
|
|
const input: AccessCheckerArgs = { acl, rule: namedNode('groupMatch'), credential: { webId }};
|
|
await expect(checker.handle(input)).resolves.toBe(true);
|
|
});
|
|
|
|
it('returns false if the WebID is not a valid group member.', async(): Promise<void> => {
|
|
const input: AccessCheckerArgs = { acl, rule: namedNode('noMatch'), credential: { webId }};
|
|
await expect(checker.handle(input)).resolves.toBe(false);
|
|
});
|
|
|
|
it('returns false if there are no WebID credentials.', async(): Promise<void> => {
|
|
const input: AccessCheckerArgs = { acl, rule: namedNode('groupMatch'), credential: {}};
|
|
await expect(checker.handle(input)).resolves.toBe(false);
|
|
});
|
|
|
|
it('caches fetched results.', async(): Promise<void> => {
|
|
const input: AccessCheckerArgs = { acl, rule: namedNode('groupMatch'), credential: { webId }};
|
|
await expect(checker.handle(input)).resolves.toBe(true);
|
|
await expect(checker.handle(input)).resolves.toBe(true);
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|