Wout Slabbinck ca62511d12
feat: Edit metadata resources (#1188)
* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available

* fix: remove unnecesary log at POST

* feat: PUT resets metadata contents + not possible to add metadata with PUT to container

* feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers

* feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata

* test: add unit tests to operationhandlers to handle metadata editing

* test: add unit tests to representationPatchHandler to handle metadata editing

* fix: update dependency of meta.json to version 3.0.0

* fix: lint and dependency still v2

* fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic

* fix: moved checking metadata resources checking from DELETE and POST handler down to DABS

* fix: remove PATCH message about metadata extension

* fix: move PATCH message about metadata extension

* WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1)

* WIP: implement writeMetadata in memorybackend + change resourceExists

* WIP: implement writeMetadata in SparqlDataAccessor.ts

* test: fix test interfaces

* test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier)

* test: accessor tests implemented for metadata

* test: add RdfImmutableCheckPatcher.test.ts

* test: add tests in DataAccessorBasedStore.test.ts

* test: fix template config for DynamicPods test

* test: add integration tests for metadata

* fix: change metaStrategy to metadataStrategy

* refactor: comments updated to new location CSS on github + some alphabetical edits

* refactor: remove getMetadata function in DABS as it is only used once

* refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts

* docs: modify documentation for writeMetadata function in DataAccessor.ts

* feat: ldp:contains is also part of the metadata resource of a container

* refactor: change function name and move check to DataAccessorBasedStore

* fix: fix tests for DABS and PutOperationHandler

* feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher

* test: fix patcher tests

* feat: create sparqlInsertMetadata in SparqlDataAccessor.ts

* fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR

* test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit

* test: add converter to DABS and replace rejection on data during container creation to warning

* test: implemented RdfPatcher test

* feat: remove ContainerPatcher

* fix: fix lint

* fix: fix integration tests

* refactor: fix minor issues mentioned in the PR

* WIP: problem with removeResponseMetadata

* refactor: remove responseMetadata in QuadToRdfConverter.ts

* feat: handle ResponeMetadata when writing to the store via a patch

* refactor: refactor based on comments in PR

* feat: make ImmutableMetadataPatcher.ts instantiation more clear

* test: achieve 100% coverage again

* fix: fix lint

* refactor: return to explicit arguments for the DABS

* fix: return to explicit arguments for the DABS (missed one)

* feat: optimise immutable checker

* fix: fix, enhance docs + optimise config files

* fix: DABS + QuadToRdfConverter feedback implemented

* fix: patching feedback implemented

* test: update operationhandler tests

* test: update integration tests after feedback

* test: update DABS tests after feedback

* test: update ImmutableMetadataPatcher.test.ts after feedback

* test: update patch tests after feedback

* docs: add documentation about editing metadata

* fix: config: intendation + name change + extra filters | filter pattern

* docs: tsdoc added to RdfStorePatcher.ts

* fix: DABS split implemented for getRepresentation + comment refactoring

* docs: further documentation on removing response data on serialization

* fix: DABS getRepresentation method

* docs: apply feedback from Joachim on the documentation of metadata-editing.md

* fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim

* docs: small fix in metadata-editing.md documentation after feedback from Joachim

* fix: fix metadata-editing.md documentation after feedback from Joachim

* fix: fix tests meta-editing after feedback Joachim

* feat: first attempt at RELEASE_NOTES.md

* docs: update release notes based on feedback

* docs: fix newline

* fix: patching config changes after feedback

* docs: metadata editing documentation changes after feedback

* docs: metadata editing documentation changes after feedback

* docs: metadata editing documentation changes after feedback

* feat: optimisation on ImmutableMetadataPatcher.ts algorithm

* feat: remove converter from DABS and add conversion for metadata resources in the RCS

* fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore

* feat: make RepresentationPatcher generic

* test: generic RepresentationPatcher tests

* test: 100% coverage for patchers again

* feat: containers can be created with POST with no content-type

* feat: Immutable checks always with subject identifier

* feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header

* test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher

* feat: remove metadataGenerator from acl.json and fix tests accordingly

* WIP: preserve metadata on PUT

* feat: preserve metadata on PUT

* fix: keep metadata on PATCHes

* test: add unit tests for preserving metadata on PUT

* fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json)

* fix: add metadatastrategy to RepresentationConvertingStore in regex.json

* test: add integration tests for preserving metadata on PUT

* docs: update release notes and adding documentation about preserving metadata on PUT

* WIP: Template create setRepresentation

* fix: Move container exists and not allowed check to setRepresentation

* test: fix lint

* fix: update configs and documentation

* refactor: update and add documentation + small refactoring

* refactor: update and add documentation + small refactoring + fix tests

* fix: Dynamic pod config + tests

* fix: TemplatedResourcesGenerator does not create containers when they already exist

* fix: metadata preservation now deals with complex content types

* docs: explain the case when there is no content-type

* fix: minor comments
2022-08-04 15:24:36 +02:00

131 lines
4.5 KiB
TypeScript

import 'jest-rdf';
import type { Response } from 'cross-fetch';
import fetch from 'cross-fetch';
import type { Quad } from 'n3';
import { Parser } from 'n3';
import { isContainerPath } from '../../src/util/PathUtil';
import { LDP } from '../../src/util/Vocabularies';
/**
* This is specifically for GET requests which are expected to succeed.
*/
export async function getResource(url: string,
options?: { accept?: string },
expected?: { contentType?: string }): Promise<Response> {
const isContainer = isContainerPath(url);
const response = await fetch(url, { headers: options });
expect(response.status).toBe(200);
expect(response.headers.get('link')).toContain(`<${LDP.Resource}>; rel="type"`);
expect(response.headers.get('link')).toContain(`<${url}.acl>; rel="acl"`);
expect(response.headers.get('accept-patch')).toBe('text/n3, application/sparql-update');
expect(response.headers.get('ms-author-via')).toBe('SPARQL');
if (isContainer) {
expect(response.headers.get('link')).toContain(`<${LDP.Container}>; rel="type"`);
expect(response.headers.get('link')).toContain(`<${LDP.BasicContainer}>; rel="type"`);
}
if (expected?.contentType) {
expect(response.headers.get('content-type')).toBe(expected.contentType);
} else if (isContainer) {
expect(response.headers.get('content-type')).toBe('text/turtle');
}
return response;
}
/**
* This is specifically for PUT requests which are expected to succeed.
*/
export async function putResource(url: string, options: { contentType: string; body?: string; exists?: boolean }):
Promise<Response> {
const init: RequestInit = {
method: 'PUT',
headers: { 'content-type': options.contentType },
body: options.body,
};
if (isContainerPath(url)) {
(init.headers as Record<string, string>).link = '<http://www.w3.org/ns/ldp#Container>; rel="type"';
}
const response = await fetch(url, init);
expect(response.status).toBe(options.exists ? 205 : 201);
if (!options.exists) {
expect(response.headers.get('location')).toBe(url);
}
await expect(response.text()).resolves.toHaveLength(0);
return response;
}
export type CreateOptions = {
contentType: string;
isContainer?: boolean;
slug?: string;
body?: string;
};
/**
* This is specifically for POST requests which are expected to succeed.
*/
export async function postResource(container: string, options: CreateOptions): Promise<Response> {
const init: RequestInit = {
method: 'POST',
headers: { 'content-type': options.contentType },
body: options.body,
};
if (options.isContainer) {
(init.headers as Record<string, string>).link = '<http://www.w3.org/ns/ldp#Container>; rel="type"';
}
if (options.slug) {
(init.headers as Record<string, string>).slug = options.slug;
}
const response = await fetch(container, init);
await expect(response.text()).resolves.toHaveLength(0);
expect(response.status).toBe(201);
const regex = new RegExp(`^${container}[^/]+${options.isContainer ? '/' : ''}`, 'u');
expect(response.headers.get('location')).toMatch(regex);
return response;
}
/**
* This is specifically for PATCH requests which are expected to succeed.
*/
export async function patchResource(url: string, query: string, type: 'sparql' | 'n3', exists?: boolean):
Promise<Response> {
const contentTypes = { sparql: 'application/sparql-update', n3: 'text/n3' };
const response = await fetch(url, {
method: 'PATCH',
headers: {
'content-type': contentTypes[type],
},
body: query,
});
await expect(response.text()).resolves.toHaveLength(0);
expect(response.status).toBe(exists ? 205 : 201);
if (!exists) {
expect(response.headers.get('location')).toBe(url);
}
return response;
}
export async function deleteResource(url: string): Promise<void> {
let response = await fetch(url, { method: 'DELETE' });
expect(response.status).toBe(205);
response = await fetch(url);
expect(response.status).toBe(404);
}
/**
* Verifies if the body of the given Response contains the expected Quads.
* If `exact` is true, a 1-to-1 match is expected, if not, the expected quads should be a subset of the body.
*/
export async function expectQuads(response: Response, expected: Quad[], exact?: boolean): Promise<void> {
const parser = new Parser({ baseIRI: response.url });
const quads = parser.parse(await response.text());
if (exact) {
expect(quads).toBeRdfIsomorphic(expected);
} else {
for (const expectedQuad of expected) {
expect(quads.some((entry): boolean => entry.equals(expectedQuad))).toBe(true);
}
}
}