Wout Slabbinck ca62511d12
feat: Edit metadata resources (#1188)
* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available

* fix: remove unnecesary log at POST

* feat: PUT resets metadata contents + not possible to add metadata with PUT to container

* feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers

* feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata

* test: add unit tests to operationhandlers to handle metadata editing

* test: add unit tests to representationPatchHandler to handle metadata editing

* fix: update dependency of meta.json to version 3.0.0

* fix: lint and dependency still v2

* fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic

* fix: moved checking metadata resources checking from DELETE and POST handler down to DABS

* fix: remove PATCH message about metadata extension

* fix: move PATCH message about metadata extension

* WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1)

* WIP: implement writeMetadata in memorybackend + change resourceExists

* WIP: implement writeMetadata in SparqlDataAccessor.ts

* test: fix test interfaces

* test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier)

* test: accessor tests implemented for metadata

* test: add RdfImmutableCheckPatcher.test.ts

* test: add tests in DataAccessorBasedStore.test.ts

* test: fix template config for DynamicPods test

* test: add integration tests for metadata

* fix: change metaStrategy to metadataStrategy

* refactor: comments updated to new location CSS on github + some alphabetical edits

* refactor: remove getMetadata function in DABS as it is only used once

* refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts

* docs: modify documentation for writeMetadata function in DataAccessor.ts

* feat: ldp:contains is also part of the metadata resource of a container

* refactor: change function name and move check to DataAccessorBasedStore

* fix: fix tests for DABS and PutOperationHandler

* feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher

* test: fix patcher tests

* feat: create sparqlInsertMetadata in SparqlDataAccessor.ts

* fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR

* test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit

* test: add converter to DABS and replace rejection on data during container creation to warning

* test: implemented RdfPatcher test

* feat: remove ContainerPatcher

* fix: fix lint

* fix: fix integration tests

* refactor: fix minor issues mentioned in the PR

* WIP: problem with removeResponseMetadata

* refactor: remove responseMetadata in QuadToRdfConverter.ts

* feat: handle ResponeMetadata when writing to the store via a patch

* refactor: refactor based on comments in PR

* feat: make ImmutableMetadataPatcher.ts instantiation more clear

* test: achieve 100% coverage again

* fix: fix lint

* refactor: return to explicit arguments for the DABS

* fix: return to explicit arguments for the DABS (missed one)

* feat: optimise immutable checker

* fix: fix, enhance docs + optimise config files

* fix: DABS + QuadToRdfConverter feedback implemented

* fix: patching feedback implemented

* test: update operationhandler tests

* test: update integration tests after feedback

* test: update DABS tests after feedback

* test: update ImmutableMetadataPatcher.test.ts after feedback

* test: update patch tests after feedback

* docs: add documentation about editing metadata

* fix: config: intendation + name change + extra filters | filter pattern

* docs: tsdoc added to RdfStorePatcher.ts

* fix: DABS split implemented for getRepresentation + comment refactoring

* docs: further documentation on removing response data on serialization

* fix: DABS getRepresentation method

* docs: apply feedback from Joachim on the documentation of metadata-editing.md

* fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim

* docs: small fix in metadata-editing.md documentation after feedback from Joachim

* fix: fix metadata-editing.md documentation after feedback from Joachim

* fix: fix tests meta-editing after feedback Joachim

* feat: first attempt at RELEASE_NOTES.md

* docs: update release notes based on feedback

* docs: fix newline

* fix: patching config changes after feedback

* docs: metadata editing documentation changes after feedback

* docs: metadata editing documentation changes after feedback

* docs: metadata editing documentation changes after feedback

* feat: optimisation on ImmutableMetadataPatcher.ts algorithm

* feat: remove converter from DABS and add conversion for metadata resources in the RCS

* fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore

* feat: make RepresentationPatcher generic

* test: generic RepresentationPatcher tests

* test: 100% coverage for patchers again

* feat: containers can be created with POST with no content-type

* feat: Immutable checks always with subject identifier

* feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header

* test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher

* feat: remove metadataGenerator from acl.json and fix tests accordingly

* WIP: preserve metadata on PUT

* feat: preserve metadata on PUT

* fix: keep metadata on PATCHes

* test: add unit tests for preserving metadata on PUT

* fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json)

* fix: add metadatastrategy to RepresentationConvertingStore in regex.json

* test: add integration tests for preserving metadata on PUT

* docs: update release notes and adding documentation about preserving metadata on PUT

* WIP: Template create setRepresentation

* fix: Move container exists and not allowed check to setRepresentation

* test: fix lint

* fix: update configs and documentation

* refactor: update and add documentation + small refactoring

* refactor: update and add documentation + small refactoring + fix tests

* fix: Dynamic pod config + tests

* fix: TemplatedResourcesGenerator does not create containers when they already exist

* fix: metadata preservation now deals with complex content types

* docs: explain the case when there is no content-type

* fix: minor comments
2022-08-04 15:24:36 +02:00

201 lines
6.6 KiB
TypeScript

import fetch from 'cross-fetch';
import { DataFactory } from 'n3';
import type { App } from '../../src/init/App';
import { deleteResource, expectQuads, getResource, patchResource, putResource } from '../util/FetchUtil';
import { getPort } from '../util/Util';
import {
getDefaultVariables,
getPresetConfigPath,
getTestConfigPath,
getTestFolder,
instantiateFromConfig,
removeFolder,
} from './Config';
const { namedNode, quad } = DataFactory;
const port = getPort('Conditions');
const baseUrl = `http://localhost:${port}/`;
// File stores handle last-modified dates differently so need to test both
const rootFilePath = getTestFolder('conditions');
const stores: [string, any][] = [
[ 'in-memory storage', {
storeConfig: 'storage/backend/memory.json',
teardown: jest.fn(),
}],
[ 'on-disk storage', {
storeConfig: 'storage/backend/file.json',
teardown: async(): Promise<void> => removeFolder(rootFilePath),
}],
];
describe.each(stores)('A server supporting conditions with %s', (name, { storeConfig, teardown }): void => {
let app: App;
beforeAll(async(): Promise<void> => {
const variables = {
...getDefaultVariables(port, baseUrl),
'urn:solid-server:default:variable:rootFilePath': rootFilePath,
};
// Create and start the server
const instances = await instantiateFromConfig(
'urn:solid-server:test:Instances',
[
getPresetConfigPath(storeConfig),
getTestConfigPath('ldp-with-auth.json'),
],
variables,
) as Record<string, any>;
({ app } = instances);
await app.start();
});
afterAll(async(): Promise<void> => {
await teardown();
await app.stop();
});
it('prevents operations on existing resources with "if-none-match: *" header.', async(): Promise<void> => {
const documentUrl = `${baseUrl}document1.txt`;
// PUT
await putResource(documentUrl, { contentType: 'text/plain', body: 'TESTFILE' });
// Overwrite fails because of header
let response = await fetch(documentUrl, {
method: 'PUT',
headers: { 'content-type': 'text/plain', 'if-none-match': '*' },
body: 'TESTFILE1',
});
expect(response.status).toBe(412);
// Verify original contents stayed the same
response = await getResource(documentUrl);
await expect(response.text()).resolves.toBe('TESTFILE');
// DELETE
expect(await deleteResource(documentUrl)).toBeUndefined();
});
it('prevents creating new resources with "if-match: *" header.', async(): Promise<void> => {
const documentUrl = `${baseUrl}document2.txt`;
const query = 'INSERT {<http://test.com/s1> <http://test.com/p1> <http://test.com/o1>} WHERE {}';
// PATCH fails because of header
let response = await fetch(documentUrl, {
method: 'PATCH',
headers: { 'content-type': 'application/sparql-update', 'if-match': '*' },
body: query,
});
expect(response.status).toBe(412);
// PUT
await patchResource(documentUrl, query, 'sparql');
// PUT with header now succeeds
const query2 = 'INSERT {<http://test.com/s2> <http://test.com/p2> <http://test.com/o2>} WHERE {}';
response = await fetch(documentUrl, {
method: 'PATCH',
headers: { 'content-type': 'application/sparql-update', 'if-match': '*' },
body: query2,
});
expect(response.status).toBe(205);
// Verify the contents got updated
response = await getResource(documentUrl);
const expected = [
quad(namedNode('http://test.com/s1'), namedNode('http://test.com/p1'), namedNode('http://test.com/o1')),
quad(namedNode('http://test.com/s2'), namedNode('http://test.com/p2'), namedNode('http://test.com/o2')),
];
await expectQuads(response, expected, true);
// DELETE
expect(await deleteResource(documentUrl)).toBeUndefined();
});
it('prevents operations if the "if-match" header does not match.', async(): Promise<void> => {
// GET root ETag
let response = await getResource(baseUrl);
const eTag = response.headers.get('ETag');
expect(typeof eTag).toBe('string');
// POST fails because of header
response = await fetch(baseUrl, {
method: 'POST',
headers: { 'content-type': 'text/plain', 'if-match': '"notAMatchingETag"' },
body: 'TESTFILE',
});
expect(response.status).toBe(412);
// POST succeeds with correct header
response = await fetch(baseUrl, {
method: 'POST',
headers: { 'content-type': 'text/plain', 'if-match': eTag! },
body: 'TESTFILE1',
});
expect(response.status).toBe(201);
const documentUrl = response.headers.get('location');
expect(typeof documentUrl).toBe('string');
// DELETE
expect(await deleteResource(documentUrl!)).toBeUndefined();
});
it('prevents operations if the "if-none-match" header does match.', async(): Promise<void> => {
// GET root ETag
let response = await getResource(baseUrl);
const eTag = response.headers.get('ETag');
expect(typeof eTag).toBe('string');
// POST fails because of header
response = await fetch(baseUrl, {
method: 'POST',
headers: { 'content-type': 'text/plain', 'if-none-match': eTag! },
body: 'TESTFILE',
});
expect(response.status).toBe(412);
// POST succeeds with correct header
response = await fetch(baseUrl, {
method: 'POST',
headers: { 'content-type': 'text/plain', 'if-none-match': '"notAMatchingETag"' },
body: 'TESTFILE1',
});
expect(response.status).toBe(201);
const documentUrl = response.headers.get('location');
expect(typeof documentUrl).toBe('string');
// DELETE
expect(await deleteResource(documentUrl!)).toBeUndefined();
});
it('prevents operations if the "if-unmodified-since" header is before the modified date.', async(): Promise<void> => {
const documentUrl = `${baseUrl}document3.txt`;
// PUT
let response = await putResource(documentUrl, { contentType: 'text/plain', body: 'TESTFILE' });
// GET last-modified header
response = await getResource(documentUrl);
const lastModifiedVal = response.headers.get('last-modified');
expect(typeof lastModifiedVal).toBe('string');
const lastModified = new Date(lastModifiedVal!);
const oldDate = new Date(Date.now() - 10000);
// DELETE fails because oldDate < lastModified
response = await fetch(documentUrl, {
method: 'DELETE',
headers: { 'if-unmodified-since': oldDate.toUTCString() },
});
expect(response.status).toBe(412);
// DELETE succeeds because lastModified date matches
response = await fetch(documentUrl, {
method: 'DELETE',
headers: { 'if-unmodified-since': lastModified.toUTCString() },
});
expect(response.status).toBe(205);
});
});