mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00

This allows easier reuse of certain reoccurring behaviours, such as authorization. The AuthenticatedLdpHandler is no longer required since it is a combination of parsing and authorization. This did require a small change to the OperationHandler interface.
223 lines
9.9 KiB
TypeScript
223 lines
9.9 KiB
TypeScript
import type { RegistrationManager,
|
|
RegistrationResponse } from '../../../../src/identity/interaction/email-password/util/RegistrationManager';
|
|
import type { Initializer } from '../../../../src/init/Initializer';
|
|
import type { SetupInput } from '../../../../src/init/setup/SetupHttpHandler';
|
|
import { SetupHttpHandler } from '../../../../src/init/setup/SetupHttpHandler';
|
|
import type { ErrorHandlerArgs, ErrorHandler } from '../../../../src/ldp/http/ErrorHandler';
|
|
import type { ResponseDescription } from '../../../../src/ldp/http/response/ResponseDescription';
|
|
import type { Operation } from '../../../../src/ldp/operations/Operation';
|
|
import { BasicRepresentation } from '../../../../src/ldp/representation/BasicRepresentation';
|
|
import type { Representation } from '../../../../src/ldp/representation/Representation';
|
|
import { RepresentationMetadata } from '../../../../src/ldp/representation/RepresentationMetadata';
|
|
import type { HttpRequest } from '../../../../src/server/HttpRequest';
|
|
import type { HttpResponse } from '../../../../src/server/HttpResponse';
|
|
import { getBestPreference } from '../../../../src/storage/conversion/ConversionUtil';
|
|
import type { RepresentationConverterArgs,
|
|
RepresentationConverter } from '../../../../src/storage/conversion/RepresentationConverter';
|
|
import type { KeyValueStorage } from '../../../../src/storage/keyvalue/KeyValueStorage';
|
|
import { APPLICATION_JSON } from '../../../../src/util/ContentTypes';
|
|
import type { HttpError } from '../../../../src/util/errors/HttpError';
|
|
import { InternalServerError } from '../../../../src/util/errors/InternalServerError';
|
|
import { MethodNotAllowedHttpError } from '../../../../src/util/errors/MethodNotAllowedHttpError';
|
|
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
|
|
import { guardedStreamFrom, readableToString } from '../../../../src/util/StreamUtil';
|
|
import { CONTENT_TYPE, SOLID_META } from '../../../../src/util/Vocabularies';
|
|
|
|
describe('A SetupHttpHandler', (): void => {
|
|
let request: HttpRequest;
|
|
const response: HttpResponse = {} as any;
|
|
let operation: Operation;
|
|
const viewTemplate = '/templates/view';
|
|
const responseTemplate = '/templates/response';
|
|
const storageKey = 'completed';
|
|
let details: RegistrationResponse;
|
|
let errorHandler: jest.Mocked<ErrorHandler>;
|
|
let registrationManager: jest.Mocked<RegistrationManager>;
|
|
let initializer: jest.Mocked<Initializer>;
|
|
let converter: jest.Mocked<RepresentationConverter>;
|
|
let storage: jest.Mocked<KeyValueStorage<string, any>>;
|
|
let handler: SetupHttpHandler;
|
|
|
|
beforeEach(async(): Promise<void> => {
|
|
operation = {
|
|
method: 'GET',
|
|
target: { path: 'http://test.com/setup' },
|
|
preferences: { type: { 'text/html': 1 }},
|
|
};
|
|
|
|
errorHandler = { handleSafe: jest.fn(({ error }: ErrorHandlerArgs): ResponseDescription => ({
|
|
statusCode: 400,
|
|
data: guardedStreamFrom(`{ "name": "${error.name}", "message": "${error.message}" }`),
|
|
})) } as any;
|
|
|
|
initializer = {
|
|
handleSafe: jest.fn(),
|
|
} as any;
|
|
|
|
details = {
|
|
email: 'alice@test.email',
|
|
createWebId: true,
|
|
register: true,
|
|
createPod: true,
|
|
};
|
|
|
|
registrationManager = {
|
|
validateInput: jest.fn((input): any => input),
|
|
register: jest.fn().mockResolvedValue(details),
|
|
} as any;
|
|
|
|
converter = {
|
|
handleSafe: jest.fn((input: RepresentationConverterArgs): Representation => {
|
|
// Just find the best match;
|
|
const type = getBestPreference(input.preferences.type!, { '*/*': 1 })!;
|
|
const metadata = new RepresentationMetadata(input.representation.metadata, { [CONTENT_TYPE]: type.value });
|
|
return new BasicRepresentation(input.representation.data, metadata);
|
|
}),
|
|
} as any;
|
|
|
|
storage = new Map<string, any>() as any;
|
|
|
|
handler = new SetupHttpHandler({
|
|
initializer,
|
|
registrationManager,
|
|
converter,
|
|
storageKey,
|
|
storage,
|
|
viewTemplate,
|
|
responseTemplate,
|
|
errorHandler,
|
|
});
|
|
});
|
|
|
|
// Since all tests check similar things, the test functionality is generalized in here
|
|
async function testPost(input: SetupInput, error?: HttpError): Promise<void> {
|
|
operation.method = 'POST';
|
|
const initialize = Boolean(input.initialize);
|
|
const registration = Boolean(input.registration);
|
|
const requestBody = { initialize, registration };
|
|
if (Object.keys(input).length > 0) {
|
|
operation.body = new BasicRepresentation(JSON.stringify(requestBody), 'application/json');
|
|
}
|
|
|
|
const result = await handler.handle({ operation, request, response });
|
|
expect(result).toBeDefined();
|
|
expect(initializer.handleSafe).toHaveBeenCalledTimes(!error && initialize ? 1 : 0);
|
|
expect(registrationManager.validateInput).toHaveBeenCalledTimes(!error && registration ? 1 : 0);
|
|
expect(registrationManager.register).toHaveBeenCalledTimes(!error && registration ? 1 : 0);
|
|
let expectedResult: any = { initialize, registration };
|
|
if (error) {
|
|
expectedResult = { name: error.name, message: error.message };
|
|
} else if (registration) {
|
|
Object.assign(expectedResult, details);
|
|
}
|
|
expect(JSON.parse(await readableToString(result.data!))).toEqual(expectedResult);
|
|
expect(result.statusCode).toBe(error?.statusCode ?? 200);
|
|
expect(result.metadata?.contentType).toBe('text/html');
|
|
expect(result.metadata?.get(SOLID_META.template)?.value).toBe(error ? viewTemplate : responseTemplate);
|
|
|
|
if (!error && registration) {
|
|
expect(registrationManager.validateInput).toHaveBeenLastCalledWith(requestBody, true);
|
|
expect(registrationManager.register).toHaveBeenLastCalledWith(requestBody, true);
|
|
}
|
|
}
|
|
|
|
it('returns the view template on GET requests.', async(): Promise<void> => {
|
|
const result = await handler.handle({ operation, request, response });
|
|
expect(result).toBeDefined();
|
|
expect(JSON.parse(await readableToString(result.data!))).toEqual({});
|
|
expect(result.statusCode).toBe(200);
|
|
expect(result.metadata?.contentType).toBe('text/html');
|
|
expect(result.metadata?.get(SOLID_META.template)?.value).toBe(viewTemplate);
|
|
|
|
// Setup is still enabled since this was a GET request
|
|
expect(storage.get(storageKey)).toBeUndefined();
|
|
});
|
|
|
|
it('simply disables the handler if no setup is requested.', async(): Promise<void> => {
|
|
await expect(testPost({ initialize: false, registration: false })).resolves.toBeUndefined();
|
|
|
|
// Handler is now disabled due to successful POST
|
|
expect(storage.get(storageKey)).toBe(true);
|
|
});
|
|
|
|
it('defaults to an empty body if there is none.', async(): Promise<void> => {
|
|
await expect(testPost({})).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('calls the initializer when requested.', async(): Promise<void> => {
|
|
await expect(testPost({ initialize: true, registration: false })).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('calls the registrationManager when requested.', async(): Promise<void> => {
|
|
await expect(testPost({ initialize: false, registration: true })).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('converts non-HTTP errors to internal errors.', async(): Promise<void> => {
|
|
converter.handleSafe.mockRejectedValueOnce(new Error('bad data'));
|
|
const error = new InternalServerError('bad data');
|
|
await expect(testPost({ initialize: true, registration: false }, error)).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('errors on non-GET/POST requests.', async(): Promise<void> => {
|
|
operation.method = 'PUT';
|
|
const requestBody = { initialize: true, registration: true };
|
|
operation.body = new BasicRepresentation(JSON.stringify(requestBody), 'application/json');
|
|
const error = new MethodNotAllowedHttpError();
|
|
|
|
const result = await handler.handle({ operation, request, response });
|
|
expect(result).toBeDefined();
|
|
expect(initializer.handleSafe).toHaveBeenCalledTimes(0);
|
|
expect(registrationManager.register).toHaveBeenCalledTimes(0);
|
|
expect(errorHandler.handleSafe).toHaveBeenCalledTimes(1);
|
|
expect(errorHandler.handleSafe).toHaveBeenLastCalledWith({ error, preferences: { type: { [APPLICATION_JSON]: 1 }}});
|
|
|
|
expect(JSON.parse(await readableToString(result.data!))).toEqual({ name: error.name, message: error.message });
|
|
expect(result.statusCode).toBe(405);
|
|
expect(result.metadata?.contentType).toBe('text/html');
|
|
expect(result.metadata?.get(SOLID_META.template)?.value).toBe(viewTemplate);
|
|
|
|
// Setup is not disabled since there was an error
|
|
expect(storage.get(storageKey)).toBeUndefined();
|
|
});
|
|
|
|
it('errors when attempting registration when no RegistrationManager is defined.', async(): Promise<void> => {
|
|
handler = new SetupHttpHandler({
|
|
errorHandler,
|
|
initializer,
|
|
converter,
|
|
storageKey,
|
|
storage,
|
|
viewTemplate,
|
|
responseTemplate,
|
|
});
|
|
operation.method = 'POST';
|
|
const requestBody = { initialize: false, registration: true };
|
|
operation.body = new BasicRepresentation(JSON.stringify(requestBody), 'application/json');
|
|
const error = new NotImplementedHttpError('This server is not configured to support registration during setup.');
|
|
await expect(testPost({ initialize: false, registration: true }, error)).resolves.toBeUndefined();
|
|
|
|
// Setup is not disabled since there was an error
|
|
expect(storage.get(storageKey)).toBeUndefined();
|
|
});
|
|
|
|
it('errors when attempting initialization when no Initializer is defined.', async(): Promise<void> => {
|
|
handler = new SetupHttpHandler({
|
|
errorHandler,
|
|
registrationManager,
|
|
converter,
|
|
storageKey,
|
|
storage,
|
|
viewTemplate,
|
|
responseTemplate,
|
|
});
|
|
operation.method = 'POST';
|
|
const requestBody = { initialize: true, registration: false };
|
|
operation.body = new BasicRepresentation(JSON.stringify(requestBody), 'application/json');
|
|
const error = new NotImplementedHttpError('This server is not configured with a setup initializer.');
|
|
await expect(testPost({ initialize: true, registration: false }, error)).resolves.toBeUndefined();
|
|
|
|
// Setup is not disabled since there was an error
|
|
expect(storage.get(storageKey)).toBeUndefined();
|
|
});
|
|
});
|