mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00

* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available * fix: remove unnecesary log at POST * feat: PUT resets metadata contents + not possible to add metadata with PUT to container * feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers * feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata * test: add unit tests to operationhandlers to handle metadata editing * test: add unit tests to representationPatchHandler to handle metadata editing * fix: update dependency of meta.json to version 3.0.0 * fix: lint and dependency still v2 * fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic * fix: moved checking metadata resources checking from DELETE and POST handler down to DABS * fix: remove PATCH message about metadata extension * fix: move PATCH message about metadata extension * WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1) * WIP: implement writeMetadata in memorybackend + change resourceExists * WIP: implement writeMetadata in SparqlDataAccessor.ts * test: fix test interfaces * test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier) * test: accessor tests implemented for metadata * test: add RdfImmutableCheckPatcher.test.ts * test: add tests in DataAccessorBasedStore.test.ts * test: fix template config for DynamicPods test * test: add integration tests for metadata * fix: change metaStrategy to metadataStrategy * refactor: comments updated to new location CSS on github + some alphabetical edits * refactor: remove getMetadata function in DABS as it is only used once * refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts * docs: modify documentation for writeMetadata function in DataAccessor.ts * feat: ldp:contains is also part of the metadata resource of a container * refactor: change function name and move check to DataAccessorBasedStore * fix: fix tests for DABS and PutOperationHandler * feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher * test: fix patcher tests * feat: create sparqlInsertMetadata in SparqlDataAccessor.ts * fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR * test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit * test: add converter to DABS and replace rejection on data during container creation to warning * test: implemented RdfPatcher test * feat: remove ContainerPatcher * fix: fix lint * fix: fix integration tests * refactor: fix minor issues mentioned in the PR * WIP: problem with removeResponseMetadata * refactor: remove responseMetadata in QuadToRdfConverter.ts * feat: handle ResponeMetadata when writing to the store via a patch * refactor: refactor based on comments in PR * feat: make ImmutableMetadataPatcher.ts instantiation more clear * test: achieve 100% coverage again * fix: fix lint * refactor: return to explicit arguments for the DABS * fix: return to explicit arguments for the DABS (missed one) * feat: optimise immutable checker * fix: fix, enhance docs + optimise config files * fix: DABS + QuadToRdfConverter feedback implemented * fix: patching feedback implemented * test: update operationhandler tests * test: update integration tests after feedback * test: update DABS tests after feedback * test: update ImmutableMetadataPatcher.test.ts after feedback * test: update patch tests after feedback * docs: add documentation about editing metadata * fix: config: intendation + name change + extra filters | filter pattern * docs: tsdoc added to RdfStorePatcher.ts * fix: DABS split implemented for getRepresentation + comment refactoring * docs: further documentation on removing response data on serialization * fix: DABS getRepresentation method * docs: apply feedback from Joachim on the documentation of metadata-editing.md * fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim * docs: small fix in metadata-editing.md documentation after feedback from Joachim * fix: fix metadata-editing.md documentation after feedback from Joachim * fix: fix tests meta-editing after feedback Joachim * feat: first attempt at RELEASE_NOTES.md * docs: update release notes based on feedback * docs: fix newline * fix: patching config changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * feat: optimisation on ImmutableMetadataPatcher.ts algorithm * feat: remove converter from DABS and add conversion for metadata resources in the RCS * fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore * feat: make RepresentationPatcher generic * test: generic RepresentationPatcher tests * test: 100% coverage for patchers again * feat: containers can be created with POST with no content-type * feat: Immutable checks always with subject identifier * feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header * test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher * feat: remove metadataGenerator from acl.json and fix tests accordingly * WIP: preserve metadata on PUT * feat: preserve metadata on PUT * fix: keep metadata on PATCHes * test: add unit tests for preserving metadata on PUT * fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json) * fix: add metadatastrategy to RepresentationConvertingStore in regex.json * test: add integration tests for preserving metadata on PUT * docs: update release notes and adding documentation about preserving metadata on PUT * WIP: Template create setRepresentation * fix: Move container exists and not allowed check to setRepresentation * test: fix lint * fix: update configs and documentation * refactor: update and add documentation + small refactoring * refactor: update and add documentation + small refactoring + fix tests * fix: Dynamic pod config + tests * fix: TemplatedResourcesGenerator does not create containers when they already exist * fix: metadata preservation now deals with complex content types * docs: explain the case when there is no content-type * fix: minor comments
155 lines
6.3 KiB
TypeScript
155 lines
6.3 KiB
TypeScript
import { DataFactory } from 'n3';
|
|
import rdfSerializer from 'rdf-serialize';
|
|
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
|
|
import type { Representation } from '../../../../src/http/representation/Representation';
|
|
import { RepresentationMetadata } from '../../../../src/http/representation/RepresentationMetadata';
|
|
import type { RepresentationPreferences } from '../../../../src/http/representation/RepresentationPreferences';
|
|
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
|
|
import { QuadToRdfConverter } from '../../../../src/storage/conversion/QuadToRdfConverter';
|
|
import { INTERNAL_QUADS } from '../../../../src/util/ContentTypes';
|
|
import { readableToString } from '../../../../src/util/StreamUtil';
|
|
import { DC, PREFERRED_PREFIX_TERM, SOLID_META } from '../../../../src/util/Vocabularies';
|
|
import quad = DataFactory.quad;
|
|
const { namedNode, triple } = DataFactory;
|
|
|
|
describe('A QuadToRdfConverter', (): void => {
|
|
const converter = new QuadToRdfConverter();
|
|
const identifier: ResourceIdentifier = { path: 'http://example.org/foo/bar/' };
|
|
let metadata: RepresentationMetadata;
|
|
|
|
beforeEach((): void => {
|
|
metadata = new RepresentationMetadata(identifier, INTERNAL_QUADS);
|
|
});
|
|
|
|
it('defaults to rdfSerializer preferences when given no output preferences.', async(): Promise<void> => {
|
|
await expect(new QuadToRdfConverter().getOutputTypes(INTERNAL_QUADS))
|
|
.resolves.toEqual(await rdfSerializer.getContentTypesPrioritized());
|
|
});
|
|
|
|
it('supports overriding output preferences.', async(): Promise<void> => {
|
|
const outputPreferences = { 'text/turtle': 1 };
|
|
await expect(new QuadToRdfConverter({ outputPreferences }).getOutputTypes(INTERNAL_QUADS))
|
|
.resolves.toEqual(outputPreferences);
|
|
});
|
|
|
|
it('can handle quad to Turtle conversions.', async(): Promise<void> => {
|
|
const representation = { metadata } as Representation;
|
|
const preferences: RepresentationPreferences = { type: { 'text/turtle': 1 }};
|
|
await expect(converter.canHandle({ identifier, representation, preferences })).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('can handle quad to JSON-LD conversions.', async(): Promise<void> => {
|
|
const representation = { metadata } as Representation;
|
|
const preferences: RepresentationPreferences = { type: { 'application/ld+json': 1 }};
|
|
await expect(converter.canHandle({ identifier, representation, preferences })).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('converts quads to Turtle.', async(): Promise<void> => {
|
|
const representation = new BasicRepresentation([ triple(
|
|
namedNode('http://test.com/s'),
|
|
namedNode('http://test.com/p'),
|
|
namedNode('http://test.com/o'),
|
|
) ],
|
|
metadata);
|
|
const preferences: RepresentationPreferences = { type: { 'text/turtle': 1 }};
|
|
const result = await converter.handle({ identifier, representation, preferences });
|
|
expect(result).toMatchObject({
|
|
binary: true,
|
|
metadata: expect.any(RepresentationMetadata),
|
|
});
|
|
expect(result.metadata.contentType).toBe('text/turtle');
|
|
await expect(readableToString(result.data)).resolves.toBe(
|
|
`<http://test.com/s> <http://test.com/p> <http://test.com/o>.
|
|
`,
|
|
);
|
|
});
|
|
|
|
it('converts quads with prefixes to Turtle.', async(): Promise<void> => {
|
|
metadata.addQuad(DC.terms.namespace, PREFERRED_PREFIX_TERM, 'dc');
|
|
metadata.addQuad('http://test.com/', PREFERRED_PREFIX_TERM, 'test');
|
|
const representation = new BasicRepresentation([ triple(
|
|
namedNode('http://test.com/s'),
|
|
DC.terms.modified,
|
|
namedNode('http://test.com/o'),
|
|
) ],
|
|
metadata);
|
|
const preferences: RepresentationPreferences = { type: { 'text/turtle': 1 }};
|
|
const result = await converter.handle({ identifier, representation, preferences });
|
|
expect(result.metadata.contentType).toBe('text/turtle');
|
|
await expect(readableToString(result.data)).resolves.toBe(
|
|
`@prefix dc: <http://purl.org/dc/terms/>.
|
|
@prefix test: <http://test.com/>.
|
|
|
|
test:s dc:modified test:o.
|
|
`,
|
|
);
|
|
});
|
|
|
|
it('uses the base IRI when converting quads to Turtle.', async(): Promise<void> => {
|
|
const representation = new BasicRepresentation([ triple(
|
|
namedNode('http://example.org/foo/bar/'),
|
|
namedNode('http://example.org/foo/bar/#abc'),
|
|
namedNode('http://example.org/foo/bar/def/ghi'),
|
|
) ],
|
|
metadata);
|
|
const preferences: RepresentationPreferences = { type: { 'text/turtle': 1 }};
|
|
const result = await converter.handle({ identifier, representation, preferences });
|
|
expect(result.metadata.contentType).toBe('text/turtle');
|
|
await expect(readableToString(result.data)).resolves.toBe(
|
|
`<> <#abc> <def/ghi>.
|
|
`,
|
|
);
|
|
});
|
|
|
|
it('converts quads to JSON-LD.', async(): Promise<void> => {
|
|
metadata.contentType = INTERNAL_QUADS;
|
|
const representation = new BasicRepresentation([ triple(
|
|
namedNode('http://test.com/s'),
|
|
namedNode('http://test.com/p'),
|
|
namedNode('http://test.com/o'),
|
|
) ],
|
|
metadata);
|
|
const preferences: RepresentationPreferences = { type: { 'application/ld+json': 1 }};
|
|
const result = await converter.handle({ identifier, representation, preferences });
|
|
expect(result).toMatchObject({
|
|
binary: true,
|
|
metadata: expect.any(RepresentationMetadata),
|
|
});
|
|
expect(result.metadata.contentType).toBe('application/ld+json');
|
|
await expect(readableToString(result.data)).resolves.toBe(
|
|
`[
|
|
{
|
|
"@id": "http://test.com/s",
|
|
"http://test.com/p": [
|
|
{
|
|
"@id": "http://test.com/o"
|
|
}
|
|
]
|
|
}
|
|
]
|
|
`,
|
|
);
|
|
});
|
|
|
|
it('converts quads in the ResponseMetadata graph to the default graph.', async(): Promise<void> => {
|
|
const representation = new BasicRepresentation([ quad(
|
|
namedNode('http://test.com/s'),
|
|
namedNode('http://test.com/p'),
|
|
namedNode('http://test.com/o'),
|
|
SOLID_META.terms.ResponseMetadata,
|
|
) ],
|
|
metadata);
|
|
const preferences: RepresentationPreferences = { type: { 'text/turtle': 1 }};
|
|
const result = await converter.handle({ identifier, representation, preferences });
|
|
expect(result).toMatchObject({
|
|
binary: true,
|
|
metadata: expect.any(RepresentationMetadata),
|
|
});
|
|
expect(result.metadata.contentType).toBe('text/turtle');
|
|
await expect(readableToString(result.data)).resolves.toBe(
|
|
`<http://test.com/s> <http://test.com/p> <http://test.com/o>.
|
|
`,
|
|
);
|
|
});
|
|
});
|