mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00

* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available * fix: remove unnecesary log at POST * feat: PUT resets metadata contents + not possible to add metadata with PUT to container * feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers * feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata * test: add unit tests to operationhandlers to handle metadata editing * test: add unit tests to representationPatchHandler to handle metadata editing * fix: update dependency of meta.json to version 3.0.0 * fix: lint and dependency still v2 * fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic * fix: moved checking metadata resources checking from DELETE and POST handler down to DABS * fix: remove PATCH message about metadata extension * fix: move PATCH message about metadata extension * WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1) * WIP: implement writeMetadata in memorybackend + change resourceExists * WIP: implement writeMetadata in SparqlDataAccessor.ts * test: fix test interfaces * test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier) * test: accessor tests implemented for metadata * test: add RdfImmutableCheckPatcher.test.ts * test: add tests in DataAccessorBasedStore.test.ts * test: fix template config for DynamicPods test * test: add integration tests for metadata * fix: change metaStrategy to metadataStrategy * refactor: comments updated to new location CSS on github + some alphabetical edits * refactor: remove getMetadata function in DABS as it is only used once * refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts * docs: modify documentation for writeMetadata function in DataAccessor.ts * feat: ldp:contains is also part of the metadata resource of a container * refactor: change function name and move check to DataAccessorBasedStore * fix: fix tests for DABS and PutOperationHandler * feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher * test: fix patcher tests * feat: create sparqlInsertMetadata in SparqlDataAccessor.ts * fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR * test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit * test: add converter to DABS and replace rejection on data during container creation to warning * test: implemented RdfPatcher test * feat: remove ContainerPatcher * fix: fix lint * fix: fix integration tests * refactor: fix minor issues mentioned in the PR * WIP: problem with removeResponseMetadata * refactor: remove responseMetadata in QuadToRdfConverter.ts * feat: handle ResponeMetadata when writing to the store via a patch * refactor: refactor based on comments in PR * feat: make ImmutableMetadataPatcher.ts instantiation more clear * test: achieve 100% coverage again * fix: fix lint * refactor: return to explicit arguments for the DABS * fix: return to explicit arguments for the DABS (missed one) * feat: optimise immutable checker * fix: fix, enhance docs + optimise config files * fix: DABS + QuadToRdfConverter feedback implemented * fix: patching feedback implemented * test: update operationhandler tests * test: update integration tests after feedback * test: update DABS tests after feedback * test: update ImmutableMetadataPatcher.test.ts after feedback * test: update patch tests after feedback * docs: add documentation about editing metadata * fix: config: intendation + name change + extra filters | filter pattern * docs: tsdoc added to RdfStorePatcher.ts * fix: DABS split implemented for getRepresentation + comment refactoring * docs: further documentation on removing response data on serialization * fix: DABS getRepresentation method * docs: apply feedback from Joachim on the documentation of metadata-editing.md * fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim * docs: small fix in metadata-editing.md documentation after feedback from Joachim * fix: fix metadata-editing.md documentation after feedback from Joachim * fix: fix tests meta-editing after feedback Joachim * feat: first attempt at RELEASE_NOTES.md * docs: update release notes based on feedback * docs: fix newline * fix: patching config changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * feat: optimisation on ImmutableMetadataPatcher.ts algorithm * feat: remove converter from DABS and add conversion for metadata resources in the RCS * fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore * feat: make RepresentationPatcher generic * test: generic RepresentationPatcher tests * test: 100% coverage for patchers again * feat: containers can be created with POST with no content-type * feat: Immutable checks always with subject identifier * feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header * test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher * feat: remove metadataGenerator from acl.json and fix tests accordingly * WIP: preserve metadata on PUT * feat: preserve metadata on PUT * fix: keep metadata on PATCHes * test: add unit tests for preserving metadata on PUT * fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json) * fix: add metadatastrategy to RepresentationConvertingStore in regex.json * test: add integration tests for preserving metadata on PUT * docs: update release notes and adding documentation about preserving metadata on PUT * WIP: Template create setRepresentation * fix: Move container exists and not allowed check to setRepresentation * test: fix lint * fix: update configs and documentation * refactor: update and add documentation + small refactoring * refactor: update and add documentation + small refactoring + fix tests * fix: Dynamic pod config + tests * fix: TemplatedResourcesGenerator does not create containers when they already exist * fix: metadata preservation now deals with complex content types * docs: explain the case when there is no content-type * fix: minor comments
131 lines
5.3 KiB
TypeScript
131 lines
5.3 KiB
TypeScript
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
|
|
import type { Patch } from '../../../../src/http/representation/Patch';
|
|
import type { Representation } from '../../../../src/http/representation/Representation';
|
|
import type { ResourceIdentifier } from '../../../../src/http/representation/ResourceIdentifier';
|
|
import type {
|
|
RepresentationConverter,
|
|
RepresentationConverterArgs,
|
|
} from '../../../../src/storage/conversion/RepresentationConverter';
|
|
import { ConvertingPatcher } from '../../../../src/storage/patch/ConvertingPatcher';
|
|
import type {
|
|
RepresentationPatcher,
|
|
RepresentationPatcherInput,
|
|
} from '../../../../src/storage/patch/RepresentationPatcher';
|
|
|
|
describe('A ConvertingPatcher', (): void => {
|
|
const intermediateType = 'internal/quads';
|
|
const defaultType = 'text/turtle';
|
|
const identifier: ResourceIdentifier = { path: 'http://test.com/foo' };
|
|
const patch: Patch = new BasicRepresentation([], 'type/patch');
|
|
const representation = new BasicRepresentation([], 'application/trig');
|
|
const patchResult = new BasicRepresentation([], 'internal/quads');
|
|
let args: RepresentationPatcherInput<Representation>;
|
|
let converter: jest.Mocked<RepresentationConverter>;
|
|
let patcher: jest.Mocked<RepresentationPatcher<Representation>>;
|
|
let convertingPatcher: ConvertingPatcher;
|
|
|
|
beforeEach(async(): Promise<void> => {
|
|
args = { patch, identifier, representation };
|
|
|
|
converter = {
|
|
canHandle: jest.fn(),
|
|
handle: jest.fn(async({ preferences }: RepresentationConverterArgs): Promise<any> =>
|
|
new BasicRepresentation('converted', Object.keys(preferences.type!)[0])),
|
|
} as any;
|
|
|
|
patcher = {
|
|
canHandle: jest.fn(),
|
|
handle: jest.fn().mockResolvedValue(patchResult),
|
|
} as any;
|
|
|
|
convertingPatcher = new ConvertingPatcher(patcher, converter, intermediateType, defaultType);
|
|
});
|
|
|
|
it('rejects requests the converter cannot handle.', async(): Promise<void> => {
|
|
converter.canHandle.mockRejectedValueOnce(new Error('unsupported type'));
|
|
await expect(convertingPatcher.canHandle(args)).rejects.toThrow('unsupported type');
|
|
});
|
|
|
|
it('checks if the patcher can handle the input if there is no representation.', async(): Promise<void> => {
|
|
delete args.representation;
|
|
|
|
await expect(convertingPatcher.canHandle(args)).resolves.toBeUndefined();
|
|
|
|
patcher.canHandle.mockRejectedValueOnce(new Error('unsupported patch'));
|
|
await expect(convertingPatcher.canHandle(args)).rejects.toThrow('unsupported patch');
|
|
});
|
|
|
|
it('sends a mock representation with the correct type to the patcher to check support.', async(): Promise<void> => {
|
|
await expect(convertingPatcher.canHandle(args)).resolves.toBeUndefined();
|
|
expect(patcher.canHandle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.canHandle.mock.calls[0][0].representation?.metadata.contentType).toBe(intermediateType);
|
|
});
|
|
|
|
it('converts the representation before calling the patcher.', async(): Promise<void> => {
|
|
const result = await convertingPatcher.handle(args);
|
|
expect(result.metadata.contentType).toBe('application/trig');
|
|
|
|
// Convert input
|
|
expect(converter.handle).toHaveBeenCalledTimes(2);
|
|
expect(converter.handle).toHaveBeenCalledWith({
|
|
representation,
|
|
identifier,
|
|
preferences: { type: { [intermediateType]: 1 }},
|
|
});
|
|
|
|
// Patch
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle)
|
|
.toHaveBeenLastCalledWith({ ...args, representation: await converter.handle.mock.results[0].value });
|
|
|
|
// Convert back
|
|
expect(converter.handle).toHaveBeenLastCalledWith({
|
|
representation: patchResult,
|
|
identifier,
|
|
preferences: { type: { 'application/trig': 1 }},
|
|
});
|
|
});
|
|
|
|
it('expects the patcher to create a new representation if there is none.', async(): Promise<void> => {
|
|
delete args.representation;
|
|
|
|
const result = await convertingPatcher.handle(args);
|
|
expect(result.metadata.contentType).toBe(defaultType);
|
|
|
|
// Patch
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(args);
|
|
|
|
// Convert new Representation to default type
|
|
expect(converter.handle).toHaveBeenCalledTimes(1);
|
|
expect(converter.handle).toHaveBeenLastCalledWith({
|
|
representation: patchResult,
|
|
identifier,
|
|
preferences: { type: { [defaultType]: 1 }},
|
|
});
|
|
});
|
|
|
|
it('does no conversion if there is no intermediate type.', async(): Promise<void> => {
|
|
convertingPatcher = new ConvertingPatcher(patcher, converter);
|
|
const result = await convertingPatcher.handle(args);
|
|
expect(result.metadata.contentType).toBe(patchResult.metadata.contentType);
|
|
|
|
// Patch
|
|
expect(converter.handle).toHaveBeenCalledTimes(0);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(args);
|
|
});
|
|
|
|
it('does not convert to a default type if there is none.', async(): Promise<void> => {
|
|
delete args.representation;
|
|
convertingPatcher = new ConvertingPatcher(patcher, converter);
|
|
const result = await convertingPatcher.handle(args);
|
|
expect(result.metadata.contentType).toBe(patchResult.metadata.contentType);
|
|
|
|
// Patch
|
|
expect(converter.handle).toHaveBeenCalledTimes(0);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(args);
|
|
});
|
|
});
|