mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00

* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available * fix: remove unnecesary log at POST * feat: PUT resets metadata contents + not possible to add metadata with PUT to container * feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers * feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata * test: add unit tests to operationhandlers to handle metadata editing * test: add unit tests to representationPatchHandler to handle metadata editing * fix: update dependency of meta.json to version 3.0.0 * fix: lint and dependency still v2 * fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic * fix: moved checking metadata resources checking from DELETE and POST handler down to DABS * fix: remove PATCH message about metadata extension * fix: move PATCH message about metadata extension * WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1) * WIP: implement writeMetadata in memorybackend + change resourceExists * WIP: implement writeMetadata in SparqlDataAccessor.ts * test: fix test interfaces * test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier) * test: accessor tests implemented for metadata * test: add RdfImmutableCheckPatcher.test.ts * test: add tests in DataAccessorBasedStore.test.ts * test: fix template config for DynamicPods test * test: add integration tests for metadata * fix: change metaStrategy to metadataStrategy * refactor: comments updated to new location CSS on github + some alphabetical edits * refactor: remove getMetadata function in DABS as it is only used once * refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts * docs: modify documentation for writeMetadata function in DataAccessor.ts * feat: ldp:contains is also part of the metadata resource of a container * refactor: change function name and move check to DataAccessorBasedStore * fix: fix tests for DABS and PutOperationHandler * feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher * test: fix patcher tests * feat: create sparqlInsertMetadata in SparqlDataAccessor.ts * fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR * test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit * test: add converter to DABS and replace rejection on data during container creation to warning * test: implemented RdfPatcher test * feat: remove ContainerPatcher * fix: fix lint * fix: fix integration tests * refactor: fix minor issues mentioned in the PR * WIP: problem with removeResponseMetadata * refactor: remove responseMetadata in QuadToRdfConverter.ts * feat: handle ResponeMetadata when writing to the store via a patch * refactor: refactor based on comments in PR * feat: make ImmutableMetadataPatcher.ts instantiation more clear * test: achieve 100% coverage again * fix: fix lint * refactor: return to explicit arguments for the DABS * fix: return to explicit arguments for the DABS (missed one) * feat: optimise immutable checker * fix: fix, enhance docs + optimise config files * fix: DABS + QuadToRdfConverter feedback implemented * fix: patching feedback implemented * test: update operationhandler tests * test: update integration tests after feedback * test: update DABS tests after feedback * test: update ImmutableMetadataPatcher.test.ts after feedback * test: update patch tests after feedback * docs: add documentation about editing metadata * fix: config: intendation + name change + extra filters | filter pattern * docs: tsdoc added to RdfStorePatcher.ts * fix: DABS split implemented for getRepresentation + comment refactoring * docs: further documentation on removing response data on serialization * fix: DABS getRepresentation method * docs: apply feedback from Joachim on the documentation of metadata-editing.md * fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim * docs: small fix in metadata-editing.md documentation after feedback from Joachim * fix: fix metadata-editing.md documentation after feedback from Joachim * fix: fix tests meta-editing after feedback Joachim * feat: first attempt at RELEASE_NOTES.md * docs: update release notes based on feedback * docs: fix newline * fix: patching config changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * feat: optimisation on ImmutableMetadataPatcher.ts algorithm * feat: remove converter from DABS and add conversion for metadata resources in the RCS * fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore * feat: make RepresentationPatcher generic * test: generic RepresentationPatcher tests * test: 100% coverage for patchers again * feat: containers can be created with POST with no content-type * feat: Immutable checks always with subject identifier * feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header * test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher * feat: remove metadataGenerator from acl.json and fix tests accordingly * WIP: preserve metadata on PUT * feat: preserve metadata on PUT * fix: keep metadata on PATCHes * test: add unit tests for preserving metadata on PUT * fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json) * fix: add metadatastrategy to RepresentationConvertingStore in regex.json * test: add integration tests for preserving metadata on PUT * docs: update release notes and adding documentation about preserving metadata on PUT * WIP: Template create setRepresentation * fix: Move container exists and not allowed check to setRepresentation * test: fix lint * fix: update configs and documentation * refactor: update and add documentation + small refactoring * refactor: update and add documentation + small refactoring + fix tests * fix: Dynamic pod config + tests * fix: TemplatedResourcesGenerator does not create containers when they already exist * fix: metadata preservation now deals with complex content types * docs: explain the case when there is no content-type * fix: minor comments
196 lines
8.6 KiB
TypeScript
196 lines
8.6 KiB
TypeScript
import { DataFactory, Store } from 'n3';
|
|
import { BasicRepresentation } from '../../../../src/http/representation/BasicRepresentation';
|
|
import type { Patch } from '../../../../src/http/representation/Patch';
|
|
import type { RdfDatasetRepresentation } from '../../../../src/http/representation/RdfDatasetRepresentation';
|
|
import { RepresentationMetadata } from '../../../../src/http/representation/RepresentationMetadata';
|
|
import { ImmutableMetadataPatcher } from '../../../../src/storage/patch/ImmutableMetadataPatcher';
|
|
import type { RepresentationPatcherInput } from '../../../../src/storage/patch/RepresentationPatcher';
|
|
import type { SparqlUpdatePatcher } from '../../../../src/storage/patch/SparqlUpdatePatcher';
|
|
import { ConflictHttpError } from '../../../../src/util/errors/ConflictHttpError';
|
|
import { InternalServerError } from '../../../../src/util/errors/InternalServerError';
|
|
import { NotImplementedHttpError } from '../../../../src/util/errors/NotImplementedHttpError';
|
|
import { FilterPattern } from '../../../../src/util/QuadUtil';
|
|
import { guardedStreamFrom } from '../../../../src/util/StreamUtil';
|
|
import { SimpleSuffixStrategy } from '../../../util/SimpleSuffixStrategy';
|
|
import 'jest-rdf';
|
|
const { namedNode, quad } = DataFactory;
|
|
|
|
function getPatch(): Patch {
|
|
const prefixedQuery = `This is a valid patch query`;
|
|
return {
|
|
data: guardedStreamFrom(prefixedQuery),
|
|
metadata: new RepresentationMetadata(),
|
|
binary: true,
|
|
isEmpty: false,
|
|
};
|
|
}
|
|
|
|
describe('A ImmutableMetadataPatcher', (): void => {
|
|
const base = 'http://test.com/';
|
|
const identifier = { path: 'http://test.com/foo' };
|
|
const metaIdentifier = { path: 'http://test.com/foo.meta' };
|
|
|
|
let patch: Patch;
|
|
let patcher: SparqlUpdatePatcher;
|
|
let handler: ImmutableMetadataPatcher;
|
|
let metaStrategy: SimpleSuffixStrategy;
|
|
let store: Store;
|
|
let input: RepresentationPatcherInput<RdfDatasetRepresentation>;
|
|
let representation: RdfDatasetRepresentation;
|
|
|
|
beforeEach(async(): Promise<void> => {
|
|
patcher = {
|
|
canHandle: jest.fn(),
|
|
handle: jest.fn(async(patcherInput: RepresentationPatcherInput<RdfDatasetRepresentation>):
|
|
Promise<RdfDatasetRepresentation> => {
|
|
const patcherStore = new Store([
|
|
quad(namedNode(`${base}foo`), namedNode(`${base}p`), namedNode(`${base}o`)) ]);
|
|
patcherInput.representation!.dataset = patcherStore;
|
|
return patcherInput.representation!;
|
|
}),
|
|
} as any;
|
|
metaStrategy = new SimpleSuffixStrategy('.meta');
|
|
store = new Store();
|
|
patch = getPatch();
|
|
representation = new BasicRepresentation() as RdfDatasetRepresentation;
|
|
representation.dataset = store;
|
|
|
|
input = { representation, patch, identifier: metaIdentifier };
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(`${base}foo`, `${base}b`, `${base}c`),
|
|
]);
|
|
});
|
|
|
|
it('throws an error when trying to handle a non metadata resource identifier.', async(): Promise<void> => {
|
|
input.identifier = identifier;
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(NotImplementedHttpError);
|
|
});
|
|
|
|
it('throws an error when no representation is given as input.', async(): Promise<void> => {
|
|
input.representation = undefined;
|
|
await expect(handler.handle(input)).rejects.toThrow(InternalServerError);
|
|
});
|
|
|
|
it('handles patches if they do not change immutable metadata.', async(): Promise<void> => {
|
|
const result = await handler.handleSafe(input);
|
|
expect(result.dataset).toBeRdfIsomorphic([
|
|
quad(namedNode(`${base}foo`), namedNode(`${base}p`), namedNode(`${base}o`)),
|
|
]);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('handles patches if there are no immutable patterns.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [ ]);
|
|
|
|
const result = await handler.handleSafe(input);
|
|
expect(result.dataset).toBeRdfIsomorphic([
|
|
quad(namedNode(`${base}foo`), namedNode(`${base}p`), namedNode(`${base}o`)),
|
|
]);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that change immutable triples based on subject alone.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(`${base}foo`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that change immutable triples based on predicate alone.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(undefined, `${base}p`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that change immutable triples based on object alone.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(undefined, undefined, `${base}o`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that change immutable triples based on predicate and object.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(undefined, `${base}p`, `${base}o`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('handles patches that changes triples where only a part is immutable.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(undefined, `${base}p`, `${base}o`),
|
|
]);
|
|
patcher.handle = jest.fn(async(patcherInput: RepresentationPatcherInput<RdfDatasetRepresentation>):
|
|
Promise<RdfDatasetRepresentation> => {
|
|
const patcherStore = new Store([
|
|
quad(namedNode(`${base}a`), namedNode(`${base}p`), namedNode(`${base}c`)),
|
|
quad(namedNode(`${base}a`), namedNode(`${base}b`), namedNode(`${base}o`)),
|
|
]);
|
|
patcherInput.representation!.dataset = patcherStore;
|
|
return patcherInput.representation!;
|
|
});
|
|
|
|
const result = await handler.handleSafe(input);
|
|
expect(result.dataset).toBeRdfIsomorphic([
|
|
quad(namedNode(`${base}a`), namedNode(`${base}p`), namedNode(`${base}c`)),
|
|
quad(namedNode(`${base}a`), namedNode(`${base}b`), namedNode(`${base}o`)),
|
|
]);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that replaces immutable triples.', async(): Promise<void> => {
|
|
input.representation!.dataset.addQuad(namedNode(identifier.path), namedNode(`${base}p`), namedNode(`${base}o1`));
|
|
patcher.handle = jest.fn(async(patcherInput: RepresentationPatcherInput<RdfDatasetRepresentation>):
|
|
Promise<RdfDatasetRepresentation> => {
|
|
const patcherStore = new Store([
|
|
quad(namedNode(identifier.path), namedNode(`${base}p`), namedNode(`${base}o2`)),
|
|
]);
|
|
patcherInput.representation!.dataset = patcherStore;
|
|
return patcherInput.representation!;
|
|
});
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(`${base}foo`, `${base}p`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects patches that change immutable triples.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(`${base}foo`, `${base}p`, `${base}o`),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
|
|
it('rejects everything when ImmutableTriple has no arguments.', async(): Promise<void> => {
|
|
handler = new ImmutableMetadataPatcher(patcher, metaStrategy, [
|
|
new FilterPattern(),
|
|
]);
|
|
|
|
await expect(handler.handleSafe(input)).rejects.toThrow(ConflictHttpError);
|
|
expect(patcher.handle).toHaveBeenCalledTimes(1);
|
|
expect(patcher.handle).toHaveBeenLastCalledWith(input);
|
|
});
|
|
});
|