mirror of
https://github.com/CommunitySolidServer/CommunitySolidServer.git
synced 2024-10-03 14:55:10 +00:00

* feat: only allow metadata to be edited with PATCH request & only allow metadata files to be edited when a resource is available * fix: remove unnecesary log at POST * feat: PUT resets metadata contents + not possible to add metadata with PUT to container * feat: add metadataStrategy (auxiliaryStrategy) + use that strategy in operationhandlers * feat: PUT request on existing LDPC is not allowed as it would be possible to edit (read reset) metadata * test: add unit tests to operationhandlers to handle metadata editing * test: add unit tests to representationPatchHandler to handle metadata editing * fix: update dependency of meta.json to version 3.0.0 * fix: lint and dependency still v2 * fix: replaced file references to resource references + moved Patch check to new patchhandler which is more generic * fix: moved checking metadata resources checking from DELETE and POST handler down to DABS * fix: remove PATCH message about metadata extension * fix: move PATCH message about metadata extension * WIP: adding writeMetadata + getMetadata in DABS and add writeMetadata to DataAccessors (part 1) * WIP: implement writeMetadata in memorybackend + change resourceExists * WIP: implement writeMetadata in SparqlDataAccessor.ts * test: fix test interfaces * test: InMemoryDataAccessor.ts resulted into changing identifier for writeMetadata in DataAccessor.ts (now taking subject identifier instead of metadata resource identifier) * test: accessor tests implemented for metadata * test: add RdfImmutableCheckPatcher.test.ts * test: add tests in DataAccessorBasedStore.test.ts * test: fix template config for DynamicPods test * test: add integration tests for metadata * fix: change metaStrategy to metadataStrategy * refactor: comments updated to new location CSS on github + some alphabetical edits * refactor: remove getMetadata function in DABS as it is only used once * refactor: add DataAccessorBasedStoreArgs to DataAccessorBasedStore.ts * docs: modify documentation for writeMetadata function in DataAccessor.ts * feat: ldp:contains is also part of the metadata resource of a container * refactor: change function name and move check to DataAccessorBasedStore * fix: fix tests for DABS and PutOperationHandler * feat: avoid cloneRepresentation by introducing RdfPatcher, RdfStorePatcher and modifying ImmutableMetadataPatcher, N3Patcher, patching.json and SparqlUpdatePatcher * test: fix patcher tests * feat: create sparqlInsertMetadata in SparqlDataAccessor.ts * fix: move check during put on container if it exists already back to PutOperationHandler.ts after discussion in PR * test: update tests PutOperationHandler.ts and DataAccessorBasedStore.ts regarding previous commit * test: add converter to DABS and replace rejection on data during container creation to warning * test: implemented RdfPatcher test * feat: remove ContainerPatcher * fix: fix lint * fix: fix integration tests * refactor: fix minor issues mentioned in the PR * WIP: problem with removeResponseMetadata * refactor: remove responseMetadata in QuadToRdfConverter.ts * feat: handle ResponeMetadata when writing to the store via a patch * refactor: refactor based on comments in PR * feat: make ImmutableMetadataPatcher.ts instantiation more clear * test: achieve 100% coverage again * fix: fix lint * refactor: return to explicit arguments for the DABS * fix: return to explicit arguments for the DABS (missed one) * feat: optimise immutable checker * fix: fix, enhance docs + optimise config files * fix: DABS + QuadToRdfConverter feedback implemented * fix: patching feedback implemented * test: update operationhandler tests * test: update integration tests after feedback * test: update DABS tests after feedback * test: update ImmutableMetadataPatcher.test.ts after feedback * test: update patch tests after feedback * docs: add documentation about editing metadata * fix: config: intendation + name change + extra filters | filter pattern * docs: tsdoc added to RdfStorePatcher.ts * fix: DABS split implemented for getRepresentation + comment refactoring * docs: further documentation on removing response data on serialization * fix: DABS getRepresentation method * docs: apply feedback from Joachim on the documentation of metadata-editing.md * fix: indentation fix + fix metadata-editing.md documentation after feedback from Joachim * docs: small fix in metadata-editing.md documentation after feedback from Joachim * fix: fix metadata-editing.md documentation after feedback from Joachim * fix: fix tests meta-editing after feedback Joachim * feat: first attempt at RELEASE_NOTES.md * docs: update release notes based on feedback * docs: fix newline * fix: patching config changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * docs: metadata editing documentation changes after feedback * feat: optimisation on ImmutableMetadataPatcher.ts algorithm * feat: remove converter from DABS and add conversion for metadata resources in the RCS * fix: Fix documentation RepresentationPatchHandler.ts + fix response graph not being stored due to convertingstore * feat: make RepresentationPatcher generic * test: generic RepresentationPatcher tests * test: 100% coverage for patchers again * feat: containers can be created with POST with no content-type * feat: Immutable checks always with subject identifier * feat: create AuxiliaryLinkMetadataWriter for adding description resources Link Header * test: add tests for AuxiliaryLinkMetadataWriter and update them for ImmutableMetadataPatcher * feat: remove metadataGenerator from acl.json and fix tests accordingly * WIP: preserve metadata on PUT * feat: preserve metadata on PUT * fix: keep metadata on PATCHes * test: add unit tests for preserving metadata on PUT * fix: remove inConverter from sparql endpoint as that is already the default in the (converting.json) * fix: add metadatastrategy to RepresentationConvertingStore in regex.json * test: add integration tests for preserving metadata on PUT * docs: update release notes and adding documentation about preserving metadata on PUT * WIP: Template create setRepresentation * fix: Move container exists and not allowed check to setRepresentation * test: fix lint * fix: update configs and documentation * refactor: update and add documentation + small refactoring * refactor: update and add documentation + small refactoring + fix tests * fix: Dynamic pod config + tests * fix: TemplatedResourcesGenerator does not create containers when they already exist * fix: metadata preservation now deals with complex content types * docs: explain the case when there is no content-type * fix: minor comments
131 lines
5.6 KiB
TypeScript
131 lines
5.6 KiB
TypeScript
import { BaseFileIdentifierMapper } from '../../../../src/storage/mapping/BaseFileIdentifierMapper';
|
|
import { BadRequestHttpError } from '../../../../src/util/errors/BadRequestHttpError';
|
|
import { NotFoundHttpError } from '../../../../src/util/errors/NotFoundHttpError';
|
|
import { trimTrailingSlashes } from '../../../../src/util/PathUtil';
|
|
|
|
jest.mock('fs');
|
|
|
|
describe('An BaseFileIdentifierMapper', (): void => {
|
|
const base = 'http://test.com/';
|
|
const rootFilepath = 'uploads/';
|
|
const mapper = new BaseFileIdentifierMapper(base, rootFilepath);
|
|
|
|
describe('mapUrlToFilePath', (): void => {
|
|
it('throws 404 if the input path does not contain the base.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: 'invalid' }, false)).rejects.toThrow(NotFoundHttpError);
|
|
});
|
|
|
|
it('throws 404 if the relative path does not start with a slash.', async(): Promise<void> => {
|
|
const result = mapper.mapUrlToFilePath({ path: `${trimTrailingSlashes(base)}test` }, false);
|
|
await expect(result).rejects.toThrow(BadRequestHttpError);
|
|
await expect(result).rejects.toThrow('URL needs a / after the base');
|
|
});
|
|
|
|
it('throws 400 if the input path contains relative parts.', async(): Promise<void> => {
|
|
const result = mapper.mapUrlToFilePath({ path: `${base}test/../test2` }, false);
|
|
await expect(result).rejects.toThrow(BadRequestHttpError);
|
|
await expect(result).rejects.toThrow('Disallowed /.. segment in URL');
|
|
});
|
|
|
|
it('returns the corresponding file path for container identifiers.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}container/` }, false)).resolves.toEqual({
|
|
identifier: { path: `${base}container/` },
|
|
filePath: `${rootFilepath}container/`,
|
|
isMetadata: false,
|
|
});
|
|
});
|
|
|
|
it('returns the default content-type.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test` }, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test` },
|
|
filePath: `${rootFilepath}test`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test.ttl` }, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test.ttl` },
|
|
filePath: `${rootFilepath}test.ttl`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test.txt` }, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test.txt` },
|
|
filePath: `${rootFilepath}test.txt`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
});
|
|
|
|
it('generates a file path if supported content-type was provided.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test.ttl` }, false, 'text/turtle')).resolves.toEqual({
|
|
identifier: { path: `${base}test.ttl` },
|
|
filePath: `${rootFilepath}test.ttl`,
|
|
contentType: 'text/turtle',
|
|
isMetadata: false,
|
|
});
|
|
});
|
|
|
|
it('returns the corresponding file path for metadata identifiers.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test.meta` }, false, 'text/turtle')).resolves.toEqual({
|
|
identifier: { path: `${base}test.meta` },
|
|
filePath: `${rootFilepath}test.meta`,
|
|
contentType: 'text/turtle',
|
|
isMetadata: true,
|
|
});
|
|
});
|
|
|
|
it('generates correct metadata file paths.', async(): Promise<void> => {
|
|
await expect(mapper.mapUrlToFilePath({ path: `${base}test.txt` }, true)).resolves.toEqual({
|
|
identifier: { path: `${base}test.txt` },
|
|
filePath: `${rootFilepath}test.txt.meta`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: true,
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('mapFilePathToUrl', (): void => {
|
|
it('throws an error if the input path does not contain the root file path.', async(): Promise<void> => {
|
|
await expect(mapper.mapFilePathToUrl('invalid', true)).rejects.toThrow(Error);
|
|
});
|
|
|
|
it('returns a generated identifier for directories.', async(): Promise<void> => {
|
|
await expect(mapper.mapFilePathToUrl(`${rootFilepath}container/`, true)).resolves.toEqual({
|
|
identifier: { path: `${base}container/` },
|
|
filePath: `${rootFilepath}container/`,
|
|
isMetadata: false,
|
|
});
|
|
});
|
|
|
|
it('returns files with the default content-type.', async(): Promise<void> => {
|
|
await expect(mapper.mapFilePathToUrl(`${rootFilepath}test`, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test` },
|
|
filePath: `${rootFilepath}test`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
await expect(mapper.mapFilePathToUrl(`${rootFilepath}test.ttl`, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test.ttl` },
|
|
filePath: `${rootFilepath}test.ttl`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
await expect(mapper.mapFilePathToUrl(`${rootFilepath}test.txt`, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test.txt` },
|
|
filePath: `${rootFilepath}test.txt`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: false,
|
|
});
|
|
});
|
|
|
|
it('identifies metadata files.', async(): Promise<void> => {
|
|
await expect(mapper.mapFilePathToUrl(`${rootFilepath}test.meta`, false)).resolves.toEqual({
|
|
identifier: { path: `${base}test` },
|
|
filePath: `${rootFilepath}test.meta`,
|
|
contentType: 'application/octet-stream',
|
|
isMetadata: true,
|
|
});
|
|
});
|
|
});
|
|
});
|