mirror of
https://github.com/bigchaindb/bigchaindb.git
synced 2024-10-13 13:34:05 +00:00
Address comments II
- Update name of tm version check function - some typos
This commit is contained in:
parent
e5d725a96b
commit
01213e34e2
@ -119,11 +119,11 @@ class App(BaseApplication):
|
|||||||
|
|
||||||
# Check if BigchainDB supports the Tendermint version
|
# Check if BigchainDB supports the Tendermint version
|
||||||
try:
|
try:
|
||||||
if check_tendermint_version(request.version):
|
if tendermint_version_is_compatible(request.version):
|
||||||
logger.info(f"Tendermint version: {request.version}")
|
logger.info(f"Tendermint version: {request.version}")
|
||||||
else:
|
else:
|
||||||
logger.error(f"Error: Tendermint version {request.version} not supported."
|
logger.error(f"Error: Tendermint version {request.version} not supported."
|
||||||
f" Currently, BigchainDB only supports {__tm_supported_versions__} .Exiting!")
|
f" Currently, BigchainDB only supports {__tm_supported_versions__}. Exiting!")
|
||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
except AttributeError:
|
except AttributeError:
|
||||||
logger.info("Tendermint version not found. Exiting!")
|
logger.info("Tendermint version not found. Exiting!")
|
||||||
|
|||||||
@ -188,7 +188,7 @@ def load_node_key(path):
|
|||||||
return key_pair_from_ed25519_key(hex_private_key)
|
return key_pair_from_ed25519_key(hex_private_key)
|
||||||
|
|
||||||
|
|
||||||
def check_tendermint_version(running_tm_ver):
|
def tendermint_version_is_compatible(running_tm_ver):
|
||||||
"""
|
"""
|
||||||
Check Tendermint compatability with BigchainDB server
|
Check Tendermint compatability with BigchainDB server
|
||||||
|
|
||||||
@ -197,6 +197,8 @@ def check_tendermint_version(running_tm_ver):
|
|||||||
:return: True/False depending on the compatability with BigchainDB server
|
:return: True/False depending on the compatability with BigchainDB server
|
||||||
:rtype: bool
|
:rtype: bool
|
||||||
"""
|
"""
|
||||||
|
|
||||||
|
# Splitting because version can look like this e.g. 0.22.8-40d6dc2e
|
||||||
tm_ver = running_tm_ver.split('-')
|
tm_ver = running_tm_ver.split('-')
|
||||||
if not tm_ver:
|
if not tm_ver:
|
||||||
return False
|
return False
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user