mirror of
https://github.com/bigchaindb/bigchaindb.git
synced 2024-10-13 13:34:05 +00:00
Problem: Minor style issues with PR
Solution: Addressing comments
This commit is contained in:
parent
2eb32d93f6
commit
38fcd4d792
@ -97,7 +97,7 @@ class Election(Transaction):
|
|||||||
:param current_transactions: (list) A list of transactions to be validated along with the election
|
:param current_transactions: (list) A list of transactions to be validated along with the election
|
||||||
|
|
||||||
Returns:
|
Returns:
|
||||||
ValidatorElection object
|
Election: a Election object or an object of the derived Election subclass.
|
||||||
|
|
||||||
Raises:
|
Raises:
|
||||||
ValidationError: If the election is invalid
|
ValidationError: If the election is invalid
|
||||||
|
|||||||
@ -30,7 +30,7 @@ class Vote(Transaction):
|
|||||||
bigchain (BigchainDB): an instantiated bigchaindb.lib.BigchainDB object.
|
bigchain (BigchainDB): an instantiated bigchaindb.lib.BigchainDB object.
|
||||||
|
|
||||||
Returns:
|
Returns:
|
||||||
Vote object
|
Vote: a Vote object
|
||||||
|
|
||||||
Raises:
|
Raises:
|
||||||
ValidationError: If the election vote is invalid
|
ValidationError: If the election vote is invalid
|
||||||
|
|||||||
@ -366,8 +366,8 @@ def test_end_block_return_validator_updates(b, init_chain_request):
|
|||||||
resp = app.end_block(RequestEndBlock(height=99))
|
resp = app.end_block(RequestEndBlock(height=99))
|
||||||
assert resp.validator_updates[0] == encode_validator(validator)
|
assert resp.validator_updates[0] == encode_validator(validator)
|
||||||
|
|
||||||
updates = b.is_approved()
|
updates = b.approved_update()
|
||||||
assert updates == []
|
assert not updates
|
||||||
|
|
||||||
|
|
||||||
def test_store_pre_commit_state_in_end_block(b, alice, init_chain_request):
|
def test_store_pre_commit_state_in_end_block(b, alice, init_chain_request):
|
||||||
|
|||||||
@ -164,11 +164,11 @@ def test_validator_updates(b, validator_pub_key):
|
|||||||
'update_id': VALIDATOR_UPDATE_ID}
|
'update_id': VALIDATOR_UPDATE_ID}
|
||||||
query.store_validator_update(b.connection, validator_update)
|
query.store_validator_update(b.connection, validator_update)
|
||||||
|
|
||||||
updates = b.is_approved()
|
updates = b.approved_updates()
|
||||||
assert updates == [validator_update['validator']]
|
assert updates == validator_update['validator']
|
||||||
|
|
||||||
b.delete_validator_update()
|
b.delete_validator_update()
|
||||||
assert b.is_approved() == []
|
assert not b.approved_updates()
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.bdb
|
@pytest.mark.bdb
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user