From 439d0c45c422c8b4003cdcd9459598d849b21bf3 Mon Sep 17 00:00:00 2001
From: Ahmed Muawia Khan <amuawiakhan@gmail.com>
Date: Tue, 11 Sep 2018 10:57:16 +0200
Subject: [PATCH] Address comments I

- Rephrase log rotation to imply monit is not default
- Add statement to explain where bigchaindb log files are created
- Fix HTML comment
- Add log rotation to index
---
 docs/server/source/appendices/index.rst       | 1 +
 docs/server/source/appendices/log-rotation.md | 7 ++++---
 pkg/scripts/bigchaindb-monit-config           | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/docs/server/source/appendices/index.rst b/docs/server/source/appendices/index.rst
index 24276f2d..ac67be25 100755
--- a/docs/server/source/appendices/index.rst
+++ b/docs/server/source/appendices/index.rst
@@ -17,3 +17,4 @@ Appendices
    ntp-notes
    licenses
    all-in-one-bigchaindb
+   log-rotation
diff --git a/docs/server/source/appendices/log-rotation.md b/docs/server/source/appendices/log-rotation.md
index 526edf1d..ca8c7a98 100644
--- a/docs/server/source/appendices/log-rotation.md
+++ b/docs/server/source/appendices/log-rotation.md
@@ -1,3 +1,4 @@
+<!---
 Copyright BigchainDB GmbH and BigchainDB contributors
 SPDX-License-Identifier: (Apache-2.0 AND CC-BY-4.0)
 Code is Apache-2.0 and docs are CC-BY-4.0
@@ -26,14 +27,14 @@ Log rotation is baked into BigchainDB server using the `logging` module. If you
  - `bigchaindb-errors.log`
  - `bigchaindb-benchmark.log`
 
-Default location for these log files is: `$HOME/.bigchaindb-monit/logs`
+These log files are created by default in the directory from you run `bigchaindb start`, if you are using `monit` the default directory is: `$HOME/.bigchaindb-monit/logs`
 
-The logs for BigchainDB server are rotated when any of the above mentioned file exceeds `209715200 bytes`.
+The logs for BigchainDB server are rotated when any of the above mentioned file exceeds `209715200 bytes (i.e. approximately 209 MB).`.
 
 
 ## Log rotation for Tendermint
 
-Log rotation for Tendermint is handled by [Monit]( https://www.mmonit.com/monit). When we start BigchainDB and Tendermint using [How to Set Up a BigchainDB Network](../simple-deployment-template/network-setup.md) guide.
+In order to set up log rotation of Tendermint, you will need to use the [Monit]( https://www.mmonit.com/monit) scripts provided by us. Covered in the [How to Set Up a BigchainDB Network](../simple-deployment-template/network-setup.md) guide.
 
 ```bash
 $ monit -d 1
diff --git a/pkg/scripts/bigchaindb-monit-config b/pkg/scripts/bigchaindb-monit-config
index e6c7e617..90225328 100644
--- a/pkg/scripts/bigchaindb-monit-config
+++ b/pkg/scripts/bigchaindb-monit-config
@@ -135,10 +135,10 @@ cat >${monit_script_path}_logrotate <<EOF
 case \$1 in
 
   rotate_tendermint_logs)
-    /bin/mv \$2 \$2.\$(date +%y-%m-%d)
+    /bin/cp \$2 \$2.\$(date +%y-%m-%d)
     /bin/tar -cvf \$2.\$(date +%Y%m%d_%H%M%S).tar.gz \$2.\$(date +%y-%m-%d)
     /bin/rm \$2.\$(date +%y-%m-%d)
-    /bin/kill -2 \$(cat \$3)
+    /bin/cp /dev/null \$2
     ;;
 
 esac