Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: is_commited method is not simplied

Browse Source 
Solution: remove if condition
This commit is contained in:
Vanshdeep Singh 2018-08-30 10:39:22 +02:00
parent 2bb98ab97f
commit 55c3fb5fb3
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bigchaindb/lib.py
View File

@ -225,12 +225,9 @@ class BigchainDB(object):
return backend.query.delete_unspent_outputs( return backend.query.delete_unspent_outputs(
self.connection, *unspent_outputs) self.connection, *unspent_outputs)
def is_commited(self, transaction_id): def is_committed(self, transaction_id):
transaction = backend.query.get_transaction(self.connection, transaction_id) transaction = backend.query.get_transaction(self.connection, transaction_id)
if transaction: return bool(transaction)
return True
else:
return False
def get_transaction(self, transaction_id): def get_transaction(self, transaction_id):
transaction = backend.query.get_transaction(self.connection, transaction_id) transaction = backend.query.get_transaction(self.connection, transaction_id)

2
bigchaindb/models.py
View File

@ -27,7 +27,7 @@ class Transaction(Transaction):
if self.operation == Transaction.CREATE: if self.operation == Transaction.CREATE:
duplicates = any(txn for txn in current_transactions if txn.id == self.id) duplicates = any(txn for txn in current_transactions if txn.id == self.id)
if bigchain.is_commited(self.id) or duplicates: if bigchain.is_committed(self.id) or duplicates:
raise DuplicateTransaction('transaction `{}` already exists' raise DuplicateTransaction('transaction `{}` already exists'
.format(self.id)) .format(self.id))