Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: Unnecessary cls parameter for get_transaction

Browse Source 
Solution: the `.from_dict` method implicitly detects the class so `cls`
parameter can be removed
This commit is contained in:
Vanshdeep Singh 2018-07-25 17:47:53 +02:00
parent 610e4bad9c
commit 67d439cc92
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bigchaindb/lib.py
View File

@ -251,7 +251,7 @@ class BigchainDB(object):
return backend.query.delete_unspent_outputs( return backend.query.delete_unspent_outputs(
self.connection, *unspent_outputs) self.connection, *unspent_outputs)
def get_transaction(self, transaction_id, include_status=False, cls=Transaction): def get_transaction(self, transaction_id, include_status=False):
transaction = backend.query.get_transaction(self.connection, transaction_id) transaction = backend.query.get_transaction(self.connection, transaction_id)
if transaction: if transaction:
@ -267,7 +267,7 @@ class BigchainDB(object):
transaction.update({'metadata': metadata}) transaction.update({'metadata': metadata})
transaction = cls.from_dict(transaction) transaction = Transaction.from_dict(transaction)
if include_status: if include_status:
return transaction, self.TX_VALID if transaction else None return transaction, self.TX_VALID if transaction else None

2
bigchaindb/upsert_validator/validator_election.py
View File

@ -89,7 +89,7 @@ class ValidatorElection(Transaction):
input_conditions = [] input_conditions = []
duplicates = any(txn for txn in current_transactions if txn.id == self.id) duplicates = any(txn for txn in current_transactions if txn.id == self.id)
if bigchain.get_transaction(self.id, cls=ValidatorElection) or duplicates: if bigchain.get_transaction(self.id) or duplicates:
raise DuplicateTransaction('transaction `{}` already exists' raise DuplicateTransaction('transaction `{}` already exists'
.format(self.id)) .format(self.id))