From 7cad22d0c6a60c5dbafb5c18fe2857fa2042136e Mon Sep 17 00:00:00 2001
From: Vanshdeep Singh <kansi13@gmail.com>
Date: Mon, 20 Aug 2018 11:02:19 +0200
Subject: [PATCH] Problem: No test to check invalid crypto-conditions

Solution: Add test which raises validation error when using unsupported cypto-conditions
---
 ...nsaction_validator_election_vote_v2.0.yaml |  4 +++-
 .../test_validator_election_vote.py           | 20 +++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/bigchaindb/common/schema/transaction_validator_election_vote_v2.0.yaml b/bigchaindb/common/schema/transaction_validator_election_vote_v2.0.yaml
index db3cba9e..c17fb229 100644
--- a/bigchaindb/common/schema/transaction_validator_election_vote_v2.0.yaml
+++ b/bigchaindb/common/schema/transaction_validator_election_vote_v2.0.yaml
@@ -10,7 +10,9 @@ required:
 - operation
 - outputs
 properties:
-  operation: "VALIDATOR_ELECTION_VOTE"
+  operation:
+    type: string
+    value: "VALIDATOR_ELECTION_VOTE"
   outputs:
     type: array
     items:
diff --git a/tests/upsert_validator/test_validator_election_vote.py b/tests/upsert_validator/test_validator_election_vote.py
index 8dd2930d..b9de10b4 100644
--- a/tests/upsert_validator/test_validator_election_vote.py
+++ b/tests/upsert_validator/test_validator_election_vote.py
@@ -34,6 +34,26 @@ def test_upsert_validator_valid_election_vote(b_mock, valid_election, ed25519_no
     assert vote.validate(b_mock)
 
 
+@pytest.mark.tendermint
+@pytest.mark.bdb
+def test_upsert_validator_valid_non_election_vote(b_mock, valid_election, ed25519_node_keys):
+    b_mock.store_bulk_transactions([valid_election])
+
+    input0 = valid_election.to_inputs()[0]
+    votes = valid_election.outputs[0].amount
+    public_key0 = input0.owners_before[0]
+    key0 = ed25519_node_keys[public_key0]
+
+    election_pub_key = ValidatorElection.to_public_key(valid_election.id)
+
+    # Ensure that threshold conditions are now allowed
+    with pytest.raises(ValidationError):
+        ValidatorElectionVote.generate([input0],
+                                       [([election_pub_key, key0.public_key], votes)],
+                                       election_id=valid_election.id)\
+                             .sign([key0.private_key])
+
+
 @pytest.mark.tendermint
 @pytest.mark.bdb
 def test_upsert_validator_delegate_election_vote(b_mock, valid_election, ed25519_node_keys):