From 800a2dc7916e7017edee355d245714b7e3675f09 Mon Sep 17 00:00:00 2001 From: z-bowen Date: Tue, 28 Aug 2018 17:47:40 +0200 Subject: [PATCH] Problem: No error handling for invalid election ids Solution: Send an error message to `logger.error` if bigchain fails to get the election, then `return` --- bigchaindb/commands/bigchaindb.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bigchaindb/commands/bigchaindb.py b/bigchaindb/commands/bigchaindb.py index 95b6f26f..447431b4 100644 --- a/bigchaindb/commands/bigchaindb.py +++ b/bigchaindb/commands/bigchaindb.py @@ -203,6 +203,9 @@ def run_upsert_validator_show(args, bigchain): """ election = bigchain.get_transaction(args.election_id) + if not election: + logger.error(f'No election found with election_id {args.election_id}') + return new_validator = election.asset['data']