From 8a5814bb08eb2cdca34a9d41f4bfd1dc2da9b932 Mon Sep 17 00:00:00 2001
From: Scott Sadler <scott@alphanode.co>
Date: Tue, 14 Mar 2017 15:12:12 +0100
Subject: [PATCH] clarify schema testing module

---
 .../common/schema/test_transaction_schema.py  | 21 --------
 tests/common/schema/test_vote_schema.py       | 13 -----
 tests/common/{schema => }/test_schema.py      | 50 ++++++++++++++++++-
 3 files changed, 48 insertions(+), 36 deletions(-)
 delete mode 100644 tests/common/schema/test_transaction_schema.py
 delete mode 100644 tests/common/schema/test_vote_schema.py
 rename tests/common/{schema => }/test_schema.py (58%)

diff --git a/tests/common/schema/test_transaction_schema.py b/tests/common/schema/test_transaction_schema.py
deleted file mode 100644
index 86b192e0..00000000
--- a/tests/common/schema/test_transaction_schema.py
+++ /dev/null
@@ -1,21 +0,0 @@
-from pytest import raises
-
-from bigchaindb.common.exceptions import SchemaValidationError
-from bigchaindb.common.schema import validate_transaction_schema
-
-
-def test_validate_transaction_create(create_tx):
-    validate_transaction_schema(create_tx.to_dict())
-
-
-def test_validate_transaction_signed_create(signed_create_tx):
-    validate_transaction_schema(signed_create_tx.to_dict())
-
-
-def test_validate_transaction_signed_transfer(signed_transfer_tx):
-    validate_transaction_schema(signed_transfer_tx.to_dict())
-
-
-def test_validate_transaction_fails():
-    with raises(SchemaValidationError):
-        validate_transaction_schema({})
diff --git a/tests/common/schema/test_vote_schema.py b/tests/common/schema/test_vote_schema.py
deleted file mode 100644
index a9de9492..00000000
--- a/tests/common/schema/test_vote_schema.py
+++ /dev/null
@@ -1,13 +0,0 @@
-from pytest import raises
-
-from bigchaindb.common.exceptions import SchemaValidationError
-from bigchaindb.common.schema import validate_vote_schema
-
-
-def test_validate_vote(structurally_valid_vote):
-    validate_vote_schema(structurally_valid_vote)
-
-
-def test_validate_vote_fails():
-    with raises(SchemaValidationError):
-        validate_vote_schema({})
diff --git a/tests/common/schema/test_schema.py b/tests/common/test_schema.py
similarity index 58%
rename from tests/common/schema/test_schema.py
rename to tests/common/test_schema.py
index 02a00ee2..ef972f22 100644
--- a/tests/common/schema/test_schema.py
+++ b/tests/common/test_schema.py
@@ -1,6 +1,18 @@
-from bigchaindb.common.schema import (
-    TX_SCHEMA, VOTE_SCHEMA, drop_schema_descriptions)
+"""
+This module is tests related to schema checking, but _not_ of granular schematic
+properties related to validation.
+"""
 
+from pytest import raises
+
+from bigchaindb.common.exceptions import SchemaValidationError
+from bigchaindb.common.schema import (
+    TX_SCHEMA, VOTE_SCHEMA, drop_schema_descriptions,
+    validate_transaction_schema, validate_vote_schema)
+
+
+################################################################################
+# Test of schema utils
 
 def _test_additionalproperties(node, path=''):
     """
@@ -67,3 +79,37 @@ def test_drop_descriptions():
     }
     drop_schema_descriptions(node)
     assert node == expected
+
+
+################################################################################
+# Test call transaction schema
+
+
+def test_validate_transaction_create(create_tx):
+    validate_transaction_schema(create_tx.to_dict())
+
+
+def test_validate_transaction_signed_create(signed_create_tx):
+    validate_transaction_schema(signed_create_tx.to_dict())
+
+
+def test_validate_transaction_signed_transfer(signed_transfer_tx):
+    validate_transaction_schema(signed_transfer_tx.to_dict())
+
+
+def test_validate_transaction_fails():
+    with raises(SchemaValidationError):
+        validate_transaction_schema({})
+
+
+################################################################################
+# Test call vote schema
+
+
+def test_validate_vote(structurally_valid_vote):
+    validate_vote_schema(structurally_valid_vote)
+
+
+def test_validate_vote_fails():
+    with raises(SchemaValidationError):
+        validate_vote_schema({})