Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: Incorrent code comments

Browse Source 
Solution: Update comments with correct context
This commit is contained in:
Vanshdeep Singh 2018-08-01 13:42:52 +02:00
parent 1b3b488c75
commit 8dfd0c8b70
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
bigchaindb/upsert_validator/validator_election_vote.py
View File

@ -10,27 +10,18 @@ from bigchaindb.common.schema import (_validate_schema,
class ValidatorElectionVote(Transaction): class ValidatorElectionVote(Transaction):
VALIDATOR_ELECTION_VOTE = 'VALIDATOR_ELECTION_VOTE' VALIDATOR_ELECTION_VOTE = 'VALIDATOR_ELECTION_VOTE'
# NOTE: this transaction class extends create so the operation inheritence is achieved # NOTE: This class inherits TRANSFER txn type. The `TRANSFER` property is
# by renaming CREATE to VALIDATOR_ELECTION # overriden to re-use methods from parent class
TRANSFER = VALIDATOR_ELECTION_VOTE TRANSFER = VALIDATOR_ELECTION_VOTE
ALLOWED_OPERATIONS = (VALIDATOR_ELECTION_VOTE,) ALLOWED_OPERATIONS = (VALIDATOR_ELECTION_VOTE,)
def __init__(self, operation, asset, inputs, outputs,
metadata=None, version=None, hash_id=None):
# operation `CREATE` is being passed as argument as `VALIDATOR_ELECTION` is an extension
# of `CREATE` and any validation on `CREATE` in the parent class should apply to it
super().__init__(operation, asset, inputs, outputs, metadata, version, hash_id)
def validate(self, bigchain, current_transactions=[]): def validate(self, bigchain, current_transactions=[]):
"""Validate election transaction """Validate election vote transaction
NOTE: There are no additional validity conditions on casting votes i.e.
a vote is just a valid TRANFER transaction
For more details refer BEP-21: https://github.com/bigchaindb/BEPs/tree/master/21 For more details refer BEP-21: https://github.com/bigchaindb/BEPs/tree/master/21
NOTE:
* A valid election is initiated by an existing validator.
* A valid election is one where voters are validators and votes are
alloacted according to the voting power of each validator node.
Args: Args:
bigchain (BigchainDB): an instantiated bigchaindb.lib.BigchainDB object. bigchain (BigchainDB): an instantiated bigchaindb.lib.BigchainDB object.
@ -56,7 +47,7 @@ class ValidatorElectionVote(Transaction):
@classmethod @classmethod
def validate_schema(cls, tx, skip_id=False): def validate_schema(cls, tx, skip_id=False):
"""Validate the validator election transaction. Since `VALIDATOR_ELECTION` extends `CREATE` """Validate the validator election vote transaction. Since `VALIDATOR_ELECTION_VOTE` extends `TRANFER`
transaction, all the validations for `CREATE` transaction should be inherited transaction, all the validations for `CREATE` transaction should be inherited
""" """
if not skip_id: if not skip_id: