From 8ff6c919b2cd797348a918738d6439d9156050b8 Mon Sep 17 00:00:00 2001 From: z-bowen Date: Thu, 30 Aug 2018 10:39:02 +0200 Subject: [PATCH] Problem: TODO for `test_configure_bigchaindb_logging` suggest only fixing the test, when removing is also an option Solution: Changed the wording on the TODO to suggest fix or remove --- tests/commands/test_utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/commands/test_utils.py b/tests/commands/test_utils.py index 76731b48..11ff41a8 100644 --- a/tests/commands/test_utils.py +++ b/tests/commands/test_utils.py @@ -75,7 +75,8 @@ def test_configure_bigchaindb_logging(log_level): # TODO: See following comment: # This is a dirty test. If a test *preceding* this test makes use of the logger, and then another test *after* this # test also makes use of the logger, somehow we get logger.disabled == True, and the later test fails. We need to - # engineer this somehow to leave the test env in the same state as it finds it. + # either engineer this somehow to leave the test env in the same state as it finds it, or make an assessment + # whether or not we even need this test, and potentially just remove it. from bigchaindb.commands.utils import configure_bigchaindb