Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: websocket might be unresponsive (#2413)

Browse Source 
Solution: It might be related on how aiohttp 2.x handles `send_str`.
AFAIK the call `send_str` was not "fully async". In aiohttp 3.x they
[changed it][1]:

> send_str(), send_bytes(), send_json(), ping() and pong() are genuine
async functions now. (#2475)

So this patch adds support for aiohttp 3.x, and uses the `send_str`
coroutine.

[1]: https://github.com/aio-libs/aiohttp/blob/master/HISTORY.rst#deprecations-and-removals-1
This commit is contained in:
vrde 2018-07-26 15:30:10 +02:00 committed by Shahbaz Nazir
parent 2087f7090f
commit af2bf61dc8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bigchaindb/web/websocket_server.py
View File

@ -106,7 +106,7 @@ class Dispatcher:
for _, websocket in self.subscribers.items(): for _, websocket in self.subscribers.items():
for str_item in str_buffer: for str_item in str_buffer:
websocket.send_str(str_item) yield from websocket.send_str(str_item)
@asyncio.coroutine @asyncio.coroutine

2
setup.py
View File

@ -85,7 +85,7 @@ install_requires = [
'gunicorn~=19.0', 'gunicorn~=19.0',
'jsonschema~=2.5.1', 'jsonschema~=2.5.1',
'pyyaml~=3.12', 'pyyaml~=3.12',
'aiohttp~=2.3', 'aiohttp~=3.0',
'python-rapidjson-schema==0.1.1', 'python-rapidjson-schema==0.1.1',
'bigchaindb-abci==0.5.1', 'bigchaindb-abci==0.5.1',
'setproctitle~=1.1.0', 'setproctitle~=1.1.0',