From bec2abeb55daaeb376109279c2bb450b4efa74ca Mon Sep 17 00:00:00 2001 From: z-bowen Date: Fri, 31 Aug 2018 15:16:05 +0200 Subject: [PATCH] Problem: TODO to improve error reporting in one of the queries Solution: Raise an exception with some info about what failed --- bigchaindb/backend/localmongodb/query.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bigchaindb/backend/localmongodb/query.py b/bigchaindb/backend/localmongodb/query.py index 29993b30..4e7aad6f 100644 --- a/bigchaindb/backend/localmongodb/query.py +++ b/bigchaindb/backend/localmongodb/query.py @@ -7,6 +7,7 @@ from pymongo import DESCENDING from bigchaindb import backend +from bigchaindb.backend import exceptions from bigchaindb.backend.exceptions import DuplicateKeyError from bigchaindb.backend.utils import module_dispatch_registrar from bigchaindb.backend.localmongodb.connection import LocalMongoDBConnection @@ -227,8 +228,10 @@ def store_unspent_outputs(conn, *unspent_outputs): ordered=False, ) ) - except DuplicateKeyError: - # TODO log warning at least + except DuplicateKeyError as err: + raise exceptions.DuplicateKeyError( + f'Duplicate key in transactions list {unspent_outputs}. Exception raised with error {err}' + ) pass