From c007d0d8b4bf94bab1adf89c2c5adb843a212d9e Mon Sep 17 00:00:00 2001 From: Scott Sadler Date: Thu, 13 Oct 2016 16:12:27 +0200 Subject: [PATCH] prevent adding None as fulfillment / condition to Transaction --- test_transaction.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/test_transaction.py b/test_transaction.py index 897570b0..c69e5023 100644 --- a/test_transaction.py +++ b/test_transaction.py @@ -1090,3 +1090,17 @@ def test_create_transfer_with_invalid_parameters(): Transaction.transfer(['fulfillment'], {}, Asset()) with raises(ValueError): Transaction.transfer(['fulfillment'], [], Asset()) + + +def test_cant_add_empty_condition(): + from bigchaindb_common.transaction import Transaction + tx = Transaction(Transaction.CREATE, None) + with raises(TypeError): + tx.add_condition(None) + + +def test_cant_add_empty_fulfillment(): + from bigchaindb_common.transaction import Transaction + tx = Transaction(Transaction.CREATE, None) + with raises(TypeError): + tx.add_fulfillment(None)