Address comments

- Fix nitpicks
- Remove -e flag while installing because it is not needed
- Remove unwanted env variables
- Update some docs
This commit is contained in:
Ahmed Muawia Khan 2018-08-01 12:12:47 +02:00
parent 7c7b824294
commit d3216bc2c8
3 changed files with 7 additions and 9 deletions

View File

@ -7,7 +7,6 @@ RUN apt-get -qq update \
&& apt-get -y upgrade \ && apt-get -y upgrade \
&& apt-get install -y jq \ && apt-get install -y jq \
&& pip install --no-cache-dir --process-dependency-links . \ && pip install --no-cache-dir --process-dependency-links . \
&& pip install --no-cache-dir . \
&& apt-get autoremove \ && apt-get autoremove \
&& apt-get clean && apt-get clean

View File

@ -13,7 +13,7 @@ RUN apk --update add sudo bash \
libffi-dev openssl-dev build-base jq \ libffi-dev openssl-dev build-base jq \
&& apk add --no-cache libstdc++ dpkg gnupg \ && apk add --no-cache libstdc++ dpkg gnupg \
&& pip3 install --upgrade pip cffi \ && pip3 install --upgrade pip cffi \
&& pip install --no-cache-dir --process-dependency-links -e .[dev] \ && pip install --no-cache-dir --process-dependency-links . \
&& apk del build-dependencies \ && apk del build-dependencies \
&& rm -f /var/cache/apk/* && rm -f /var/cache/apk/*
@ -35,10 +35,6 @@ RUN addgroup tmuser \
RUN mkdir -p /data/db /data/configdb \ RUN mkdir -p /data/db /data/configdb \
&& chown -R mongodb:mongodb /data/db /data/configdb && chown -R mongodb:mongodb /data/db /data/configdb
# When developing with Python in a docker container, we are using PYTHONBUFFERED
# to force stdin, stdout and stderr to be totally unbuffered and to capture logs/outputs
ENV PYTHONUNBUFFERED 0
# BigchainDB enviroment variables # BigchainDB enviroment variables
ENV BIGCHAINDB_DATABASE_PORT 27017 ENV BIGCHAINDB_DATABASE_PORT 27017
ENV BIGCHAINDB_DATABASE_BACKEND localmongodb ENV BIGCHAINDB_DATABASE_BACKEND localmongodb

View File

@ -13,8 +13,11 @@ This image contains all the services required for a BigchainDB node i.e.
- MongoDB - MongoDB
- Tendermint - Tendermint
*We understand that it is an anti-pattern to run multiple services inside a docker.* **Note:** *This image is to help quick deployment for early adopters, for a more standard*
*This image is to help quick deployment for early adopters* *approach please refer to one of our deployment guides:*
- [BigchainDB developer setup guides](https://docs.bigchaindb.com/projects/contributing/en/latest/dev-setup-coding-and-contribution-process/index.html).
- [BigchainDB with Kubernetes](http://docs.bigchaindb.com/projects/server/en/latest/production-deployment-template/index.html).
## Prerequisite(s) ## Prerequisite(s)
- [Docker](https://docs.docker.com/engine/installation/) - [Docker](https://docs.docker.com/engine/installation/)