Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: a valid transaction is detected as double spend (#2389)

Browse Source 
Solution: query the wanted data per input
This commit is contained in:
codegeschrei 2018-07-18 10:52:33 +02:00 committed by Vanshdeep Singh
parent fdf0283508
commit d521a00925
2 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bigchaindb/backend/localmongodb/query.py
View File

@ -99,11 +99,13 @@ def get_assets(conn, asset_ids):
@register_query(LocalMongoDBConnection) @register_query(LocalMongoDBConnection)
def get_spent(conn, transaction_id, output): def get_spent(conn, transaction_id, output):
query = {'inputs.fulfills': {
'transaction_id': transaction_id,
'output_index': output}}
return conn.run( return conn.run(
conn.collection('transactions') conn.collection('transactions')
.find({'inputs.fulfills.transaction_id': transaction_id, .find(query, {'_id': 0}))
'inputs.fulfills.output_index': output},
{'_id': 0}))
@register_query(LocalMongoDBConnection) @register_query(LocalMongoDBConnection)

20
tests/test_core.py
View File

@ -1,6 +1,10 @@
import pytest import pytest
pytestmark = pytest.mark.tendermint
@pytest.mark.skipif(reason='will be fixed in another PR')
@pytest.fixture @pytest.fixture
def config(request, monkeypatch): def config(request, monkeypatch):
backend = request.config.getoption('--database-backend') backend = request.config.getoption('--database-backend')
@ -25,6 +29,7 @@ def config(request, monkeypatch):
return config return config
@pytest.mark.skipif(reason='will be fixed in another PR')
def test_bigchain_class_default_initialization(config): def test_bigchain_class_default_initialization(config):
from bigchaindb.tendermint import BigchainDB from bigchaindb.tendermint import BigchainDB
from bigchaindb.consensus import BaseConsensusRules from bigchaindb.consensus import BaseConsensusRules
@ -37,6 +42,7 @@ def test_bigchain_class_default_initialization(config):
assert bigchain.consensus == BaseConsensusRules assert bigchain.consensus == BaseConsensusRules
@pytest.mark.skipif(reason='will be fixed in another PR')
def test_bigchain_class_initialization_with_parameters(config): def test_bigchain_class_initialization_with_parameters(config):
from bigchaindb.tendermint import BigchainDB from bigchaindb.tendermint import BigchainDB
from bigchaindb.backend import connect from bigchaindb.backend import connect
@ -56,6 +62,7 @@ def test_bigchain_class_initialization_with_parameters(config):
assert bigchain.consensus == BaseConsensusRules assert bigchain.consensus == BaseConsensusRules
@pytest.mark.skipif(reason='will be fixed in another PR')
def test_get_blocks_status_containing_tx(monkeypatch): def test_get_blocks_status_containing_tx(monkeypatch):
from bigchaindb.backend import query as backend_query from bigchaindb.backend import query as backend_query
from bigchaindb.tendermint import BigchainDB from bigchaindb.tendermint import BigchainDB
@ -77,6 +84,8 @@ def test_get_spent_issue_1271(b, alice, bob, carol):
[carol.public_key], [carol.public_key],
[([carol.public_key], 8)], [([carol.public_key], 8)],
).sign([carol.private_key]) ).sign([carol.private_key])
assert b.validate_transaction(tx_1)
b.store_bulk_transactions([tx_1])
tx_2 = Transaction.transfer( tx_2 = Transaction.transfer(
tx_1.to_inputs(), tx_1.to_inputs(),
@ -85,6 +94,8 @@ def test_get_spent_issue_1271(b, alice, bob, carol):
([carol.public_key], 4)], ([carol.public_key], 4)],
asset_id=tx_1.id, asset_id=tx_1.id,
).sign([carol.private_key]) ).sign([carol.private_key])
assert b.validate_transaction(tx_2)
b.store_bulk_transactions([tx_2])
tx_3 = Transaction.transfer( tx_3 = Transaction.transfer(
tx_2.to_inputs()[2:3], tx_2.to_inputs()[2:3],
@ -92,20 +103,25 @@ def test_get_spent_issue_1271(b, alice, bob, carol):
([carol.public_key], 3)], ([carol.public_key], 3)],
asset_id=tx_1.id, asset_id=tx_1.id,
).sign([carol.private_key]) ).sign([carol.private_key])
assert b.validate_transaction(tx_3)
b.store_bulk_transactions([tx_3])
tx_4 = Transaction.transfer( tx_4 = Transaction.transfer(
tx_2.to_inputs()[1:2] + tx_3.to_inputs()[0:1], tx_2.to_inputs()[1:2] + tx_3.to_inputs()[0:1],
[([bob.public_key], 3)], [([bob.public_key], 3)],
asset_id=tx_1.id, asset_id=tx_1.id,
).sign([alice.private_key]) ).sign([alice.private_key])
assert b.validate_transaction(tx_4)
b.store_bulk_transactions([tx_4])
tx_5 = Transaction.transfer( tx_5 = Transaction.transfer(
tx_2.to_inputs()[0:1], tx_2.to_inputs()[0:1],
[([alice.public_key], 2)], [([alice.public_key], 2)],
asset_id=tx_1.id, asset_id=tx_1.id,
).sign([bob.private_key]) ).sign([bob.private_key])
block_5 = b.create_block([tx_1, tx_2, tx_3, tx_4, tx_5]) assert b.validate_transaction(tx_5)
b.write_block(block_5) b.store_bulk_transactions([tx_5])
assert b.get_spent(tx_2.id, 0) == tx_5 assert b.get_spent(tx_2.id, 0) == tx_5
assert not b.get_spent(tx_5.id, 0) assert not b.get_spent(tx_5.id, 0)
assert b.get_outputs_filtered(alice.public_key) assert b.get_outputs_filtered(alice.public_key)