Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: boolean skip_id parameter is always called with True

Browse Source 
Solution: Removed the parameter
This commit is contained in:
z-bowen 2018-09-10 11:03:12 +02:00
parent 15b5f730bf
commit e302a4b8f3
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bigchaindb/elections/election.py
View File

@ -138,16 +138,14 @@ class Election(Transaction):
(inputs, outputs) = cls.validate_create(initiator, voters, election_data, metadata) (inputs, outputs) = cls.validate_create(initiator, voters, election_data, metadata)
election = cls(cls.OPERATION, {'data': election_data}, inputs, outputs, metadata) election = cls(cls.OPERATION, {'data': election_data}, inputs, outputs, metadata)
cls.validate_schema(election.to_dict(), skip_id=True) cls.validate_schema(election.to_dict())
return election return election
@classmethod @classmethod
def validate_schema(cls, tx, skip_id=False): def validate_schema(cls, tx):
"""Validate the election transaction. Since `ELECTION` extends `CREATE` transaction, all the validations for """Validate the election transaction. Since `ELECTION` extends `CREATE` transaction, all the validations for
`CREATE` transaction should be inherited `CREATE` transaction should be inherited
""" """
if not skip_id:
cls.validate_id(tx)
_validate_schema(TX_SCHEMA_COMMON, tx) _validate_schema(TX_SCHEMA_COMMON, tx)
_validate_schema(TX_SCHEMA_CREATE, tx) _validate_schema(TX_SCHEMA_CREATE, tx)
if cls.TX_SCHEMA_CUSTOM: if cls.TX_SCHEMA_CUSTOM:

4
bigchaindb/upsert_validator/validator_election.py
View File

@ -32,8 +32,8 @@ class ValidatorElection(Election):
return self return self
@classmethod @classmethod
def validate_schema(cls, tx, skip_id=False): def validate_schema(cls, tx):
super(ValidatorElection, cls).validate_schema(tx, skip_id=skip_id) super(ValidatorElection, cls).validate_schema(tx)
validate_asset_public_key(tx['asset']['data']['public_key']) validate_asset_public_key(tx['asset']['data']['public_key'])
@classmethod @classmethod