From eb362fd6e9f1d3de24f427dd4e0bb665a48a7034 Mon Sep 17 00:00:00 2001 From: Brett Sun Date: Wed, 16 Nov 2016 11:21:25 +0100 Subject: [PATCH] Fix equality check for AssetLinks (#825) --- bigchaindb/common/transaction.py | 2 +- tests/common/test_transaction.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/bigchaindb/common/transaction.py b/bigchaindb/common/transaction.py index c87b9864..74a781f3 100644 --- a/bigchaindb/common/transaction.py +++ b/bigchaindb/common/transaction.py @@ -541,7 +541,7 @@ class AssetLink(Asset): def __eq__(self, other): return isinstance(other, AssetLink) and \ - self.to_dict() == self.to_dict() + self.to_dict() == other.to_dict() @classmethod def from_dict(cls, link): diff --git a/tests/common/test_transaction.py b/tests/common/test_transaction.py index baba35af..2675ca07 100644 --- a/tests/common/test_transaction.py +++ b/tests/common/test_transaction.py @@ -516,6 +516,16 @@ def test_cast_asset_link_to_boolean(): assert bool(AssetLink(False)) is True +def test_eq_asset_link(): + from bigchaindb.common.transaction import AssetLink + + asset_id_1 = 'asset_1' + asset_id_2 = 'asset_2' + + assert AssetLink(asset_id_1) == AssetLink(asset_id_1) + assert AssetLink(asset_id_1) != AssetLink(asset_id_2) + + def test_add_fulfillment_to_tx(user_ffill): from bigchaindb.common.transaction import Transaction, Asset