Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

better logging and arrangement for vote verification

Browse Source
This commit is contained in:
Scott Sadler 2016-11-25 11:26:04 +01:00
parent c43bf10151
commit ef5f3ddd28
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
bigchaindb/consensus.py
View File

@ -1,5 +1,11 @@
import logging
from bigchaindb.util import verify_vote_signature
from bigchaindb.common.schema import validate_vote_schema, SchemaValidationError
from bigchaindb.common.schema import SchemaValidationError, \
validate_vote_schema
logger = logging.getLogger(__name__)
class BaseConsensusRules():
@ -26,10 +32,12 @@ class BaseConsensusRules():
Refer to the documentation of
:func:`bigchaindb.util.verify_signature`.
"""
try:
validate_vote_schema(signed_vote)
except SchemaValidationError:
# TODO: log this.
return False
else:
return verify_vote_signature(voters, signed_vote)
if verify_vote_signature(voters, signed_vote):
try:
validate_vote_schema(signed_vote)
return True
except SchemaValidationError as exc:
logger.warning(exc)
logger.warning("Vote failed signature verification: "
"%s with voters: %s", signed_vote, voters)
return False