Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: No need to specify delegation support in approve command

Browse Source 
Solution: remove code comment
This commit is contained in:
Vanshdeep Singh 2018-08-28 11:55:07 +02:00
parent 4f7a5d2028
commit f36a56d4f0
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bigchaindb/commands/bigchaindb.py
View File

@ -174,9 +174,6 @@ def run_upsert_validator_approve(args, bigchain):
logger.error('The key you provided does not match any of the eligible voters in this election.') logger.error('The key you provided does not match any of the eligible voters in this election.')
return False return False
# NOTE: The code below assumes no vote delegation has taken place. Vote delegation
# is a by-product of the transaction state model which hasn't been offered as
# feature in current version of upsert-validator
inputs = [i for i in tx.to_inputs() if key.public_key in i.owners_before] inputs = [i for i in tx.to_inputs() if key.public_key in i.owners_before]
election_pub_key = ValidatorElection.to_public_key(tx.id) election_pub_key = ValidatorElection.to_public_key(tx.id)
approval = ValidatorElectionVote.generate(inputs, approval = ValidatorElectionVote.generate(inputs,

4
docs/server/source/server-reference/bigchaindb-cli.md
View File

@ -83,7 +83,7 @@ configuration file as documented under
## bigchaindb upsert-validator ## bigchaindb upsert-validator
Manage elections to add, update, or remove a validator from the validators set. The upsert-validator subcommands implement [BEP-21](https://github.com/bigchaindb/BEPs/tree/master/21), please refer the BEP for more details. Manage elections to add, update, or remove a validator from the validators set. The upsert-validator subcommands implement [BEP-21](https://github.com/bigchaindb/BEPs/tree/master/21), please refer it for more details.
Election management is broken into several subcommands. Below is the command line syntax for each, Election management is broken into several subcommands. Below is the command line syntax for each,
@ -113,7 +113,7 @@ $ bigchaindb upsert-validator new HHG0IQRybpT6nJMIWWFWhMczCLHt6xcm7eP52GnGuPY= 1
[SUCCESS] Submitted proposal with id: 04a067582cf03eba2b53b82e4adb5ece424474cbd4f7183780855a93ac5e3caa [SUCCESS] Submitted proposal with id: 04a067582cf03eba2b53b82e4adb5ece424474cbd4f7183780855a93ac5e3caa
``` ```
If the command succeeds, it will create an election and return an `election_id`. A successful execution of the above command **doesn't** imply that the validator set will be immediately updated but rather it means the proposal has been succcessfully accepted by the network. Once the `election_id` has been generated the node operator should share this `election_id** with other validators in the network and urge them to approve the proposal. Note that the node operator should themsleves also approve the proposal. If the command succeeds, it will create an election and return an `election_id`. A successful execution of the above command **doesn't** imply that the validator set will be immediately updated but rather it means the proposal has been succcessfully accepted by the network. Once the `election_id` has been generated the node operator should share this `election_id` with other validators in the network and urge them to approve the proposal. Note that the node operator should themsleves also approve the proposal.
**NOTE**: The election proposal consists of vote tokens allocated to each current validator as per their voting power. Validators then cast their votes to approve the change to the validator set by spending their vote tokens. **NOTE**: The election proposal consists of vote tokens allocated to each current validator as per their voting power. Validators then cast their votes to approve the change to the validator set by spending their vote tokens.