bump version and update changelog for 0.8.2

v0.8.0 doesn't actually do transaction schema validation. That got merged shortly _after_ the v0.8.0 release, in PR #880

CHANGELOG.md

@@ -16,6 +16,27 @@ For reference, the possible headings are:
 * **Notes**
 
 
+## [0.8.2] - 2017-01-27
+Tag name: v0.8.2
+
+### Fixed
+- Fix spend input twice in same transaction
+  (https://github.com/bigchaindb/bigchaindb/issues/1099).
+
+
+## [0.8.1] - 2017-01-16
+Tag name: v0.8.1
+= commit:
+committed:
+
+### Changed
+- Upgrade pysha3 to 1.0.0 (supports official NIST standard).
+
+### Fixed
+- Workaround for rapidjson problem with package metadata extraction
+  (https://github.com/kenrobbins/python-rapidjson/pull/52). 
+
+
 ## [0.8.0] - 2016-11-29
 Tag name: v0.8.0
 = commit:
@@ -23,7 +44,7 @@ committed:
 
 ### Added
 - The big new thing in version 0.8.0 is support for divisible assets, i.e. assets like carrots or thumbtacks, where the initial CREATE transaction can register/create some amount (e.g. 542 carrots), the first TRANSFER transaction can split that amount across multiple owners, and so on. [Pull Request #794](https://github.com/bigchaindb/bigchaindb/pull/794)
-- Wrote a formal schema for the JSON structure of transactions. Transactions are now checked against that schema. [Pull Request #798](https://github.com/bigchaindb/bigchaindb/pull/798)
+- Wrote a formal schema for the JSON structure of transactions. [Pull Request #798](https://github.com/bigchaindb/bigchaindb/pull/798)
 - New configuration parameter: `backlog_reassign_delay`. [Pull Request #883](https://github.com/bigchaindb/bigchaindb/pull/883)
 
 ### Changed

Dockerfile

@@ -1,6 +1,16 @@
 FROM rethinkdb:2.3
 
-RUN apt-get update
+# From http://stackoverflow.com/a/38553499
+
+RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y locales
+
+RUN sed -i -e 's/# en_US.UTF-8 UTF-8/en_US.UTF-8 UTF-8/' /etc/locale.gen && \
+    echo 'LANG="en_US.UTF-8"'>/etc/default/locale && \
+    dpkg-reconfigure --frontend=noninteractive locales && \
+    update-locale LANG=en_US.UTF-8
+
+ENV LANG en_US.UTF-8
+
 RUN apt-get -y install python3 python3-pip libffi-dev
 RUN pip3 install --upgrade pip
 RUN pip3 install --upgrade setuptools

bigchaindb/models.py

@@ -79,6 +79,11 @@ class Transaction(Transaction):
                     raise AmountError('`amount` needs to be greater than zero')
                 input_amount += input_tx.conditions[input_cid].amount
 
+            # Validate that all inputs are distinct
+            links = [(f.tx_input.txid, f.tx_input.cid) for f in self.fulfillments]
+            if len(links) != len(set(links)):
+                raise DoubleSpend('tx "{}" spends inputs twice'.format(self.id))
+
             # validate asset id
             asset_id = Asset.get_asset_id(input_txs)
             if asset_id != self.asset.data_id:

bigchaindb/version.py

@@ -1,2 +1,2 @@
-__version__ = '0.8.0'
+__version__ = '0.8.2'
 __short_version__ = '0.8'

setup.py

@@ -58,7 +58,7 @@ benchmarks_require = [
 
 install_requires = [
     'rethinkdb~=2.3',  # i.e. a version between 2.3 and 3.0
-    'pysha3>=0.3',
+    'pysha3~=1.0.0',
     'cryptoconditions>=0.5.0',
     'statsd>=3.2.1',
     'python-rapidjson>=0.0.6',

tests/db/test_bigchain_api.py

@@ -1178,3 +1178,34 @@ class TestMultipleInputs(object):
         # check that the other remain marked as unspent
         for unspent in transactions[1:]:
             assert b.get_spent(unspent.id, 0) is None
+
+
+def test_cant_spend_same_input_twice_in_tx(b):
+    """
+    Recreate duplicated fulfillments bug
+    https://github.com/bigchaindb/bigchaindb/issues/1099
+    """
+    from bigchaindb.models import Asset, Transaction
+    from bigchaindb.common.exceptions import DoubleSpend
+
+    # create a divisible asset
+    tx_create = Transaction.create([b.me], [([b.me], 100)],
+                                   asset=Asset(divisible=True))
+    tx_create_signed = tx_create.sign([b.me_private])
+    assert b.validate_transaction(tx_create_signed) == tx_create_signed
+
+    ## create a block and valid vote
+    b.create_genesis_block()
+    block = b.create_block([tx_create_signed])
+    b.write_block(block, durability='hard')
+    vote = b.vote(block.id, b.get_last_voted_block().id, True)
+    b.write_vote(vote)
+
+    # Create a transfer transaction with duplicated fulfillments
+    dup_inputs = tx_create.to_inputs() + tx_create.to_inputs()
+    tx_transfer = Transaction.transfer(dup_inputs, [([b.me], 200)],
+                                       asset=tx_create_signed.asset)
+    tx_transfer_signed = tx_transfer.sign([b.me_private])
+    assert b.is_valid_transaction(tx_transfer_signed) is False
+    with pytest.raises(DoubleSpend):
+        tx_transfer_signed.validate(b)