Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

etcdserver, wal: Fix tests that were performing unintended casting of int to String.

Browse Source 
Fixes following problems during "./etcd# go test ./..."

> go.etcd.io/etcd/v3/etcdserver/api/v2store_test
etcdserver/api/v2store/store_test.go:847:24: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

> go.etcd.io/etcd/v3/wal
wal/wal_test.go:242:68: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
This commit is contained in:
Piotr Tabor 2020-08-04 13:18:49 +02:00
parent 1af6d61a1c
commit 00de56a4a4
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
etcdserver/api/v2store/store_test.go
View File

@ -15,6 +15,7 @@
package v2store_test package v2store_test
import ( import (
"fmt"
"testing" "testing"
"time" "time"
@ -844,7 +845,7 @@ func TestStoreWatchSlowConsumer(t *testing.T) {
s.Watch("/foo", true, true, 0) // stream must be true s.Watch("/foo", true, true, 0) // stream must be true
// Fill watch channel with 100 events // Fill watch channel with 100 events
for i := 1; i <= 100; i++ { for i := 1; i <= 100; i++ {
s.Set("/foo", false, string(i), v2store.TTLOptionSet{ExpireTime: v2store.Permanent}) // ok s.Set("/foo", false, fmt.Sprint(i), v2store.TTLOptionSet{ExpireTime: v2store.Permanent}) // ok
} }
// testutil.AssertEqual(t, s.WatcherHub.count, int64(1)) // testutil.AssertEqual(t, s.WatcherHub.count, int64(1))
s.Set("/foo", false, "101", v2store.TTLOptionSet{ExpireTime: v2store.Permanent}) // ok s.Set("/foo", false, "101", v2store.TTLOptionSet{ExpireTime: v2store.Permanent}) // ok

2
wal/wal_test.go
View File

@ -239,7 +239,7 @@ func TestVerify(t *testing.T) {
// make 5 separate files // make 5 separate files
for i := 0; i < 5; i++ { for i := 0; i < 5; i++ {
es := []raftpb.Entry{{Index: uint64(i), Data: []byte("waldata" + string(i+1))}} es := []raftpb.Entry{{Index: uint64(i), Data: []byte(fmt.Sprintf("waldata%d", i+1))}}
if err = w.Save(raftpb.HardState{}, es); err != nil { if err = w.Save(raftpb.HardState{}, es); err != nil {
t.Fatal(err) t.Fatal(err)
} }