client: pass httpActionDo into New[Discovery]KeysAPI

client/keys.go

@@ -41,27 +41,20 @@ var (
 	ErrKeyExists   = errors.New("client: key already exists")
 )
 
-func NewKeysAPI(tr *http.Transport, eps []string, to time.Duration) (KeysAPI, error) {
+func NewKeysAPI(c httpActionDo, to time.Duration) KeysAPI {
-	return newHTTPKeysAPIWithPrefix(tr, eps, to, DefaultV2KeysPrefix)
+	return &httpKeysAPI{
-}
-
-func NewDiscoveryKeysAPI(tr *http.Transport, eps []string, to time.Duration) (KeysAPI, error) {
-	return newHTTPKeysAPIWithPrefix(tr, eps, to, "")
-}
-
-func newHTTPKeysAPIWithPrefix(tr *http.Transport, eps []string, to time.Duration, prefix string) (*httpKeysAPI, error) {
-	c, err := NewHTTPClient(tr, eps)
-	if err != nil {
-		return nil, err
-	}
-
-	kAPI := httpKeysAPI{
 		client:  c,
-		prefix:  prefix,
+		prefix:  DefaultV2KeysPrefix,
 		timeout: to,
 	}
+}
 
-	return &kAPI, nil
+func NewDiscoveryKeysAPI(c httpActionDo, to time.Duration) KeysAPI {
+	return &httpKeysAPI{
+		client:  c,
+		prefix:  "",
+		timeout: to,
+	}
 }
 
 type KeysAPI interface {

discovery/discovery.go

@@ -106,15 +106,16 @@ func New(durl string, id types.ID, config string) (Discoverer, error) {
 	if err != nil {
 		return nil, err
 	}
-	c, err := client.NewDiscoveryKeysAPI(&http.Transport{Proxy: pf}, []string{u.String()}, client.DefaultRequestTimeout)
+	c, err := client.NewHTTPClient(&http.Transport{Proxy: pf}, []string{u.String()})
 	if err != nil {
 		return nil, err
 	}
+	dc := client.NewDiscoveryKeysAPI(c, client.DefaultRequestTimeout)
 	return &discovery{
 		cluster: token,
 		id:      id,
 		config:  config,
-		c:       c,
+		c:       dc,
 		url:     u,
 		clock:   clockwork.NewRealClock(),
 	}, nil